Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 12 Oct 2022 14:14:59 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Daniel Shelepanov <deniel1495@mail.ru>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Andres Freund <andres@anarazel.de>
Subject: Re: collect_corrupt_items_vacuum.patch
Message-ID: <Y0ZNU8v0bYIHc5cj@paquier.xyz>
References: <1649062270.289865713@f403.i.mail.ru>
 <CA+TgmoZtw7yNZogHFrgatHnvc2rOX9hoRRq=GtUBZx9mxh86Vg@mail.gmail.com>
 <3107109.1658958956@sss.pgh.pa.us>
 <CA+TgmoYmGN6ivwioc4YaEQqGOS2oH=0jDYMVghb6Vd5hx6bwtA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wmjrBQvS+kd5AsLy"
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoYmGN6ivwioc4YaEQqGOS2oH=0jDYMVghb6Vd5hx6bwtA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Y0ZNU8v0bYIHc5cj%40paquier.xyz>
Precedence: bulk


--wmjrBQvS+kd5AsLy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 27, 2022 at 09:47:19PM -0400, Robert Haas wrote:
> On Wed, Jul 27, 2022 at 5:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Maybe we need a different function for pg_visibility to call?
> > If we want ComputeXidHorizons to serve both these purposes, then it
> > has to always deliver exactly the right answer, which seems like
> > a definition that will be hard and expensive to achieve.
>=20
> Yeah, I was thinking along similar lines.
>=20
> I'm also kind of wondering why these calculations use
> latestCompletedXid. Is that something we do solely to reduce locking?
> The XIDs of running transactions matter, and their snapshots matter,
> and the XIDs that could start running in the future matter, but I
> don't know why it matters what the latest completed XID is.

Daniel, it seems to me that this thread is waiting for some input from
you, based on the remarks of Tom and Robert.  Are you planning to do
so?  This is marked as a bug fix, so I have moved this item to the
next CF for now.
--
Michael

--wmjrBQvS+kd5AsLy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNGTVIACgkQnvQgOdby
QH1NZw/+LWKe4WStvJH2/037UH04+pM0XBEnkGc0sr0KOu6LoLzMoTgrPREpClEI
mDPSFr/XFb9XJpRDeUn5/U7bgBYkRVu5EEu4PmEOyrXDHvrkRvLyjkGR2G+3SHmo
3f+e70UpQcmCvvNukr4z2EFOMy3WFTvHzgvqHlvT7Znf5vYJZdAVSIBeyj7FUWp1
UGEiiNLynLcuWjEihudekBdW/JvsZyZzV0cTsvG5wGXqQ+abAzO0ldDYnoUE/z+t
EBBixgDML4WCEJCBKblD8wORAoJfU4RKKqNqRD/1OLka53rv1lfwSeRSEO0o8l3x
RUioGQB08bP/gpMw9pUzjxFnwiEOTnQzM8KJ1X3UBvvyRGZBy1jmXhglacQR4Kpm
tiI04sNRwWLiLfZY0JV0idR879dfeAiyeJamGqTgF1QBQwYKz7JBFZq4glEkoTDM
dKpI4yHzl2YkTfkJfLAJ3SS3fn0ZTT+OPWtIedGGUTYkLE/zj9fwXwhubI0nfpZK
EvmWNZwSEaEhmg7ImQTFf9rQQTKQoAz/zqwOlCUEjI5PnmTevshNY7i9oHWiY3wF
HfzLSZjHuhkN7EMNGmLqx3HR3xSbaIkYt80tofyoIjolw/KtXsrrxrY3n9C1PD65
hSp597zQOBRzWy6M3miWYWkt00dhnD/OH3PdYvewiOLqRY8XoFQ=
=2o2z
-----END PGP SIGNATURE-----

--wmjrBQvS+kd5AsLy--