Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 12 Oct 2022 14:50:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Jacob Champion <jchampion@timescale.com>, Jan Wieck <jan@wi3ck.info>,
	Tom Lane <tgl@sss.pgh.pa.us>, Bruce Momjian <bruce@momjian.us>,
	Zhihong Yu <zyu@yugabyte.com>, Andrew Dunstan <andrew@dunslane.net>,
	Magnus Hagander <magnus@hagander.net>,
	Robins Tharakan <tharakan@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade failing for 200+ million Large Objects
Message-ID: <Y0ZVk5ILZqYKEL+Z@paquier.xyz>
References: <988415.1616528159@sss.pgh.pa.us>
 <872315a8-99fc-da4e-463d-784cfb5a025d@wi3ck.info>
 <1010642.1616532950@sss.pgh.pa.us>
 <802b96e9-f5e1-015c-dfb9-8756974b11fc@wi3ck.info>
 <0263bf35-05d6-02a1-519b-b7895a918314@wi3ck.info>
 <20220825003227.GA1456581@nathanxps13>
 <663393ca-b2ff-26f0-2e2d-adc942aff4fd@timescale.com>
 <20220908231807.GA2242918@nathanxps13>
 <CAAWbhmgUb8p7ff_ZX5jCvqM=ipPxbbDJTXMNVzH-Ho_CXVkRHA@mail.gmail.com>
 <20220908233407.GA2244644@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Z4cvF2FQaYe+xwFT"
Content-Disposition: inline
In-Reply-To: <20220908233407.GA2244644@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/Y0ZVk5ILZqYKEL%2BZ%40paquier.xyz>
Precedence: bulk


--Z4cvF2FQaYe+xwFT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 08, 2022 at 04:34:07PM -0700, Nathan Bossart wrote:
> On Thu, Sep 08, 2022 at 04:29:10PM -0700, Jacob Champion wrote:
>> To clarify, I agree that pg_dump should contain the core fix. What I'm
>> questioning is the addition of --dump-options to make use of that fix
>> from pg_upgrade, since it also lets the user do "exciting" new things
>> like --exclude-schema and --include-foreign-data and so on. I don't
>> think we should let them do that without a good reason.
>=20
> Ah, yes, I think that is a fair point.

It has been more than four weeks since the last activity of this
thread and there has been what looks like some feedback to me, so
marked as RwF for the time being.
--
Michael

--Z4cvF2FQaYe+xwFT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNGVZMACgkQnvQgOdby
QH2Tnw//e4swOy4vifXBPeQUuQvsQmnGC1TOOde2ayS6tJLX8D/Xk0/zzilDaKZq
7dcXV00A0ADdkYsd+XI5QR4LtXTdkE40jLvYikXgBLZHk6zIV/oUBsToL/fkHoOg
xy0e7hIerwRoy1Ea7zFR77x07OkDlBQyW2Z5YJVGtsx/J+aGglV5/YZyNBfu5Ctb
2wniv7CLC3HW5UgtLKr3UTd1uFNmjQl7ksczWyV1LaZDE+k+RJsA7rsIxHvxlW3n
Sr3Zi+Am3oxvar/C6UOqOQ35EyYhE9tu1I9quJn1WnbToszpHl712QO+CDL6qxIq
PjBNklFYgz//GxF/3CH1RPbqWwU1BCNhr0NUJftN8aJ8WqxvKwMet/dfZHji2UhM
QMDS2hfA6sYITc+DvtJXl6r3Fs1ZWLxUMp2QR/3uItgtfCV97Q9dlnzFJZHL0qok
3/+5W5+rXpxg6MgTUdWV7GqowPbkB/xIScKLsjBltl0qo2vcljn/OynmxanHJOSc
0O9JNjGWqRhQ5usJf3gBRPboRirWSi1Jn45BtvnlKInqCka6ZrUgti4H01fsQRFE
ItM5PG+Qgq2urH1ipLJFq7KMxJFvy7jYFbW0s2oxRWAF1sQzKYpdEPE3i0QTum/Q
XRe1I9fhyHgqVzRpXJSgmTj54TyJutYpc/4/KSFSY7mFsnSZFyg=
=cRii
-----END PGP SIGNATURE-----

--Z4cvF2FQaYe+xwFT--