Date: Sun, 16 Oct 2022 12:04:09 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Joe Conway <mail@joeconway.com>,
	Michael Paquier <michael@paquier.xyz>,
	Joshua Brindle <joshua.brindle@crunchydata.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: use has_privs_of_role() for pg_hba.conf
Message-ID: <Y0wreaRUEnMiTSlC@tamriel.snowman.net>
References: <Yz+Jt9537vjfO733@paquier.xyz>
 <20221007032711.GA499771@nathanxps13>
 <Yz/Ii6dr1CSu4Bnv@paquier.xyz>
 <20221007194430.GA550749@nathanxps13>
 <3347532.1665173939@sss.pgh.pa.us>
 <20221007215836.GB814385@nathanxps13>
 <87994809-5b2c-08f0-0ab3-3c76c49afada@joeconway.com>
 <3574712.1665242046@sss.pgh.pa.us>
 <CA+TgmoYDUpotJ3R5cPWqKZpi7TmTRq2ud4OYsvWnvPYK0KmaAQ@mail.gmail.com>
 <20221008170640.GA825354@nathanxps13>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="C5hrS8LzPlYhDf2K"
Content-Disposition: inline
In-Reply-To: <20221008170640.GA825354@nathanxps13>
User-Agent: Mutt/2.1.4 (2021-12-11)
Archived-At: 
 <https://www.postgresql.org/message-id/Y0wreaRUEnMiTSlC%40tamriel.snowman.net>
Precedence: bulk


--C5hrS8LzPlYhDf2K
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Nathan Bossart (nathandbossart@gmail.com) wrote:
> On Sat, Oct 08, 2022 at 11:46:50AM -0400, Robert Haas wrote:
> > Now there may be some other scenario in which the patch is going in
> > exactly the right direction, and if I knew what it was, maybe I'd
> > agree that the patch was a great idea. But I haven't seen anything
> > like that on the thread. Basically, the argument is just that the
> > change would make things more consistent. However, it might be an
> > abuse of the term. If you go out and buy blue curtains because you
> > have a blue couch, that's consistent interior decor. If you go out and
> > buy a blue car because you have a blue couch, that's not really
> > consistent anything, it's just two fairly-unrelated things that are
> > both blue.
>=20
> I believe I started this thread after reviewing the remaining uses of
> is_member_of_role() after 6198420 was committed and wondering whether this
> case was an oversight.  If upon closer inspection we think that mere
> membership is appropriate for pg_hba.conf, I'm fully prepared to go and
> mark this commitfest entry as Rejected.  It obviously does not seem as
> clear-cut as 6198420.  And I'll admit I don't have a concrete use-case in
> hand to justify the behavior change.

Looks like we've already ended up there, but my recollection of this is
that it was very much intentional to use is_member_of_role() here.
Perhaps it should have been better commented (as all uses of
is_member_of_role() instead of has_privs_of_role() really should have
lots of comments as to exactly why it makes sense in those cases).

Thanks,

Stephen

--C5hrS8LzPlYhDf2K
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEwf6gbxKhD863zrx/7WyKOINHZFUFAmNMK3UACgkQ7WyKOINH
ZFUuCw/5AR8lQ7vaYtAyVUgiOIwZAmV9+n4aylec4fzozDfs3CXS/IeRQZTHyNmc
u/j9Z7fY0QQHGJLluPs7O5PUQIWNgOePUc9q8lJI6CcciCzP/6S4dDPLP7mViHA4
7INx4eRcShRv7LjjCa1Zfp+4aJZ/9dTSKeMwzicI451VWcre8DWM1wsoGE2Xd5hR
NM4YI4UsLw2GqEMIcgs7Os8rFLTER9jNksIw07Lb2OWgBnOqS4sSP8l4gNG+V+Hh
bvrWiRB3GZj88RA5ehJwF9DzIJD2RsW3KeFcTqvWtDEEFneg5B/jYXn/hyGBN5iF
XeVwjkAmPKsQZLcgKlbDylPJ8SzRCtDR9K/BMiqOYoqp8Y7lLWn6IOsSYeCGhFpy
4lBJoQcIXo3YqC/p5esIDWtPui59BMylhQA7+JTzPrgMlcCTHVcwj7Nuo64cYNMJ
5W4q+LriatZLQ9J+yhVbow2tzY4XkM+9GIwMpEshJiOgypvBQaNljirRbIIcGjPu
WGX9h92i9L0wBnmBkkWVGk7Syt+8EIyIuVlEx+qcH1ufVIzplO1Zk25Ftf+4MhhF
rFJD+eeN8zkvhcX8b0pL2fjLUBkep1NhW0dRi7238t82oBXx1e1R1kGDuOmaUNHZ
GaJzC+IDT43V+q2zlBIrFHCyrM2DYt9Ln9zLkrhUPYDQia4OEG0=
=garA
-----END PGP SIGNATURE-----

--C5hrS8LzPlYhDf2K--