Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 21 Oct 2022 15:00:56 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Maxim Orlov <orlovmg@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: making relfilenodes 56 bits
Message-ID: <Y1I1mD0OhjbdXPNS@paquier.xyz>
References: 
 <CAA4eK1+f=4O+yne0UHAm=UCjtP2V8cKjHTzFCd3ufgP9=cCDhg@mail.gmail.com>
 <CAFiTN-uojTY8Nzb_+ZSmY4YvAbe+JD2JiEmV1p14Drdiay1x4A@mail.gmail.com>
 <CAFiTN-s-BJ2URukJDYLbJh47td6xzcmE6S8R4r=FcnWcYSDnZQ@mail.gmail.com>
 <CA+Tgmoas+r!bA-_DQ8cWrJGhWt_WxdeSrpkOTk=2WuW7_i+bL1Q@mail.gmail.com>
 <CAFiTN-tVUocDK8Gi=rUs+4xUX35zApV725TtYdPX8qoYH7wsXA@mail.gmail.com>
 <CAFiTN-un8Q5dOryPnqNvenN6hrDaoBP6C_KJH64v6NMAbHfeHA@mail.gmail.com>
 <CA+TgmobFti5JuRZKq7hF8JJJgmyr1vpC-cOsu3dVc1dka9wApA@mail.gmail.com>
 <339122.1664476784@sss.pgh.pa.us>
 <YzY0iLxNbmaxHpbs@paquier.xyz>
 <506293.1664501018@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ozkl3bf3qPxYEr1X"
Content-Disposition: inline
In-Reply-To: <506293.1664501018@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/Y1I1mD0OhjbdXPNS%40paquier.xyz>
Precedence: bulk


--ozkl3bf3qPxYEr1X
Content-Type: multipart/mixed; boundary="eu8/0rNyq1nZNHJa"
Content-Disposition: inline


--eu8/0rNyq1nZNHJa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Sep 29, 2022 at 09:23:38PM -0400, Tom Lane wrote:
> Hmmm ... I'd tend to do SELECT COUNT(*) FROM.  But can't we provide
> any actual checks on the sanity of the output?  I realize that the
> output's far from static, but still ...

Honestly, checking all the fields is not that exciting, but the
maximum I can think of that would be portable enough is something like
the attached.  No arithmetic operators for xid limits things a bit,
but at least that's something.

Thoughts?
--
Michael

--eu8/0rNyq1nZNHJa
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="controldata-regression-2.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/regress/expected/misc_functions.out b/src/test/regres=
s/expected/misc_functions.out
index 9f106c2a10..38987e2afc 100644
--- a/src/test/regress/expected/misc_functions.out
+++ b/src/test/regress/expected/misc_functions.out
@@ -594,3 +594,89 @@ SELECT * FROM tenk1 a JOIN my_gen_series(1,10) g ON a.=
unique1 =3D g;
          Index Cond: (unique1 =3D g.g)
 (4 rows)
=20
+--
+-- Test functions for control data
+--
+\x
+SELECT checkpoint_lsn > '0/0'::pg_lsn AS checkpoint_lsn,
+    redo_lsn > '0/0'::pg_lsn AS redo_lsn,
+    redo_wal_file IS NOT NULL AS redo_wal_file,
+    timeline_id > 0 AS timeline_id,
+    prev_timeline_id > 0 AS prev_timeline_id,
+    next_xid IS NOT NULL AS next_xid,
+    next_oid > 0 AS next_oid,
+    next_multixact_id !=3D '0'::xid AS next_multixact_id,
+    next_multi_offset IS NOT NULL AS next_multi_offset,
+    oldest_xid !=3D '0'::xid AS oldest_xid,
+    oldest_xid_dbid > 0 AS oldest_xid_dbid,
+    oldest_active_xid !=3D '0'::xid AS oldest_active_xid,
+    oldest_multi_xid !=3D '0'::xid AS oldest_multi_xid,
+    oldest_multi_dbid > 0 AS oldest_multi_dbid,
+    oldest_commit_ts_xid IS NOT NULL AS oldest_commit_ts_xid,
+    newest_commit_ts_xid IS NOT NULL AS newest_commit_ts_xid
+  FROM pg_control_checkpoint();
+-[ RECORD 1 ]--------+--
+checkpoint_lsn       | t
+redo_lsn             | t
+redo_wal_file        | t
+timeline_id          | t
+prev_timeline_id     | t
+next_xid             | t
+next_oid             | t
+next_multixact_id    | t
+next_multi_offset    | t
+oldest_xid           | t
+oldest_xid_dbid      | t
+oldest_active_xid    | t
+oldest_multi_xid     | t
+oldest_multi_dbid    | t
+oldest_commit_ts_xid | t
+newest_commit_ts_xid | t
+
+SELECT max_data_alignment > 0 AS max_data_alignment,
+    database_block_size > 0 AS database_block_size,
+    blocks_per_segment > 0 AS blocks_per_segment,
+    wal_block_size > 0 AS wal_block_size,
+    max_identifier_length > 0 AS max_identifier_length,
+    max_index_columns > 0 AS max_index_columns,
+    max_toast_chunk_size > 0 AS max_toast_chunk_size,
+    large_object_chunk_size > 0 AS large_object_chunk_size,
+    float8_pass_by_value IS NOT NULL AS float8_pass_by_value,
+    data_page_checksum_version >=3D 0 AS data_page_checksum_version
+  FROM pg_control_init();
+-[ RECORD 1 ]--------------+--
+max_data_alignment         | t
+database_block_size        | t
+blocks_per_segment         | t
+wal_block_size             | t
+max_identifier_length      | t
+max_index_columns          | t
+max_toast_chunk_size       | t
+large_object_chunk_size    | t
+float8_pass_by_value       | t
+data_page_checksum_version | t
+
+SELECT min_recovery_end_lsn >=3D '0/0'::pg_lsn AS min_recovery_end_lsn,
+    min_recovery_end_timeline >=3D 0 AS min_recovery_end_timeline,
+    backup_start_lsn >=3D '0/0'::pg_lsn AS backup_start_lsn,
+    backup_end_lsn >=3D '0/0'::pg_lsn AS backup_end_lsn,
+    end_of_backup_record_required IS NOT NULL AS end_of_backup_record_requ=
ired
+  FROM pg_control_recovery();
+-[ RECORD 1 ]-----------------+--
+min_recovery_end_lsn          | t
+min_recovery_end_timeline     | t
+backup_start_lsn              | t
+backup_end_lsn                | t
+end_of_backup_record_required | t
+
+SELECT pg_control_version > 0 AS pg_control_version,
+    catalog_version_no > 0 AS catalog_version_no,
+    system_identifier >=3D 0 AS system_identifier,
+    pg_control_last_modified <=3D now() AS pg_control_last_modified
+  FROM pg_control_system();
+-[ RECORD 1 ]------------+--
+pg_control_version       | t
+catalog_version_no       | t
+system_identifier        | t
+pg_control_last_modified | t
+
diff --git a/src/test/regress/sql/misc_functions.sql b/src/test/regress/sql=
/misc_functions.sql
index 639e9b352c..986e07c3a5 100644
--- a/src/test/regress/sql/misc_functions.sql
+++ b/src/test/regress/sql/misc_functions.sql
@@ -223,3 +223,47 @@ SELECT * FROM tenk1 a JOIN my_gen_series(1,1000) g ON =
a.unique1 =3D g;
=20
 EXPLAIN (COSTS OFF)
 SELECT * FROM tenk1 a JOIN my_gen_series(1,10) g ON a.unique1 =3D g;
+
+--
+-- Test functions for control data
+--
+\x
+SELECT checkpoint_lsn > '0/0'::pg_lsn AS checkpoint_lsn,
+    redo_lsn > '0/0'::pg_lsn AS redo_lsn,
+    redo_wal_file IS NOT NULL AS redo_wal_file,
+    timeline_id > 0 AS timeline_id,
+    prev_timeline_id > 0 AS prev_timeline_id,
+    next_xid IS NOT NULL AS next_xid,
+    next_oid > 0 AS next_oid,
+    next_multixact_id !=3D '0'::xid AS next_multixact_id,
+    next_multi_offset IS NOT NULL AS next_multi_offset,
+    oldest_xid !=3D '0'::xid AS oldest_xid,
+    oldest_xid_dbid > 0 AS oldest_xid_dbid,
+    oldest_active_xid !=3D '0'::xid AS oldest_active_xid,
+    oldest_multi_xid !=3D '0'::xid AS oldest_multi_xid,
+    oldest_multi_dbid > 0 AS oldest_multi_dbid,
+    oldest_commit_ts_xid IS NOT NULL AS oldest_commit_ts_xid,
+    newest_commit_ts_xid IS NOT NULL AS newest_commit_ts_xid
+  FROM pg_control_checkpoint();
+SELECT max_data_alignment > 0 AS max_data_alignment,
+    database_block_size > 0 AS database_block_size,
+    blocks_per_segment > 0 AS blocks_per_segment,
+    wal_block_size > 0 AS wal_block_size,
+    max_identifier_length > 0 AS max_identifier_length,
+    max_index_columns > 0 AS max_index_columns,
+    max_toast_chunk_size > 0 AS max_toast_chunk_size,
+    large_object_chunk_size > 0 AS large_object_chunk_size,
+    float8_pass_by_value IS NOT NULL AS float8_pass_by_value,
+    data_page_checksum_version >=3D 0 AS data_page_checksum_version
+  FROM pg_control_init();
+SELECT min_recovery_end_lsn >=3D '0/0'::pg_lsn AS min_recovery_end_lsn,
+    min_recovery_end_timeline >=3D 0 AS min_recovery_end_timeline,
+    backup_start_lsn >=3D '0/0'::pg_lsn AS backup_start_lsn,
+    backup_end_lsn >=3D '0/0'::pg_lsn AS backup_end_lsn,
+    end_of_backup_record_required IS NOT NULL AS end_of_backup_record_requ=
ired
+  FROM pg_control_recovery();
+SELECT pg_control_version > 0 AS pg_control_version,
+    catalog_version_no > 0 AS catalog_version_no,
+    system_identifier >=3D 0 AS system_identifier,
+    pg_control_last_modified <=3D now() AS pg_control_last_modified
+  FROM pg_control_system();

--eu8/0rNyq1nZNHJa--

--ozkl3bf3qPxYEr1X
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNSNZgACgkQnvQgOdby
QH1eFg/6A8BujTuZqlMuhZFIaMwiuNY6AMzMHv2TSOGblUxno866E/8h597J771x
V9deq2s31RIsBhLcC9vaHOVCFha5RmkTGkSPz3L/CHOUpke8WgcjF/dyTLnRbbke
/+SfgFy6hcXsY+panuLWl6PQyiW2ajf00SQ3Xx6egY1vpoRt8dewyhKiZoACQJTu
hQzNbKbd/Pu3soymOPKsjYqOVRcs34FK6fmvkAQ4MTpmfWMOqf+XqM24dg7yd0Hy
vyrlsx3y4Z+3qIEIH+5iiMfUtReZuS3TkOwjEkS1wnoroxBcS+SNH3G3jzZED/Oa
9TfSNbA1GPARCJeroBMBvViNdIocQNX4NtZUwAvpcTmA6VhHAkg2An77/mEjnbV3
jq+bAshcvIv9TqyjnaQTLxKj1HT8b2JLnPBcE1a+XiwLnxdxrhdpTRgisNK8WQgl
FNyQE6K5ld6Nuv+g3iSBsv1BpPd6NSkq/7ZjqC7YBEHbj3qhDaRSlEmq9p9PZAZ/
GNNvTL0esnSOltUgd92CQJ3but0qgg01h2I9einDyYvFJy1jo/0HW2orOBNeHLrW
lmUy0npUVDvBROJWbGA/Sm+ZLRTzg9hZOGjltMbrUQVgdasJMCmfhgkYyANJ2VtN
MHX6j+mjE+vEdWNTG2O6APtivW8jNB7h1px80oPPLkQQmBIXfew=
=nC5h
-----END PGP SIGNATURE-----

--ozkl3bf3qPxYEr1X--