Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 26 Oct 2022 15:56:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Nathan Bossart <nathandbossart@gmail.com>
Subject: Re: Allow file inclusion in pg_hba and pg_ident files
Message-ID: <Y1jaB6bYPvxvPL4t@paquier.xyz>
References: <20220816061030.3xw7emtuxf32qmuk@jrouhaud>
 <20220917170612.wnyii63gblsgzane@jrouhaud>
 <20221010025132.mmfytfs52l6rvggw@jrouhaud>
 <20221024053312.b52456zhzupduouw@jrouhaud>
 <Y1Y7L42Ln7HVMWM5@paquier.xyz>
 <20221024080303.otukfbx54rwaqznn@jrouhaud>
 <Y1eFicewsea5yGRj@paquier.xyz>
 <20221025070859.l6eza2ixqfoatodd@jrouhaud>
 <Y1fPvQV387X/gVrK@paquier.xyz>
 <20221026031948.cbrnzgy5e7glsq2d@jrouhaud>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="3339UCLiae6dKnh4"
Content-Disposition: inline
In-Reply-To: <20221026031948.cbrnzgy5e7glsq2d@jrouhaud>
Archived-At: 
 <https://www.postgresql.org/message-id/Y1jaB6bYPvxvPL4t%40paquier.xyz>
Precedence: bulk


--3339UCLiae6dKnh4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 26, 2022 at 11:19:48AM +0800, Julien Rouhaud wrote:
> That wouldn't be overdoing anymore if we remove the line number / filenam=
e from
> the fill_*_line prototypes right?

So, I have spent a good portion of today looking at what you have
here, applying 0001 and 0003 while fixing, rebasing and testing the
whole, discarding 0002 (we could do more for the line number and
source file in terms of the LOGs reported for a regexec failure).=20

Now remains 0004, which is the core of the proposal, and while it
needs a rebase, I have not been able to spend much time looking at its
internals.  In order to help with the follow-up steps, I have spotted
a few areas that could be done first:
- The diffs in guc.h/c for the introduction of GetDirConfFiles() to
get a set of files in a directory (got to think a bit more about
ParseConfigFp() when it comes to the keywords, but that comes to play
with the parsing logic which is different).
- The TAP test, which is half the size of the patch in line number.
Could it be possible to make it more edible, introducing a basic
infrastructure to check a set of rules in pg_hba.conf and
pg_ident.conf without the inclusion logic?  Checks for error patterns
(that I agree we strongly lack tests for) look like something we'd
want to tackle independently of the inclusion logic, and it should be
built on top of a basic test infra, at least.
--
Michael

--3339UCLiae6dKnh4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNY2gcACgkQnvQgOdby
QH3lmxAAl1e2q+Hx+AtFuG/uFt6KbjOhT2br0ACKOstTcgcOERnjuHDignnSsgn5
Jq1OZbt27U8NU+ZbzqnTD16KjlvITuAHGgkOlYP13hHDCqoZXmls2JTWmNEIe7zr
s+0Ynya8fpjHgegIuanHfoRXlLJnJhrubWMIrOAZOmb3+Kyb8Z/X2dB3oY7XwOtA
fLa2wi8Y2QTJxFMQ4f6bbyV4QxyLGfmHBx2fmrSoB0wNzNZHVZ1uKDqhmsN7Ouz3
5ukx2JSK19z2bmI2ReUbDp/unOWdI0vK3M3lkWIVc1RoqzTvruuXyMYVzxL6V6mS
xCZjtgxGABKRGGnSO4Aeawy5fnttb44NLyXHFDtsDGnazQ4s+l1/7KsHqUsvzHvW
jxLGqEFPfbKjjgUokZzNSKGJUQPfS6vOOFg3Ol6bEEqx60aRv26nhBhPBxgM2fp2
n+vGJEZoU0K0JG/rbxxmXELUUa2MeTAiaFt2I/hzYbbvsIIvwAvhqkankwmoDzI8
IAphD5DbDnuUawJQQVN5molc/h9CYhQQ+G6O0dQ+PtJ2LDhvYXwj/sgjh/bOuioh
MZssFy90yDjL7RNCXHII/9XUZXh4kcnKYnf2RmU3yRbKKBBKTkloyvkpGttw6Bty
rT9QZqXMsb1il0Kh5cWqc7284K94b+vBhFYvHTYrX1n1VP7qC8M=
=nCtj
-----END PGP SIGNATURE-----

--3339UCLiae6dKnh4--