Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oq6KG-000634-BM for pgsql-hackers@arkaria.postgresql.org; Wed, 02 Nov 2022 05:30:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oq6KE-00079D-Kb for pgsql-hackers@arkaria.postgresql.org; Wed, 02 Nov 2022 05:30:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oq6KD-00075J-2W for pgsql-hackers@lists.postgresql.org; Wed, 02 Nov 2022 05:30:06 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oq6K9-0005O7-3o for pgsql-hackers@lists.postgresql.org; Wed, 02 Nov 2022 05:30:04 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id C5EC5320092A for ; Wed, 2 Nov 2022 01:29:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 02 Nov 2022 01:29:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t= 1667366996; x=1667453396; bh=OYjEcKDDxoXb7tG1uSMc/+eVykedEkKA+9i RAqYPphU=; b=H2/g4da1QjzRf7gQtvNDwSDxReDXaBrjG8kxLUpqDpJC+zBa49U nFhY7di+FyrmHket94uBv4y51BD11TMe5AvYx+duq77SnuQCBPX5e/zk0bYvV/hE qDWNV2k9gE9ryF6jj2VMrCqeluONp/pvGIDhZs3HSEODD/Crp820L9VZ1YBd9YSb gKlgcHJlSc5++zEeCI9NAQGOOF8o5r8SNTeEB3xypaBXy7172EQEg15XZRL99lnS wvS6k1Rt5AhDn8f2bLt+Kw7b8HjhAd/BcOB7JEUhQepoLjvTpCjfvl0aAa1lvfHM zQ6NrfSniykr3VD9MV++ohRn62WIvMXSJ0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667366996; x= 1667453396; bh=OYjEcKDDxoXb7tG1uSMc/+eVykedEkKA+9iRAqYPphU=; b=s RK1pr7rwTf+jsuXI8TY8mHIyM14gBJSnho+UWPf2AzWFqBvLJvbHaoUJQkl0VcyG /3jb80MIU9AhUtv3spBKpzPgdsI1AY3XHKiQCU9itHOS+siLVM6QMPBm7N43uGHJ 8TlAL0Ek6MIX8Us1Z53kHiA/Xhrf+YPyeRu2s3MWPYh9zYZToZwn/LXxq3Ebsikh ruTTRe+gHMa66M0JIfgtveigaOJO8VGRCPxVYnhe0hx7nCTwBvpqFa1/I6biDqN+ XyjxyaSXff98R0Euedxae8rfBdbTGTCA/9xp3fMVd/UzTkb109Yqv9e9q9fETTlV SnRG6idJEvU/Xp+JyjDgQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudeigdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfggtggusehgtderredttddvnecu hfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqhhuih gvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvddtffetgedthfeugfevvddtjefguefg gefgjefgvdehgfefveeikedtleekhffgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 2 Nov 2022 01:29:54 -0400 (EDT) Date: Wed, 2 Nov 2022 14:29:50 +0900 From: Michael Paquier To: Postgres hackers Subject: Incorrect include file order in guc-file.l Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GTVxrTdY5bJIgEQk" Content-Disposition: inline List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --GTVxrTdY5bJIgEQk Content-Type: multipart/mixed; boundary="FX7ewgaIToU+gE+Q" Content-Disposition: inline --FX7ewgaIToU+gE+Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi all, While reviewing a different patch, I have noticed that guc-file.l includes sys/stat.h in the middle of the PG internal headers. The usual practice is to have first postgres[_fe].h, followed by the system headers and finally the internal headers. That's a nit, but all the other files do that. {be,fe}-secure-openssl.c include some exceptions though, as documented there. Thoughts? -- Michael --FX7ewgaIToU+gE+Q Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="gucfile-include.patch" Content-Transfer-Encoding: quoted-printable diff --git a/src/backend/utils/misc/guc-file.l b/src/backend/utils/misc/guc= -file.l index 2436396306..caa9c902b9 100644 --- a/src/backend/utils/misc/guc-file.l +++ b/src/backend/utils/misc/guc-file.l @@ -10,6 +10,7 @@ #include "postgres.h" =20 #include +#include #include =20 #include "common/file_utils.h" @@ -17,7 +18,6 @@ #include "mb/pg_wchar.h" #include "miscadmin.h" #include "storage/fd.h" -#include #include "utils/memutils.h" } =20 --FX7ewgaIToU+gE+Q-- --GTVxrTdY5bJIgEQk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNiAE4ACgkQnvQgOdby QH1lWA//XB4CwNS+ox0fDfv/ykAZeLKcIpwqf4dHWqUuEq+kO9B8sR+RayO676PD 0b1JffPUxj5Slt2Z87NDr6CgTmzXZqoYLrJMhhn91PYZQWNs/7qEDRffq+VGBa2E mbM6vZI92pe30HuICZgVzBf8Aa/RBic9mkRk6yrk3PzP5YUouz9DDNm2sl7Rkte0 2r5Ec82crmWvMfaMAHl1Q3L783OdW2YYsJ6xFy9jATHEJT4wTxRIEGzCY5IzpssQ 06IagTnrsu9oaXdf/BKlfa67WyLGy5jeUrWO9l1IV94Ck9Dju/rk1fMSeHWlgWRT n49vU0V8IX/Psnki1TAJGH1PwyhOOGflO5qgkypLFW8uQp91ndaeTZyGhlwB6mSL SRP3YAHeCWSn0R/TkCox9Vv50MO56NyKLYLj01SiPW6Emd56KCjXKeEwgHOn+E8s fMct9rzQv0cfBQyji3qBTAaG21ehHtBZzBiD6C9NuBDYEM2AgTLzEHDy0liLiPX5 gv3D1kx9UyygN8e4GqbU3PRc0C/o67moXlMLGIZtxmrZDH0p5bdEQWn+lA2SGU11 StzOqXKGab2Iv9FPbWpifRundraBQXr083EWveJlfeXFbVANkXhxD0yjTKtLAs6v rCHBkaOwljNx8gHtl8tkE9jk2Kfe1WTN5PKalnOiiyKw1pLUgwM= =JLtO -----END PGP SIGNATURE----- --GTVxrTdY5bJIgEQk--