Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 7 Nov 2022 15:58:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Niyas Sait <niyas.sait@linaro.org>,
	Ian Lawrence Barwick <barwick@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
Message-ID: <Y2ishWF0ZkD2JIpv@paquier.xyz>
References: <Yw6oBJgXWnJsy3SE@paquier.xyz>
 <3886822.1661905738@sss.pgh.pa.us>
 <Yw77DNnYl1qkaW1S@paquier.xyz>
 <20476.1661967233@sss.pgh.pa.us>
 <Yw/9pgS35urJZu/7@paquier.xyz>
 <271611.1661998926@sss.pgh.pa.us>
 <YxA4F7EB3SBenvva@paquier.xyz>
 <CAB8KJ=jEZZa=2sgtpjq4raTaqh3vxx5GFFKWF=OZFHo6vp0cGg@mail.gmail.com>
 <CAFPTBD8CCT9BNdQQ0QELoo7HPqx26_Zkn0jxg9F9u+bPz-jnEg@mail.gmail.com>
 <20221105183136.hfxyl5dclxdcoyih@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="LNgYVPoNpa4/IgAT"
Content-Disposition: inline
In-Reply-To: <20221105183136.hfxyl5dclxdcoyih@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/Y2ishWF0ZkD2JIpv%40paquier.xyz>
Precedence: bulk


--LNgYVPoNpa4/IgAT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 05, 2022 at 11:31:36AM -0700, Andres Freund wrote:
> On 2022-11-03 11:06:46 +0000, Niyas Sait wrote:
> Note that we're planning to remove the custom windows build scripts befor=
e the
> next release, relying on the meson build instead.

Youpi.

>>  #if defined(_WIN64)
>>  static __forceinline void
>>  spin_delay(void)
>>  {
>> +#ifdef _M_ARM64
>> +	/*
>> +	 * arm64 way of hinting processor for spin loops optimisations
>> +	 * ref: https://community.arm.com/support-forums/f/infrastructure-solu=
tions-forum/48654/ssetoneon-faq
>> +	*/
>> +	__isb(_ARM64_BARRIER_SY);
>> +#else
>>  	_mm_pause();
>> +#endif
>>  }
>>  #else
>>  static __forceinline void
>=20
> I think we should just apply this, there seems very little risk of making
> anything worse, given the gating to _WIN64 && _M_ARM64.

Seems so.  Hmm, where does _ARM64_BARRIER_SY come from?  Perhaps it
would be better to have a comment referring to it from a different
place than the forums of arm, like some actual docs?

> The meson checking logic is used both for msvc and other compilers, so th=
is
> will need to work with both.

The patch has been switched as waiting on author for now.
--
Michael

--LNgYVPoNpa4/IgAT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNorIQACgkQnvQgOdby
QH1qbBAAqP+HE4JCZQsGac2A63AjlhS5k5/fcPk4YE0IZyqSrBaT8ylmRdc7MnqG
ktmEida87di86fMaOpJB6fHLVGBPtk1/Dx8MfUjIFC5ygiSayXNw48LwlphePHta
8X4TimeWZ0pSQd9AnfaU7JmiTond2DC6N2a/jmSpOf2d5jSpISvYI6xO8tfc64gg
iTLIt7A8yj/eLT+gcX/c8GTC2VItVO2JRdVivnR1tNjTYEJfQL0uivclhUnXYWPG
B/f7+7eav5mkUw240TIX468DeKmlXhRJdI8JC3cXUu3zaL2RG4MY19t6PE5hH4Of
tHz2p30MQl5IFLXqsoZ9OfYt1MXy8+zm495EmCwaAMZTJ9r+zKlXsXXewOmOiAFQ
lNwwi2aRVm45gUi7g5g/jbha1eNHjdY+7m/kaORXGLJcIUVSzuCv1HMoBGrxatRe
tgL1TdRNuhLmoWSVC/qrPBnN8FvuLy0/u/4ybBv1b+fJA4AJXDik600d6U+zllTZ
RgLKa2PgbqpDUA1JfTrdZbEa0E+PH77V1tg3Dogvd6nPWeySiXzAy9ctyDDbz8Un
KY8RD/RVNDnYNFbnfM75qYS05lA6JxEokEodP5lkHu+cJE5FeZU9ukJs5ziJSLgR
oZwUwvCx+ewF5V1d5mAOrYMeE6w2iezRe0qnrfbSSRfwyZXOzws=
=KJFz
-----END PGP SIGNATURE-----

--LNgYVPoNpa4/IgAT--