Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osFwB-0007hg-F6 for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Nov 2022 04:10:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1osFwA-00085j-9z for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Nov 2022 04:10:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osFwA-00085a-0G for pgsql-hackers@lists.postgresql.org; Tue, 08 Nov 2022 04:10:10 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osFw7-0003px-Vy for pgsql-hackers@lists.postgresql.org; Tue, 08 Nov 2022 04:10:09 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B71B232003C0; Mon, 7 Nov 2022 23:10:05 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 07 Nov 2022 23:10:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1667880605; x=1667967005; bh=yKAmwp6wnm 1Bso7PYYCzoV3uUypHL3NSFKEt1j/5Y0I=; b=ucRHbMspDb4m+rVFXR3BCi16HU F7jfuQ5o0Ni4HT1zy+e4OI0fRrjC7YqonEX+69T/v9T1iYkUKEPOwiFHkYQN2SB+ HuPjhOKsL/aJaST/YtK8HXqbr7QbXgNiETCLWeus/BdGreeTEdY9wAsDQ1Ru9Pwl rj6VOMQ38oN13MrV8TdSa4hHoDfSnMgYlB1tSlMuaSp1XXUtFekGgjcZICPZUMN6 QZOImAk4dfugDl4IzJ2ii+2Z2PaMrwGakDPvHrSO10l0QLnP9dRB6DBLQty0ysrs +fGpJsg6jnveX9oEAbAhzhm3iV/X/tEl/qjFQJXXZw39ho2yskiTFppp/iMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1667880605; x=1667967005; bh=yKAmwp6wnm1Bso7PYYCzoV3uUypH L3NSFKEt1j/5Y0I=; b=JD0k3MQ2kFbezUMboeLFsiFHRmlFH6IfS7U6UfU6fQFP ZY8Seu4jncz2rzBCl5iQDTr0IGx9Bc63GkANGlWfrHa24Wb5DIcCWGTJ7VSdYdiw eqWuKrj0W16FaWmlGX3u9CS8Mvv5frzzi+fJ67Gff1kaUwj15mnE4/YyDUnv4M0m igOiyK5EEz5vpz22PASUxtcLL0+bKtVK0R4mHP38k/jCKJ95Fto8Z9RzOeDKpAvt QOgjns753rXci3E8fomG9QWsUaaNq7jRczw+64Bq0oo8GTWfbrcH5HHBU/WNVHKJ Dx6EE/VNvDIdvRJmRHzJQkYrCPuDkDddfvs4WnMogQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrvdelgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Nov 2022 23:10:02 -0500 (EST) Date: Tue, 8 Nov 2022 13:09:59 +0900 From: Michael Paquier To: Dave Page Cc: Robert Treat , Andres Freund , Matthias van de Meent , PostgreSQL Developers , Vik Fearing Subject: Re: Tracking last scan time Message-ID: References: <20221012195031.bqp4rkvua2kkh46k@awork3.anarazel.de> <20221012225236.r4tdvprilkhdwhdu@awork3.anarazel.de> <20221014181638.p4tzyx5fp62cwjx2@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9naHqG3AXYjw1UMt" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --9naHqG3AXYjw1UMt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 07, 2022 at 04:54:07PM +0900, Michael Paquier wrote: > FWIW, all the other areas of pgstatfuncs.c manipulate timestamptz > fields with a style like the attached. That's a nit, still per the > role of consistency with the surroundings.. >=20 > Anyway, it seems to me that a regression test is in order before a > scan happens just after the relation creation, and the same problem > shows up with last_idx_scan. Hearing nothing, done this way as of d7744d5. Thanks for the report, Robert. And thanks for the patch, Dave. -- Michael --9naHqG3AXYjw1UMt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmNp1pcACgkQnvQgOdby QH2GPBAAmLJd6p2LtSSjTdZiiw4x6ntqFaT9Xcgw4NJFXd86lFNUQFHD6VBOBhXL s5ExcWCwnLD82IAFGGqpBTgFMFOrYyL/KUfGHOh/eYmgZRU8f1x98orSh38gwWWU SsyU/2FloioVU/Kznwe0EZZE7PQzuK1ZNAo2yC2R+CuDnzhsyQwoh+NbDENz1yij 68zyftMlWa9RfiotCjhYOPh3dC2D/3/bw3/XvoSd2HDph62Igi7ImkVQHLbeJWml j+GBUMmh57U6jGs8UT+EfGuXUcnRG3gCFvRuc0rOE1t5JUim2propxjM57DCVfq4 fi31daZ0vCVE5ldyn9hYTOfvviLC4quNZ+VTNCAWyPuunbecuGo1er+UYClWS5BX vuslASG7T8yqj1RF9Q/7f0JDs3Kn4JsqgFO2QxLkqglfVDRCD0qkrjvfFQ97nb72 Dckgku7xvMJeMM9EVfA7e07ejjxipoqKlavZ6RutxfE2DdM/juHj5QsVXX9Dozk1 icuICFvhXj9xEBjAFNo6i6Y1Aq3Spd5Oton8byfTJbXB5+BjtD8+XCwYGNqDdhPg S1IHPlkiXCZia8OoYXtUQhZiEMQPplTMtMwMdutb444vvgjkUONSbn9dCODEUQhX zFj/A2PpyDoqFsCONYkrGdqUrShEli1VeE66PP+rftKxr9PoH1s= =RyyF -----END PGP SIGNATURE----- --9naHqG3AXYjw1UMt--