public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Matheus Alcantara <[email protected]>
Cc: vignesh C <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: mprove tab completion for ALTER EXTENSION ADD/DROP
Date: Mon, 5 Dec 2022 10:23:09 +0900
Message-ID: <Y41H/[email protected]> (raw)
In-Reply-To: <GaJE0VEMyKS42oPVKkRIwUHOG3VUfJCP_0Qb3ZcnetGLbTXmcgMqioYUL2H_3mIgIpZgRqBq1MTHY-WohgYqxDeD7D8Q8lWXTrfh1bcJHI0=@pm.me>
References: <CALDaNm3LVM2QcUWqgOonKZH80TveT-tUthbw4ZhuE_6pD3yi-A@mail.gmail.com>
<GaJE0VEMyKS42oPVKkRIwUHOG3VUfJCP_0Qb3ZcnetGLbTXmcgMqioYUL2H_3mIgIpZgRqBq1MTHY-WohgYqxDeD7D8Q8lWXTrfh1bcJHI0=@pm.me>
On Sat, Dec 03, 2022 at 05:34:57PM +0000, Matheus Alcantara wrote:
> I've tested your patched on current master and seems to be working properly.
>
> I'm starting reviewing some patches here, let's see what more experience hackers
> has to say about this, but as far I can tell is that is working as expected.
+ /* ALTER EXTENSION <name> ADD|DROP */
+ else if (Matches("ALTER", "EXTENSION", MatchAny, "ADD|DROP"))
+ COMPLETE_WITH("ACCESS METHOD", "AGGREGATE", "CAST", "COLLATION",
+ "CONVERSION", "DOMAIN", "EVENT TRIGGER", "FOREIGN",
+ "FUNCTION", "MATERIALIZED VIEW", "OPERATOR",
+ "PROCEDURAL LANGUAGE", "PROCEDURE", "LANGUAGE",
+ "ROUTINE", "SCHEMA", "SEQUENCE", "SERVER", "TABLE",
+ "TEXT SEARCH", "TRANSFORM FOR", "TYPE", "VIEW");
+
+ /* ALTER EXTENSION <name> ADD|DROP FOREIGN*/
+ else if (Matches("ALTER", "EXTENSION", MatchAny, "ADD|DROP", "FOREIGN"))
+ COMPLETE_WITH("DATA WRAPPER", "TABLE");
The DROP could be matched with the objects that are actually part of
the so-said extension?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../Y41H%[email protected]/2-signature.asc)
download
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: mprove tab completion for ALTER EXTENSION ADD/DROP
In-Reply-To: <Y41H/[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox