Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 29 Nov 2022 16:08:27 +0900
From: Michael Paquier <michael@paquier.xyz>
To: gkokolatos@pm.me
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	pgsql-hackers@lists.postgresql.org,
	Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Message-ID: <Y4Wv658+ljAajTuS@paquier.xyz>
References: 
 <165970942594.29780.15623018354659505573.pgcf@coridan.postgresql.org>
 <-pU80vtiyXMfSSpn4SWOR97t71MVmDOyHaJtvGsdEfroFsFUDdc-UaqD-8LMPMw2sy-7B2_IVnlrATfVvXwtv8n3kexLePZ7iWgiOnE4jRI=@pm.me>
 <20221120172611.GQ11463@telsasoft.com>
 <Y3q0jEb6QUnvfw0d@paquier.xyz>
 <dWoK9v8RxFX0rEqRXwHPIAZ1JqOjgUJKJEQYKgXo180_Q1YJBN5GDUMYJyfYv_C8Vgs23ddTW0I2htMj2CFBPM1Rd-DFgyXXsNE5kwmyk3Q=@pm.me>
 <Y3ypKVCOo1VYP9nz@paquier.xyz>
 <O4mutIrCES8ZhlXJiMvzsivT7ztAMja2lkdL1LJx6O5f22I2W8PBIeLKz7mDLwxHoibcnRAYJXm1pH4tyUNC4a8eDzLn22a6Pb1S74Niexg=@pm.me>
 <Y4WkZUGkic9jWb5I@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="DMGbo5+jLnUE2Ion"
Content-Disposition: inline
In-Reply-To: <Y4WkZUGkic9jWb5I@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/Y4Wv658%2BljAajTuS%40paquier.xyz>
Precedence: bulk


--DMGbo5+jLnUE2Ion
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Nov 29, 2022 at 03:19:17PM +0900, Michael Paquier wrote:
> Attached is an alternative that does not sacrifice the pluggability of
> the existing routines while allowing 0003~ to still use them (I don't
> really want to move around the checks on the supported build options
> now in parse_compress_specification(), that was hard enough to settle
> on this location).  On top of that, pg_basebackup is able to cope with
> the case of --compress=0 already, enforcing "none" (BaseBackup could
> be simplified a bit more before StartLogStreamer).  This refactoring
> shaves a little bit of code.

One thing that I forgot to mention is that this refactoring would
treat things like server-N, client-N as valid grammars (in this case N
takes precedence over an optional detail string), implying that N = 0
is "none" and N > 0 is gzip, so that makes for an extra grammar flavor
without impacting the existing ones.  I am not sure that it is worth
documenting, still worth mentioning.
--
Michael

--DMGbo5+jLnUE2Ion
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmOFr+sACgkQnvQgOdby
QH23Kg//fL7aK/iQvL0u4vovzE8KcSB03hOWwDz1OIbcMUa/tp6umb0/KzQ7WLqA
OSTw5jGzfktgq3YR+2hg5HB9Sz2xNSzSx6Vp3MhwDPTAdBBYC0v+1E7dTpv+Jc0L
1shztytEgkgCzJxNnDYac+faPUjraUI279JUbfn5+VqLuD2HdH9BhL3hbNCFHEHp
G90kDM37SwuDJTpb4PAgmZ7qvfmpu5LKQQSc6Tn9grCzH9RepbUqDN5vEnkmnsjR
UaEGtFxhHcmY9IwjBl/9k8Ck3u2C1+L7sbDnkz/AkvJ/4e947jrPZSrqmymTPFHJ
1FRXOz0bYFHbjwEFPDkkximxeSyRd/qAFfeSG/Y/0325RwHA9lC3LtjY1bIz3gkE
OK+rKIEjl+OmKAPjQ6ZRvtBX6GL0BSlyON1Hhrf45hQJAJ02NiEfR8vDVZ+3PyJO
+BsBFgNJeNHs+WrkCXoF/Ow1Y2PiLTnM00lvcptd4BdxpJoaIwt6j4SQa5AmK7YX
e0LGRVRp4kSdvuCkA0H4/QzWMRTUrQl/Jq0b6lXrh9mcpiNDaYDfkgIdIplnCAZq
1fCFZ1WUruV138h5iAA0LuweYO0ZmYieupW2a/JmaUACzRgjoSkt7rUWVVqRELb7
MSO2HK0DgHuvNLYrGRwLAaziwz7x24LjH5kR/IkVMGzU5GK7HQY=
=N1V1
-----END PGP SIGNATURE-----

--DMGbo5+jLnUE2Ion--