Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 2 Dec 2022 14:02:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Niyas Sait <niyas.sait@linaro.org>
Cc: Andres Freund <andres@anarazel.de>,
	Ian Lawrence Barwick <barwick@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
Message-ID: <Y4mG/vD9YjPDZaYw@paquier.xyz>
References: <20476.1661967233@sss.pgh.pa.us>
 <Yw/9pgS35urJZu/7@paquier.xyz>
 <271611.1661998926@sss.pgh.pa.us>
 <YxA4F7EB3SBenvva@paquier.xyz>
 <CAB8KJ=jEZZa=2sgtpjq4raTaqh3vxx5GFFKWF=OZFHo6vp0cGg@mail.gmail.com>
 <CAFPTBD8CCT9BNdQQ0QELoo7HPqx26_Zkn0jxg9F9u+bPz-jnEg@mail.gmail.com>
 <20221105183136.hfxyl5dclxdcoyih@awork3.anarazel.de>
 <Y2ishWF0ZkD2JIpv@paquier.xyz>
 <7ff7c416-fdfe-517f-a65c-9e5bd8ff8cec@linaro.org>
 <f40835e6-db1e-3f51-001a-8b911245665d@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="lmskEyLRdpPKFBo1"
Content-Disposition: inline
In-Reply-To: <f40835e6-db1e-3f51-001a-8b911245665d@linaro.org>
Archived-At: 
 <https://www.postgresql.org/message-id/Y4mG/vD9YjPDZaYw%40paquier.xyz>
Precedence: bulk


--lmskEyLRdpPKFBo1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 01, 2022 at 05:53:47PM +0000, Niyas Sait wrote:
> I've attached a new revision of the patch (v4) and includes following
> changes,
>=20
> 1. Add support for meson build system
> 2. Extend MSVC scripts to handle ARM64 platform.
> 3. Add arm64 definition of spin_delay function.
> 4. Exclude arm_acle.h import with MSVC compiler.
>=20
> V3->V4: Add support for meson build system
> V2->V3: Removed ASLR enablement and rebased on master.
> V1->V2: Rebased on top of master

Thanks for the updated version.  I have been looking at it closely and
it looks like it should be able to do the job (no arm64 machine for
Windows here, sigh).

I have one tiny comment about this part:

-       USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK =3D> undef,
+       USE_ARMV8_CRC32C_WITH_RUNTIME_CHECK =3D> 1,

Shouldn't we only enable this flag when we are under aarch64?
Similarly, I don't think that it is a good idea to switch on
USE_SSE42_CRC32C_WITH_RUNTIME_CHECK all the time.  We should only set
it when building under x86 and x86_64.

I would also add your link [1] in s_lock.h.

[1]: https://learn.microsoft.com/en-us/cpp/intrinsics/arm64-intrinsics#Barr=
ierRestrictions
--
Michael

--lmskEyLRdpPKFBo1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmOJhv4ACgkQnvQgOdby
QH3usw//SUR4Vp7ezC4muQpnNcjyS73p9ZN+m9+OYjgEyn8SIqKjm+/BJtjhAZOP
iZZRv63JfTAoz5bFR8YP9hCpFem9gxbhHpqgFKA4TD5kBfKubhINq46PyfB1+v4u
AwGiPBcxEsguLDmZZjvceSmnO2ZTVCwpvgzJ8kbmAPLHvamG3hb2S3+WPdcuyBBk
G5M6dAEg8oKuwYXrL8f+jnDkhE/LW+0sPEuHLbsmQktqPLilgGN40E7bioOGguN1
MWp5xXa6+aBDh+Eaz5beLHmSp4JMH3WcPBBf9waQ352cmQvYoQD3nJ8wRd/j0AL5
mUGSAOvqEWFqhPNmYNVaKOAVnLh7WHo5JmKsPVRULSrcjbyTpDaeO7mFw2GQ2G6x
3jfJuURVPsHXbWALzJn/Y5MYeUmS1q0BaPr2FEKqA6eajhIDJnb7vfynrYaY8mj3
JidsSKKmBdY4Og7SIzJ+gH9rYGOPen1RQnWEAW8J979sl/L2XcY1vguGjwsvzZPZ
0qz7iM3fhVjlwkW2eqSy17yO0GwF40YW09XT+OBjKK+Hy560YlPvpwunDqfdFbH8
59KwkFO9RUvABxmrEic25zmWSwMppcMWXyLue2HncTd7lZl5MYBpH0u6bGDSIVfO
yjks6ecLW5ZoPVyMOtHM43L80DlFtO7568Adr+S/qH1QQh81Bb8=
=7dXl
-----END PGP SIGNATURE-----

--lmskEyLRdpPKFBo1--