Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 3 Dec 2022 11:45:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: gkokolatos@pm.me
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	pgsql-hackers@lists.postgresql.org,
	Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Message-ID: <Y4q4SihPgXDVCL27@paquier.xyz>
References: 
 <-pU80vtiyXMfSSpn4SWOR97t71MVmDOyHaJtvGsdEfroFsFUDdc-UaqD-8LMPMw2sy-7B2_IVnlrATfVvXwtv8n3kexLePZ7iWgiOnE4jRI=@pm.me>
 <O4mutIrCES8ZhlXJiMvzsivT7ztAMja2lkdL1LJx6O5f22I2W8PBIeLKz7mDLwxHoibcnRAYJXm1pH4tyUNC4a8eDzLn22a6Pb1S74Niexg=@pm.me>
 <Y4WkZUGkic9jWb5I@paquier.xyz>
 <iKYD3Ryqsn88_UgYBiw3V803ISB5BJokmR2zsFtcedNVVeivIn_fqVv-oRRMqOpMiBFXsi72UYNMmuqMnEjjcQluTTpO-oxQWAVPeAlACnA=@pm.me>
 <Y4ao2viUjcO/c2Oc@paquier.xyz>
 <1j_ONBQqU3lQW7OqwbAFKbgcqjQosikcp7VPINqegLrHMCMGtFcXAuyjmW__VeviKyCbKTtucxFyPFUJ7sfqeOf4O90JEuUIe99Z5v7sdOg=@pm.me>
 <Y4gMAkNGIU1ShaoD@paquier.xyz>
 <jBiqIGoBbxyqLL2syvEDLm1W_TPukmBtAOkFyICkAssd8qupR7zjpA066Cj_syxQOVFsQORr3fc-g_WeATSXvdoybB-e7Xj26Y-C8U7rTKA=@pm.me>
 <Y4lbSoDPlVdbes1u@paquier.xyz>
 <T33dciWfZ3WaU10Mspm2_vsftrl0DI_cs4rQcrT_pLubaLq_HCRlW5QhEOT1cWtSRtdeTVXrL2r2BTYz3Fjz_3YNh6i77lwd5AxNxb5oanQ=@pm.me>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="d6KMp92WxG2Ca89Q"
Content-Disposition: inline
In-Reply-To: 
 <T33dciWfZ3WaU10Mspm2_vsftrl0DI_cs4rQcrT_pLubaLq_HCRlW5QhEOT1cWtSRtdeTVXrL2r2BTYz3Fjz_3YNh6i77lwd5AxNxb5oanQ=@pm.me>
Archived-At: 
 <https://www.postgresql.org/message-id/Y4q4SihPgXDVCL27%40paquier.xyz>
Precedence: bulk


--d6KMp92WxG2Ca89Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 02, 2022 at 04:15:10PM +0000, gkokolatos@pm.me wrote:
> You are very correct. However one can glob after the fact. Please find
> 0001 of the attached v14 which attempts to implement it.

+       if ($pgdump_runs{$run}->{glob_pattern})
+       {
+               my $glob_pattern = $pgdump_runs{$run}->{glob_pattern};
+               my @glob_output = glob($glob_pattern);
+               is(scalar(@glob_output) > 0, 1, "glob pattern matched")
+       }

While this is correct in checking that the contents are compressed
under --with-zlib, this also removes the coverage where we make sure
that this command is able to complete under --without-zlib without
compressing any of the table data files.  Hence my point from
upthread: this test had better not use compile_option, but change
glob_pattern depending on if the build uses zlib or not.

In order to check this behavior with defaults_custom_format, perhaps
we could just remove the -Z6 from it or add an extra command for its
default behavior?
--
Michael

--d6KMp92WxG2Ca89Q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmOKuEoACgkQnvQgOdby
QH1Myw/9G9Z3i2CfSA2g5+f11Y9BPhxIGzp5nUK021LPMe85KEysJYXg/wPOvzHm
765G3TppDm0qtZf8Bf5lJOTdWmT3eqFzIPuGxI1M3UKPFhtdw16NlVfHkzHkEiXu
RAamjpRH4cA1WPz9qcbz0khmEDIUG6zxgLQf7nDR6Opdmxglvhvka8tkDPE59wCn
nXe3zIVoecTi1cVxRt+ip7hUBEpMPJDqQQiea3fSoo7yMnc4k8l7IGGT82shzOru
RCmlTRDknXWQawplPOOcF3UGjl+zLeYfHUqZNZQC0BYzcI1mvc0WiTPbHaWBGwUV
OKbCTgyMmooIaZGQ0qUFSHYBElDMKS7amYA4PM9FnhWYDbPAfz1NYENvouse89Nl
K4DkQd4oQC6KThomRPJ8l162WAcMd29MufAELZ2/ySDsKdhf/ljMh2jS3J7uYzpO
ssx36k/SfmNA2DFKOu9U9dsf6td0lv7E6+3VYPNEUyuUIt45/AD4+CsEGjzuVTrB
YBQxjCgkwykfUn4BBNe7EWMQXvK7ilaMQHrfa6XJSKsKTRiuykzArjFlvoTVugS0
de5B3j2/uXZhMjDL3iXebIEiB9vEEfj9wlRtaoadoHeNTqHluHl3xe309zvG/7sp
SyhAHROTWHcicnLhg57UMZSegxX5SY1anQXcnlVi0IkCg9Cbq+E=
=a4Nw
-----END PGP SIGNATURE-----

--d6KMp92WxG2Ca89Q--