Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 9 Dec 2022 13:16:08 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Allow tests to pass in OpenSSL FIPS mode
Message-ID: <Y5K2iK+Q9c5KLnZ2@paquier.xyz>
References: <dbbd927f-ef1f-c9a1-4ec6-c759778ac852@enterprisedb.com>
 <647f6cc1-473d-f788-ade0-c09201e5ab6a@enterprisedb.com>
 <Y0YV+lQNQFRIdvGJ@paquier.xyz>
 <3c36b798-fbb2-9246-fafd-4e4b2f546de8@enterprisedb.com>
 <6885f06b-79a4-8ded-2261-85a7be68ef4c@enterprisedb.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jx9zy5hfGSR2FmvZ"
Content-Disposition: inline
In-Reply-To: <6885f06b-79a4-8ded-2261-85a7be68ef4c@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Y5K2iK%2BQ9c5KLnZ2%40paquier.xyz>
Precedence: bulk


--jx9zy5hfGSR2FmvZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Dec 07, 2022 at 03:14:09PM +0100, Peter Eisentraut wrote:
> Here is the next step.  To contain the scope, I focused on just "make check"
> for now.  This patch removes all incidental calls to md5(), replacing them
> with sha256(), so that they'd pass with or without FIPS mode.  (Two tests
> would need alternative expected files: md5 and password.  I have not
> included those here.)

Yeah, fine by me to do that step-by-step.

> Some tests inspect the actual md5 result strings or build statistics based
> on them.  I have tried to carefully preserve the meaning of the original
> tests, to the extent that they could be inferred, in some cases adjusting
> example values by matching the md5 outputs to the equivalent sha256 outputs.
> Some cases are tricky or mysterious or both and could use another look.

incremental_sort mostly relies on the plan generated, so the change
should be rather straight-forward I guess, though there may be a side
effect depending on costing.  Hmm, it does not look like stats_ext
would be an issue as it checks the stats correlation of the attributes
for mcv_lists_arrays.

largeobject_1.out has been forgotten in the set requiring a refresh.
--
Michael

--jx9zy5hfGSR2FmvZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmOStogACgkQnvQgOdby
QH0LCQ//dAqAkb7vtdeB7aSyO+e19mfg+YhSKV/3i5/ZppI29fOMFDLRsH8N8mmA
j0X/p5V0DvP0fTjPHF/AjfnJFZ9rQAeENQwBHk5LDHSl81BwyLg5/3yM8GJxvUeb
5yHZEqmH0LxOxP+dr2T7Yo48ZSCmdAlJJnytYBHIY08e4IjDqeGuZZSbWn6O5Fje
A+azkLMHhmBFMQsx0VoVuiQZIDsx2g8XpXPAmHmo5aP46jNSRYW6Ot2r/Rmu7TaX
Xnp+Cu8oumZQnNR57OqHpQ2F0DrK6dXdL+IGzAMYpEUA/RTVFXp59OjYkRRR4jGn
d+t7vtPOyaGJ1zeH4Fg2YVN5PlOmCnuRTS4h5/mx6ECnTd2Il3aOOH/+uFTv6eGv
cnG3OTgO2TDpuxCsOrhjViwv7rRSCJWMhIKOH6Xvyl/y1w7YKXFWfUHT+3jPzg9g
BvalcbQ8JlDr45xCix8N1GdFKVAx8z7mW0aOtZWKq2Dp6/PeJS56Pjy9asznAUPG
3Uf9I5AvxY6U6ijgzqtYCc2CbXd4hHVPVsLS3sPl/oulo+9PCrig5tBQ7wnQb1qJ
3hf3DOx/qqpQcQsAralvIDrlnfNxEsYdqUwRobziQ491DZI6ZbCu4s7o+xcakr9K
waweY9b9woS7BKwdN8neDWQtdMXykUqnqsHJeTJ12XA3lt2aq/M=
=4Ril
-----END PGP SIGNATURE-----

--jx9zy5hfGSR2FmvZ--