Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 13 Dec 2022 08:56:33 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Niyas Sait <niyas.sait@linaro.org>
Cc: Andres Freund <andres@anarazel.de>,
	Ian Lawrence Barwick <barwick@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Add native windows on arm64 support
Message-ID: <Y5e/sWhwW+sMgVVh@paquier.xyz>
References: 
 <CAB8KJ=jEZZa=2sgtpjq4raTaqh3vxx5GFFKWF=OZFHo6vp0cGg@mail.gmail.com>
 <CAFPTBD8CCT9BNdQQ0QELoo7HPqx26_Zkn0jxg9F9u+bPz-jnEg@mail.gmail.com>
 <20221105183136.hfxyl5dclxdcoyih@awork3.anarazel.de>
 <Y2ishWF0ZkD2JIpv@paquier.xyz>
 <7ff7c416-fdfe-517f-a65c-9e5bd8ff8cec@linaro.org>
 <f40835e6-db1e-3f51-001a-8b911245665d@linaro.org>
 <8d46c46d-66d3-758b-b686-de371e0ba8ca@linaro.org>
 <Y419yaW1Q1uoXbtY@paquier.xyz>
 <20221205181449.47mhosidtmotemdl@awork3.anarazel.de>
 <6cfaaf3c-7fb5-51c8-92cf-ceac6303ef66@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+zpUR8BFP3V02/4V"
Content-Disposition: inline
In-Reply-To: <6cfaaf3c-7fb5-51c8-92cf-ceac6303ef66@linaro.org>
Archived-At: 
 <https://www.postgresql.org/message-id/Y5e/sWhwW%2BsMgVVh%40paquier.xyz>
Precedence: bulk


--+zpUR8BFP3V02/4V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 12, 2022 at 01:38:37PM +0000, Niyas Sait wrote:
> On 05/12/2022 18:14, Andres Freund wrote:
> I think the old build system specific part is really minimal in the patch=
=2E I
> can strip out those if that's preferred.

Removing all the changes from src/tools/msvc/ is an approach that
works for me.

>> Why does this need to be hardcoded? The compiler probe should just work =
for
>> msvc.
>=20
> There are couple of minor issues in the code probe with MSVC such as
> arm_acle.h needs to be removed and requires an explicit import of intrin.=
h.
> But even with those fixes, USE_ARMV8_CRC32C would be set and no runtime C=
RC
> extension check will be performed. Since CRC extension is optional in ARM=
v8,
> It would be better to use the CRC variant with runtime check. So I end up
> following the x64 variant and hardcoded the flags in case of ARM64 and MS=
VC.

Hm..  Andres, do you have access to Windows hosts with ARM64
underneath to validate any of that?  No way to blame Cirrus for not
having this option, they already do a lot :)
--
Michael

--+zpUR8BFP3V02/4V
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmOXv7EACgkQnvQgOdby
QH1OMQ/9FTmbmR3uvKw4n3WQ51aCSAelU2i/uz9iCXwtM365SMYY4qrqGimJzakZ
BtLK61yiFqrdBz3zfBAoH3S5+lJYq3cxXLb5v5+skdkxT/b+h1W7GGWuIfB4wk7Q
q0JXH/zs6ZfYoI/xNE6gigIoLpMWMutXlf8jB//Bqsc0pQpyzMXjVPMgpwV0K44T
iBDA5k6n6s2L3kkpCS9agU+dQnziAHTmfob7qnk1PSgR1AXsQ/ydV7zuVw5Nfx7E
z1cBe5NJLepvkzY0fQBFSDcvaZNW+99XyQF2KHxKe4+h2Z8CWdSo6AaF7Z13bCBW
zZkZrWM7E8jWM/Q6LYcOcX5NGQ7YAIASC/feUik2TFYpE+ilTNQFWr1nrc2GBGYN
L6I2OUdjox+JmeiNVcPQ8yNGFqXvQ4onETe/wJvF/ynEYwau+Cb7L8lPbhbQCCAM
sSWS6HTP5fl3ljaZH5ORiyp0tIWJ4XvODtHuVBodM+n4yKrjsIqy6d6igmdY23VI
ytbu4zMY26BrXF5RjhjVo8RbA3yyEYLFOpcKGULH/fFtGZtSty0uv8TupTptaXW0
FvOM/HjJdCD475MVfZw9rtr/VZfu9I5FfBpJpTYlvelP2FYje6xqD3dQxwttQVmy
jSD9tOP9OBBcln5aEKn+dkvfsoHqec1+AO9DanZ2kN5cZvjr4pg=
=4Dpi
-----END PGP SIGNATURE-----

--+zpUR8BFP3V02/4V--