Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pA0gu-0003ET-ML for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Dec 2022 03:31:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pA0gt-00059x-AC for pgsql-hackers@arkaria.postgresql.org; Tue, 27 Dec 2022 03:31:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pA0gr-00059n-Jx for pgsql-hackers@lists.postgresql.org; Tue, 27 Dec 2022 03:31:46 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pA0gh-0001Ci-Oc for pgsql-hackers@postgresql.org; Tue, 27 Dec 2022 03:31:44 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8FE0B5C013C; Mon, 26 Dec 2022 22:31:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 26 Dec 2022 22:31:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1672111894; x=1672198294; bh=Z7ZK9cSMY9 do7P0SWGRhx+9apZ0pdtWzcudmKYTr754=; b=YfQmyTibmsBdOnvMnt6HlI+Yu3 9a1HmL+9j8hoeWhTGy6I/1vFIrADoaFVaY8hhiLwjeVUUiSF4CYLNVUDIZRQHrEN VH+Hl6x63KthYtMdOlkKdqDqsGwvVXo8fJRjE08gKwcsjHhhmU6TGWcKJp3axGs5 yWi6CxfEEmoDzzbHt6x7tzbyFbJvWGau37ssOaJZtvh+wT9BpLmlQNUMF+O3w8WR 5mvP9R8JDRYcVis+iLLgaxkj7ZGh4XpfCgMVyHmE8qocydx5gGprvupAu1l5ZcWZ VeMPYUzfLtA1l45VyAdtY38p0o7lj/KVmSoV53Yik1mSqioWWTwmtOlugQ/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1672111894; x=1672198294; bh=Z7ZK9cSMY9do7P0SWGRhx+9apZ0p dtWzcudmKYTr754=; b=SVbX19TJgYE+9vnIQK/Wzgi3fjpnCeI4EHcLPDaKz89j wPyStBMfrAizJxzbJ0y4STRr49pvt1s9PXj/J8NeKmGkF8+CJjU72UF0o5KnAfO0 D+zG0THjXiiEkN7ivLKFInNC+ifq2dAi1MvwYrsNxKqDEeTozj7qSvUoFqWWPT22 w1JbaydNL10j7Qqz0ZRljsx4XApcDWjsW2FTjH/80XedljUA8GS0spunqojmUDsQ CUS6CIPPcuLuqMRL1MamsqkoPM5pp+ZZICpAeB6zlCgwYsm8SlYmBAXfME2i8+xs Z8vHmAilClTfjD/N4Wl1h17NSsFj/JrkAdKwuEkblQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrheelgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetleeifedufffhhfdtteelgeeg geffhfekueevteeigfduudevudetgfegiedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Dec 2022 22:31:31 -0500 (EST) Date: Tue, 27 Dec 2022 12:31:27 +0900 From: Michael Paquier To: Bharath Rupireddy Cc: David Christensen , Justin Pryzby , Ian Lawrence Barwick , Matthias van de Meent , pgsql-hackers@postgresql.org Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hu+57fq1OgThWV9g" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --hu+57fq1OgThWV9g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 26, 2022 at 04:18:18PM +0530, Bharath Rupireddy wrote: > +1. I think this feature will also be useful in pg_walinspect. > However, I'm a bit concerned that it can flood the running database > disk - if someone generates a lot of FPI files. pg_read_file() and pg_waldump can be fed absolute paths outside the data folder. So, well, just don't do that then :) -- Michael --hu+57fq1OgThWV9g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmOqZw8ACgkQnvQgOdby QH1Ylw//SYD2+pN+vJVFCRn8B3p5oVPINGLoaTyq8BwPwbPAbqzy1wEjXD0ItGjy kCqJCSFotEE9EGAqjEkWDP8+oWK9AEzzhpEEYQDggUn4qldAH/ucrMIbpJxmBgGe DmbR597PnAwOLY4Zi5OnHgEfWndar9hmPgh5cvhyVbhnpffX/dzHjC5PQo3Bzrod hcA/5v6dz5q8XsQsceA81pcu/f1/ONEOypBJml+mneaqO+FZWYdFsuusuvJIR0Ii fSl8T/xvFWnoZuW2YdsAFILt71cDDzZqoowQRNwT5PhNnGo24w/s6Zw08eRd1q/Z 7LYtMo8rkFYbFZARyFFKBvsR8hCy2N9B2qNCI1HiA03if51BCkbsw688JxbQDAQ6 6VT+/rk1fJWG1KshBzTa98P/1jarzjqDqjpX53Xo+GnDixVisIgRcc5UP4G0dRFB RDw7ZRt+2GbAe4FfUp2Fr6guS8tt9zSVKVoABMb98kU8O7umlMWqMt6Q/OMtHZPK BWPXpoeMOqEuz6J9hfW/zwivhVpBGgAMGGmtLLL0NuYUjoPHaprYA6YZqLNSqMup msfja2vZ1IldElFdxikPexjrexsZTr11sH77wHXSQ/MNc/lIQVfQnDcUjY9HrHLc 67Lu8/ld6xnjYdTXfJoB51GjEBX7AIS+htmp6vubmgYAPv+oL0k= =rn3R -----END PGP SIGNATURE----- --hu+57fq1OgThWV9g--