Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 11 Jan 2023 15:49:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: vignesh21@gmail.com, mths.dev@pm.me, pgsql-hackers@lists.postgresql.org
Subject: Re: mprove tab completion for ALTER EXTENSION ADD/DROP
Message-ID: <Y75cCLswLiFULAy1@paquier.xyz>
References: <GaJE0VEMyKS42oPVKkRIwUHOG3VUfJCP_0Qb3ZcnetGLbTXmcgMqioYUL2H_3mIgIpZgRqBq1MTHY-WohgYqxDeD7D8Q8lWXTrfh1bcJHI0=@pm.me>
 <Y41H/RJ1jDBUrtns@paquier.xyz>
 <CALDaNm3s0MHr1iw716JsacmA4yyCFn4tCw1=3c6Sm2xjvBVYDA@mail.gmail.com>
 <20230111.121033.1472938035248120882.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="fVs67lWxB+m4BC9f"
Content-Disposition: inline
In-Reply-To: <20230111.121033.1472938035248120882.horikyota.ntt@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Y75cCLswLiFULAy1%40paquier.xyz>
Precedence: bulk


--fVs67lWxB+m4BC9f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 11, 2023 at 12:10:33PM +0900, Kyotaro Horiguchi wrote:
> It suggests the *kinds* of objects that are part of the extension, but
> lists the objects of that kind regardless of dependency.  I read
> Michael suggested (and I agree) to restrict the objects (not kinds) to
> actually be a part of the extension. (And not for object kinds.)

Yeah, that's what I meant.  Now, if Vignesh does not want to extend
that, that's fine for me as well at the end on second thought, as this=20
involves much more code for each DROP path depending on the object
type involved.

Adding the object names after DROP/ADD is useful on its own, and we
already have some completion once the object type is specified, so
simpler is perhaps just better here.
--
Michael

--fVs67lWxB+m4BC9f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmO+XAgACgkQnvQgOdby
QH1BIQ//WXS9LBBYHudDJrpbze1vsFkbGx4OASqX5ma94V0on7eBWJXDdum6zZH6
+hrQ5ZIVosDc+RbSFKADRoV5l5CI9H7EBIiapVm17CYyCQjIHyuL93sv69AJK6Pk
vaTRFpkjPgZmIxLyxcLGGLhhKPeqRIo0QrukK55BD49dZ4Wu3JbOdnbjVisdAPq6
AnSh76G7K6wM9eGtneNrhlMDp/F+8pwbS4DicmUDqNUjQyzFI6I0cXfuTJumiRBo
tfAY1c19dlzDhGEpfDFHjRmMTj63/qg65c98n8tth37I5aMeT9I/+SkIz4/nYt47
QohQVfJ2hAAFlEwgBueQu0w3DcD7opnb0Rohrl/fEnf//yQn7H2iddpkqYeYPI81
PQswF9Q5IfH8Ck6zsyCCjDaCiIVeVJSFGpFN51ZgOYZbsVgQZNNbIaKcDZlsmhHa
Q9NhR+VwtPPGg9HMpTgwcAS3MsnO98NKXxtEM6r1ZINmWC+ro3BikgO8KsKFStjO
HMVkAh6Bs70nUJl8ysP5Tv6fIlv9unBfBnMUTIK1tJttIz86aiS3g8op2zCOSVa6
JkDmh/aCv7Bpl6No2ranMNik4XTs3LJt7MyGuG1x/ZaXEWGPfzL2hdpkeVGgOEOe
JRvFoHkGe+ku/gbTKbzjTcTwrrQ55fbNvhJjFa/nphbTnlen7GQ=
=jBk2
-----END PGP SIGNATURE-----

--fVs67lWxB+m4BC9f--