Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 23 Jan 2023 09:37:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Jelte Fennema <postgres@jeltef.nl>,
	Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>,
	Magnus Hagander <magnus@hagander.net>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Stephen Frost <sfrost@snowman.net>, Noah Misch <noah@leadboat.com>,
	Jesse Zhang <sbjesse@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Message-ID: <Y83WxE6KSnLHP1NF@paquier.xyz>
References: <1097305.1674334785@sss.pgh.pa.us>
 <CAH2-WzkHHcPRMj3G1b_dUfY0aR4W4OAHQ9_Z6sDGvL8Ew+aRrA@mail.gmail.com>
 <20230121224312.qmwpagrebidr6hi7@awork3.anarazel.de>
 <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com>
 <20230122094957.x542ojaqgi4lalq4@awork3.anarazel.de>
 <CAGECzQRYjHdNQ-Bq2yrBb-8s3Pjx7pfvYPDdNv9tcvDcscDhbg@mail.gmail.com>
 <20230122223806.3sgew6qswhsczae7@awork3.anarazel.de>
 <1495023.1674430107@sss.pgh.pa.us>
 <20230123001518.6hxyiczhn4kadvmf@awork3.anarazel.de>
 <1502504.1674433722@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ily1ObT075O0O/yD"
Content-Disposition: inline
In-Reply-To: <1502504.1674433722@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/Y83WxE6KSnLHP1NF%40paquier.xyz>
Precedence: bulk


--ily1ObT075O0O/yD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 22, 2023 at 07:28:42PM -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> I think I've proposed this before, but I still think that as long as we =
rely
>> on pg_bsd_indent, we should have it be part of our source tree and
>> automatically built.  It's no wonder that barely anybody indents their
>> patches, given that it requires building pg_bsd_ident in a separate repo=
 (but
>> referencing our sourc etree), putting the binary in path, etc.
>=20
> Hmm ... right offhand, the only objection I can see is that the
> pg_bsd_indent files use the BSD 4-clause license, which is not ours.
> However, didn't UCB grant a blanket exception years ago that said
> that people could treat that as the 3-clause license?  If we could
> get past the license question, I agree that doing what you suggest
> would be superior to the current situation.

+1.
--
Michael

--ily1ObT075O0O/yD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPN1sQACgkQnvQgOdby
QH1D8Q//cgaAOPWtypXDN/3PPahP1/aFu5bIcjVHm7CZntep7m5UQfSK2CfRRgJZ
DkXXpRcFcvIbXY/Ba+7BDZWE9fKLQuqwr/nBgnAveD5WbYw21JFSNr7w2Phmranm
ZuIhYEX4ag4ZtRCr5DXjXm+feN4t56VVSwj6pp0Mu5ZePGL9Z8zKqHIjoct3CQ/2
kqN02pHTQXnm0kb6jUJ3AhULNXx6MickDdVMyIRJo+F28hQzHkRJ8uyEE3i4RCCY
apqsh4XOFCvtfBXBPjD1UMv36yempfx30SNhWp2X436FrG8LoSEC77FLLCDdTOiY
au2qSqASNLHIcYLSehQJlM8sFvWZPW6lfrj0c/ThWBPPb8I3QiqUAQVCMMAcJSDX
zFEU7cluWiGkIi/Rg/VS+HKGFrA5A+qSoxcUrDEPmjOUk9/ab/oN4E7RYUDdT9MD
s40L6TLibNuwUDb0fmdWKzL/wAfBtRzA1gr4E7t/oQ1NqaIpqUu0HQBagyswgYZn
c+wLmprLCcxVMGjRP4mSIsOIyFj9T2kfvsiIf/cA+GcAe6ZiXaz/Mkgxpfdb5OIA
0rT3Gt0rIXhj10gS5oUC1hKW0Xv1lnV+ND/Nd8hWjtuwGZREv1wG6C909ScDfoYt
fO4wwYj9y8qvn93j3enUFaKIaq2Tgezkk51+LenWPiZFo2Ey63A=
=AiCi
-----END PGP SIGNATURE-----

--ily1ObT075O0O/yD--