Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 18 Jan 2023 17:50:47 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Issue with psql's create_help.pl under perlcritic
Message-ID: <Y8ey5z4Nav62g4/K@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="sTvi3iZnHrATJtTQ"
Content-Disposition: inline
Archived-At: <https://www.postgresql.org/message-id/Y8ey5z4Nav62g4/K%40paquier.xyz>
Precedence: bulk


--sTvi3iZnHrATJtTQ
Content-Type: multipart/mixed; boundary="gUmwBvrLw6kHiZTz"
Content-Disposition: inline


--gUmwBvrLw6kHiZTz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

A recent system update of a Debian SID host has begun to show me this
issue:
./src/bin/psql/create_help.pl: Bareword dir handle opened at line 47,
column 1.  See pages 202,204 of PBP.
([InputOutput::ProhibitBarewordDirHandles] Severity: 5)

This issue gets fixed here as of the attached.
Comments?
--
Michael

--gUmwBvrLw6kHiZTz
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="psql_perlcritic.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/bin/psql/create_help.pl b/src/bin/psql/create_help.pl
index 2c5fed203e..1d5366db16 100644
--- a/src/bin/psql/create_help.pl
+++ b/src/bin/psql/create_help.pl
@@ -44,7 +44,7 @@ my $define =3D $hfilebasename;
 $define =3D~ tr/a-z/A-Z/;
 $define =3D~ s/\W/_/g;
=20
-opendir(DIR, $docdir)
+opendir(my $dh, $docdir)
   or die "$0: could not open documentation source dir '$docdir': $!\n";
 open(my $hfile_handle, '>', "$outdir/$hfile")
   or die "$0: could not open output file '$hfile': $!\n";
@@ -103,7 +103,7 @@ my $maxlen =3D 0;
=20
 my %entries;
=20
-foreach my $file (sort readdir DIR)
+foreach my $file (sort readdir $dh)
 {
 	my ($cmdid, @cmdnames, $cmddesc, $cmdsynopsis);
 	$file =3D~ /\.sgml$/ or next;
@@ -230,4 +230,4 @@ print $hfile_handle "
 close $cfile_handle;
 close $hfile_handle;
 close $depfile_handle if ($depfile);
-closedir DIR;
+closedir $dh;

--gUmwBvrLw6kHiZTz--

--sTvi3iZnHrATJtTQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPHsucACgkQnvQgOdby
QH0RWQ/9E95j5ig/C21VOCy0i74rZ6Vt7/pNXeXiqZYakDDl2poI63E6+j0ft/rl
bqrVCJpPIzvjgXlVrcXDqZpWr8B2asYlKSit2RHl7MUqB5ayFHWJ/m8csHp/DPNw
lKWwRbtkvIAV22ChEQ+cfoaWBtI5MUqhNH1ta+qdmMHScms4DuS5QJzyIOIo5WEe
tx0qiwL/TL/lHlGH69FghrcGNDWhS7b95kOJZM/I8hlaS6rfi/C5D6RENDys5pF/
ghv5CnadJexkULnt2ehgDT2JvT7ny4xBItzvSKrsRO96v/gtayeqdY6Dy0XT0+Pa
E2ombGSnOZEbPqAhY0F7sISOUQrRgEdcCIEmedN2uKoj4DpuRykxafUILZGX8epU
9xVQ7Vo8pslxgst+pvu9JWpwzhN/vusWcIzUvyHHsTHiZlyCZhDXrHV5v5KtYPik
rOqeY7XkHNGRdzB9OfqbtKl+StAY618b4Sk5g0XU/wvVGN7CLzaMqHfn6PhqFdn9
YBzJ8UHPEXB4BbyAd+8p/0DcImEukXWNDu+KI7h6stAkxlDkRNTINleBgyl0GuL7
JTUlw6Q+FulQuHpjs3Sdh28pXhAGZuyg/N15WnE8zD7BhM5ZEUSGGc3wmQnkK/PU
6UeXi3It3oFiJV+QGGAijZJJUZ8bfb3pjWv3bGpQ+0zsGlG44so=
=NQxC
-----END PGP SIGNATURE-----

--sTvi3iZnHrATJtTQ--