Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 19 Jan 2023 17:46:37 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
	"Drouvot, Bertrand" <bdrouvot@amazon.com>
Subject: Re: Generating code for query jumbling through gen_node_support.pl
Message-ID: <Y8kDbQluozdea/Oo@paquier.xyz>
References: <Y5BHOUhX3zTH/ig6@paquier.xyz>
 <34491a4e-2664-6ea7-662c-b13d18d2a92d@enterprisedb.com>
 <Y8EOUuViEL8Ewvf/@paquier.xyz>
 <d74d2681-5c07-2f6e-d177-995905015311@enterprisedb.com>
 <Y8YakMwx2a6Y63oR@paquier.xyz>
 <e4801c28-cb5b-3b81-bda1-03af8df1fef9@enterprisedb.com>
 <Y8ZTvD6nEqNttAHJ@paquier.xyz>
 <Y8eZ9/3STyhF57RV@paquier.xyz>
 <50b571dc-e0c0-22be-9803-4a3480d2e792@enterprisedb.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="843NbMPVj6YtKBVm"
Content-Disposition: inline
In-Reply-To: <50b571dc-e0c0-22be-9803-4a3480d2e792@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Y8kDbQluozdea/Oo%40paquier.xyz>
Precedence: bulk


--843NbMPVj6YtKBVm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 19, 2023 at 09:42:03AM +0100, Peter Eisentraut wrote:
> I see that in the 0003 patch, most location fields now have an explicit
> markup with query_jumble_ignore.  I thought we had previously resolved to
> consider location fields to be automatically ignored unless explicitly
> included (like for the Const node).  This appears to invert that?  Am I
> missing something?

My misunderstanding then, I thought that you were OK with what was
part of v1, where all these fields was marked as "ignore".  But you
actually prefer v2, with the second field "location" on top of
"ignore".  I can update 0003 to refresh that.

Would you be OK if I apply 0001 (with the comments of the locations
still reshaped to ease future property additions) and 0002?
--
Michael

--843NbMPVj6YtKBVm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPJA2wACgkQnvQgOdby
QH1S9RAAplK5bOQ+Sg+3p/FOxW7DjfTSXMKVukf01i9QCw97EgnIUUDxJKjrNNIC
4rqBvoMLiflFbOohewhxYUo8D8o14HJcyhJDqW/v5QoioYw2u0SF+ornEyNqO/Gs
ibT99eefKAVV6YZpFWiSggLHMmEcOnIVd3QPa4pNjHBcC1SM8/c1m/N1wGaxRS7x
Ca2uO8I6M7NeZluXhw9YIkHG817jDHK8vRqFxTRHuvLzFzUlKdBusEE2kvXYJPYT
1EAyxxYn/uLvhyyBOnBWdHwm9PT/QmKrZAkIVpphi+D6YhCLQaDA8FnA98GKvIpz
PwNvoMgkl+IFv0+g+A3quAJXUsGakmXEGXxWNR5mOwuu9HKRvyV5h5w0tETgC34S
e7pWrgwQpx+gqiiRzQNCPVVeYRp9GchwmKH3Pchf1JMLclNEYbwS3ro0wFUZ81w5
NOh+Cl0HHquhVCHydaY+qCadwHt5TtV2+tbi4sZg1bEsU6J4SloAJHg+OvwHRsH5
R5etV52WIx3Sm83oDGN0758HEerYDiY1DwNuiIxG2tfO1+AdVr2TKrdJ8TZRzLKn
7wJrQSUdHGX6WMLAtYBpgEkXurSpW4y0z9W0+IBPZwu3/HHuDzMsbF8zTdzr4erv
fT2u9xUxuOAABm4Li8C66R0Z/Y6a/I3HS36Fv0nF100vBphilCc=
=A3ZZ
-----END PGP SIGNATURE-----

--843NbMPVj6YtKBVm--