Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 4 Feb 2023 11:38:08 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>,
	Bruce Momjian <bruce@momjian.us>,
	Jelte Fennema <postgres@jeltef.nl>,
	Andres Freund <andres@anarazel.de>, Peter Geoghegan <pg@bowt.ie>,
	Magnus Hagander <magnus@hagander.net>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Message-ID: <Y93FEFBV/0IMGMCv@paquier.xyz>
References: <20230123173136.knn77pbuakhvjfgk@awork3.anarazel.de>
 <Y874Fh0q4mkk1s22@momjian.us>
 <CAGECzQTqoGHrePM_pwmhaM+J1XOygYjzFod4sf=PAt7J4A19Mw@mail.gmail.com>
 <2238493.1674572097@sss.pgh.pa.us>
 <Y9ArogF7c+UgPgq9@momjian.us>
 <20230129010603.GA1677550@rfd.leadboat.com>
 <Y9groc0Nyy7SOROy@momjian.us>
 <20230202062838.GA1832088@rfd.leadboat.com>
 <1477791.1675320029@sss.pgh.pa.us>
 <CAEZATCWDKJepqWozZyKQx87GvmadSHxnDMBJ9Po4KNVDoNGoyg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Dpu1ea9h6xZnpyPl"
Content-Disposition: inline
In-Reply-To: 
 <CAEZATCWDKJepqWozZyKQx87GvmadSHxnDMBJ9Po4KNVDoNGoyg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Y93FEFBV/0IMGMCv%40paquier.xyz>
Precedence: bulk


--Dpu1ea9h6xZnpyPl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 02, 2023 at 11:34:37AM +0000, Dean Rasheed wrote:
> I didn't reply until now, but I'm solidly in the camp of committers
> who care about keeping the tree properly indented, and I wouldn't have
> any problem with such a check being imposed.

So do I.  pgindent is part of my routine when it comes to all the
patches I merge on HEAD, and having to clean up unrelated diffs in
the files touched after an indentation is always annoying.

FWIW, I just use a script that does pgindent, pgperltidy, pgperlcritic
and `make reformat-dat-files` in src/include/catalog.

> I regularly run pgindent locally, and if I ever commit without
> indenting, it's either intentional, or because I forgot, so the
> reminder would be useful.
>=20
> And as someone who runs pgindent regularly, I think this will be a net
> time saver, since I won't have to skip over other unrelated indent
> changes all the time.

+1.
--
Michael

--Dpu1ea9h6xZnpyPl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPdxRAACgkQnvQgOdby
QH2hyQ/8D3oiMdX3OMnISazQBPPtMP7/bEMpgEW/+2hhx5KdW0Lbw46pgRUnwPi9
kwgGjl4msw29g1rmkMk36OjteZs65QRqqsh33eWTXpcs5I221NTtqQHN8LNp/ZEi
/Qv4khlsPWCG4Z4pjKcBqZaVfachLmTT7gRCCxm1SDb38BleYaSQZ4tsz3xsZHvI
6g7YDGv99FAFzXsUiqPSCUuFEF1a95KTg82hkpX9EekrRCLHjSsQ3xBUf1Jy95Ff
FgrfYifHewmuirnHInGvEzcexXgROGe+AD8nQLhKuUHqSYxk3byzOaVfZlly2bMU
OhLnxoY/6S4VKmVEXGM3A3/IukJrgckQEb8HCWd96MSF9DjCQbtKibLk0YwBv1Xy
VZG7k98QYgHGJ9Glp2x4BLTnu3RCJhSw0Uk9jUM2OmkN8g7WfIzk+eRPI8e7LrpG
iRoYYJjgoFS3gY9zO9asUbRy657EDy+6G79bD2c9wGRifVMo+mqb+pHohWUnQKwL
9DEuEwq+GSQ8hQGDpslAfWL3Xn/0+NyAcP1Lx72UVis8zZVh0vME78p75/Tad+2d
npRLTJv3HNV9wEMFmU3teeTdzIGMw7Afg/Ky5zYn2rpXMd7K93xhvj9igtZgsyVE
v1uAqyDrcJttt4TC4vo3moYTYMEf7TE4SMDE3oVWPHVGANXDbc8=
=4uJG
-----END PGP SIGNATURE-----

--Dpu1ea9h6xZnpyPl--