Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 5 Feb 2023 10:30:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Marcos Pegoraro <marcos@f10.com.br>,
	vignesh C <vignesh21@gmail.com>, Sergei Kornilov <sk@zsrv.org>,
	Robert Haas <robertmhaas@gmail.com>, Zhihong Yu <zyu@yugabyte.com>,
	David Steele <david@pgmasters.net>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Greg Stark <stark@mit.edu>,
	Pavel Trukhanov <pavel.trukhanov@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pg_stat_statements and "IN" conditions
Message-ID: <Y98GsRJoCM4RrcWp@paquier.xyz>
References: <20230129133219.tpuzqbyqw3ojztbd@erthalion.local>
 <20230202140727.g7tw7qjo43g54wcb@alvherre.pgsql>
 <20230202150554.dwxhvw23epcskppb@ddolgov.remote.csb>
 <20230204170841.xfgxoo7ymwbvu7yx@erthalion.local>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Op2eOY30ajKi9Hso"
Content-Disposition: inline
In-Reply-To: <20230204170841.xfgxoo7ymwbvu7yx@erthalion.local>
Archived-At: <https://www.postgresql.org/message-id/Y98GsRJoCM4RrcWp%40paquier.xyz>
Precedence: bulk


--Op2eOY30ajKi9Hso
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Feb 04, 2023 at 06:08:41PM +0100, Dmitry Dolgov wrote:
> Here is the rebased version. To adapt to the latest changes, I've marked
> ArrayExpr with custom_query_jumble to implement this functionality, but
> tried to make the actual merge logic relatively independent. Otherwise,
> everything is the same.

I was quickly looking at this patch, so these are rough impressions.

+   bool        merged;         /* whether or not the location was marked as
+                                  not contributing to jumble */

This part of the patch is a bit disturbing..  We have node attributes
to track if portions of a node should be ignored or have a location
marked, still this "merged" flag is used as an extension to track if a
location should be done or not.  Is that a concept that had better be
controlled via a new node attribute?

+--
+-- Consts merging
+--
+CREATE TABLE test_merge (id int, data int);
+-- IN queries
+-- No merging

Would it be better to split this set of tests into a new file?  FWIW,
I have a patch in baking process that refactors a bit the whole,
before being able to extend it so as we have more coverage for
normalized utility queries, as of now the query strings stored by
pg_stat_statements don't reflect that even if the jumbling computation
marks the location of the Const nodes included in utility statements
(partition bounds, queries of COPY, etc.).  I should be able to send
that tomorrow, and my guess that you could take advantage of that
even for this thread.
--
Michael

--Op2eOY30ajKi9Hso
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmPfBrEACgkQnvQgOdby
QH312w//Rx0eTOpwz2reyh8kOqHLunqMixMfD4ESpD8D9DtTzND90p134XgI1wVt
yEsaDodd5RzIn7PMDfCYa8O1PjC2pnr4558tkDLoaBfM8dkoeJGgzQUvaibrzXYC
Fpoqrms1M3VxLJDUyZzG3b7LJvJ5L170kpYCCju0Ogh4xPUimossvasugd1BlK1N
eKQzPrOWHjNafwtuu9RKN/yDcyvl/1gHCvrgqWEDaGW6CVtvQSN8xHQ1A21ZxJWH
Va1qWLzSrkmzz34ibthI0XV3HEsCeud5ABNa2lq4YpT4nEXxnkf+w5y1lIlrT//j
D9jq7rWHRkOTSvUcaymfJkNZC346YC1WWXR2lYCZpCWT/vTBKZH2RxvwkYOC4ry8
zEI5B9SfXEUgy5pI5OwrPe9oLDiA6uG88sXTM7oP6Tu5a++EWXVAH8sI33UvwS4C
jzEyj4Ws1Qs/DWb5NU7T8YIIQuA8AYGVDDkTTf3CzwbFnyZXe/gizmo374PQvgUK
WZfF+3xfpQr4B7nq79cy0oDSzVSWHS7CPlLoe6OHvvouokna6A6z6jdYo0mxVkZ/
jWuHXITgb1iz0NNUYC0bmVM9abITQJBiuq7ORiwSGLEr8nz64i2aMmiW489Idnox
MeFA6aVLWPFZVtsRBpIOdhkQSJY7+BatTWTf39YBBuxpB9lbkP0=
=/zi1
-----END PGP SIGNATURE-----

--Op2eOY30ajKi9Hso--