Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6nqV-0005CU-5x for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Feb 2021 05:03:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l6nqT-00006N-Sz for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Feb 2021 05:03:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6nqS-0008Vv-BQ for pgsql-hackers@lists.postgresql.org; Tue, 02 Feb 2021 05:03:21 +0000 Received: from [66.111.4.29] (helo=out5-smtp.messagingengine.com) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6nqP-00059t-7E for pgsql-hackers@lists.postgresql.org; Tue, 02 Feb 2021 05:03:20 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D85C25C00FE; Tue, 2 Feb 2021 00:03:05 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Feb 2021 00:03:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=Nos9H1r9loMlXCOhKqcVpEu6BRy KSxoKkrJJO5v+oSU=; b=L0i20/GhnnrhSmi5tUCQuWjNliugY6dehk0k4LaGzJY Ld2HYkpbaoy9Gs7YFsP4Lq5x5AvWGwBEccYa226rwURxHyTuwuUioNQkYzguLkAP h7rIFOGs5hp31Y2LKU43rz0i4dENGxRHZO4lYpl7ORjDZsNasE+jLjn0qgMEGLtl BmqpvwQE0WNljdKNvHAwAcqqxa11gQvfvVpBZUYTXp4aFm9OPIHyHB3+8YIpaUDA 3FoEqOfqiS+Qo+0iYhpvgKw3fp6ql7NWylrejHoRtOf2mwWzprbdPcO/a/QVZIfp hgGJOs1aET5hX7Gch2HYs25cXKuSKY6W8ULJy2RLTkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Nos9H1 r9loMlXCOhKqcVpEu6BRyKSxoKkrJJO5v+oSU=; b=UP9kTvJnkljWkeImcmIvYV sdakcHx3xpcA3xYC1WXvevt4vyge9BFUechjBM5A7y/DU/5q9OtpQLdLW/NGYy3q fPyWhHDnGBIcf4RtWTuD96K8McChLHlDIPCS1EwHb4S5BNq09dydE37ly2Cm+h+H msbU6xyW7DbSVuWUy90JEbE/V3pj+e5fSL5Eu+nzG/TIZv4hHY6QHK3E2daip/aV HUioTCj499TGeA9Y2/QRQXM0F5ULoAITpD391KLJgbVvm96th424ULmiNqmTSnF0 gYfa/3Qnu0vQyB1Ko85WwAo+XNcRuHNO0OXO2S+LETSIaO1oUk1AUa53SSj1koKQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeelgdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveejheeh ieevueeigeelteegleejleeiueeiheegvefhnecukfhppeduuddurddutddvrddukedtrd dukeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep mhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id A787D108005F; Tue, 2 Feb 2021 00:02:58 -0500 (EST) Date: Tue, 2 Feb 2021 14:02:53 +0900 From: Michael Paquier To: Euler Taveira Cc: japin , =?utf-8?B?w5ZuZGVyIEthbGFjxLE=?= , David Steele , Craig Ringer , Tomas Vondra , Amit Langote , movead li , pgsql-hackers@lists.postgresql.org Subject: Re: row filtering for logical replication Message-ID: References: <20191128023201.GH237562@paquier.xyz> <20200116215730.vq6ark7uycmvwxtx@development> <2963266d-07b5-aed3-7cbe-2d5f2bc0b453@pgmasters.net> <8cf1ea71-b609-00e8-b8f0-c85ba61b7312@pgmasters.net> <4dbad191-9b40-4bb6-8940-d18f2e93c3ce@www.fastmail.com> <5b9fceed-8f91-467f-a64e-2134c5c3f496@www.fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gu3rqvV7ysayoJhY" Content-Disposition: inline In-Reply-To: <5b9fceed-8f91-467f-a64e-2134c5c3f496@www.fastmail.com> X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.29 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --gu3rqvV7ysayoJhY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 01, 2021 at 04:11:50PM -0300, Euler Taveira wrote: > After the commit 3696a600e2, the last patch does not apply cleanly. I'm > attaching another version to address the documentation issues. I have bumped into this thread, and applied 0001. My guess is that one of the patches developped originally for logical replication defined atttypmod in LogicalRepRelation, but has finished by not using it. Nice catch. -- Michael --gu3rqvV7ysayoJhY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmAY3P0ACgkQnvQgOdby QH02pQ//YDZnai3bUkihna5/+eaMwg1Er2yIP5FRQsHl2hhBggvlSNCubU1mU6/5 +3RE2oBBYUkIsTmNOY69iwco+6y3uy0ZIXzYqRWmwK79s6oAIOuhaPLN+4Td2aOq TQGiXK4GoU55RjwT/xiuZNGwGtguqDX003bfc2IBl6KRYi0Sm+fasIudcLnXbl42 xF2qCj+vjhPbHaFDtcgBMEYViIrWSACbneIZFnshEqctz+JzhcdmXy11BWg2gBc5 dgyD6BOxaEzlwW5rfa0+bopy49PqxubE6Cuxuv3sFNf1W4csG04mxAP/n9fSkRn8 orcGdglx8nWPkJUhSHfIylnH39UzPayu3JcWgiq1+gdyMahDMj8BL6dVfHtP87mr u9prdFVyT/UvDsfJEcjquDP+sHxgSafK8vvDrHEJ9VJrK17pMrovPHxcws20neEd zIsiTxmSwU5eF64p+6sG+JKyjtLW2DXqwoGmr4myIc9XCnOdoStgdO0B1BlWIUpM 1411ZtDTrjysg/b6sycIDmyuv5sbKYxhj10p+z2y4WRTIjAQFjOtMhoTn6uS33JS bCwyP+9lsT7dW+5WCj7uQ2iyUCRw4FiVJ/dUYNHKSK0lxmLr9DF6FoGasgaVpZZP JhCKNWHRmrH+ds3uAsvAVgIkfKLU6bgBStNWlpyZwDMZhWGZpa4= =3Gtj -----END PGP SIGNATURE----- --gu3rqvV7ysayoJhY--