Date: Tue, 9 Feb 2021 15:47:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jacob Champion <pchampion@vmware.com>,
	"hlinnaka@iki.fi" <hlinnaka@iki.fi>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
	"andrew.dunstan@2ndquadrant.com" <andrew.dunstan@2ndquadrant.com>,
	"thomas.munro@gmail.com" <thomas.munro@gmail.com>,
	"andres@anarazel.de" <andres@anarazel.de>,
	"sfrost@snowman.net" <sfrost@snowman.net>
Subject: Re: Support for NSS as a libpq TLS backend
Message-ID: <YCIv0beoEF4+pIiH@paquier.xyz>
References: <YAUz/A+KCCzjrvTr@paquier.xyz>
 <A9C4ADFC-D86B-414A-AF98-7FC14D482198@yesql.se>
 <f5974a6daae02996611caa216ab1ba469b3fa285.camel@vmware.com>
 <8D7F95DB-8F8A-4300-BFDA-656FBAB30FE2@yesql.se>
 <a9b663ae4a4b71525e88b75463c865a6693cb4ce.camel@vmware.com>
 <E79F0466-05A7-4771-85B4-464E25BD2787@yesql.se>
 <f988c26457d56a5ba75ff0dc77def89bfdda154d.camel@vmware.com>
 <ca450cb8a74de3dcc753386f57a5f1d5221d6916.camel@vmware.com>
 <YBuh9mgyzjWuVJhF@paquier.xyz>
 <5382CB4A-9CF3-4145-BA46-C802615935E0@yesql.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="7t4JaZr8OtAp/vbK"
Content-Disposition: inline
In-Reply-To: <5382CB4A-9CF3-4145-BA46-C802615935E0@yesql.se>
Precedence: bulk


--7t4JaZr8OtAp/vbK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 09, 2021 at 12:08:37AM +0100, Daniel Gustafsson wrote:
> Attached is a new patchset where I've tried to split the patches even further
> to try and separate out changes for easier review.  While not a perfect split
> I'm sure, and clearly only for review purposes, I do hope it helps a little.
> There is one hunk in 0002 which moves some OpenSSL specific code from
> underneath USE_SSL, but thats about the only non-NSS change left in this
> patchset AFAICS.

I would have imagined 0010 to be either a 0001 or a 0002 :)

 }
+#endif                         /* USE_SSL */
+
+#ifndef USE_OPENSSL

PQsslKeyPassHook_OpenSSL_type
PQgetSSLKeyPassHook_OpenSSL(void)
Indeed.  Let's fix that on HEAD, as an independent thing.

     errmsg("hostssl record cannot match because SSL is not supported by this build"),
-    errhint("Compile with --with-ssl=openssl to use SSL connections."),
+    errhint("Compile with --with-ssl to use SSL connections."),
Actually, we could change that directly on HEAD as you suggest.  This
code area is surrounded with USE_SSL so there is no need to mention
openssl at all.

-/* Support for overriding sslpassword handling with a callback. */
+/* Support for overriding sslpassword handling with a callback */
Makes sense.

 /*
  * USE_SSL code should be compiled only when compiling with an SSL
- * implementation.  (Currently, only OpenSSL is supported, but we might add
- * more implementations in the future.)
+ * implementation.
  */
Fine by me as well, meaning that 0002 could just be committed as-is.
I am also looking at 0003 a bit.
--
Michael

--7t4JaZr8OtAp/vbK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmAiMA4ACgkQnvQgOdby
QH1epg//ZySq540eJzkTrl/D4v+SV9NGAEVQC7tnEMlysEokoN+iW/WjgWjkeMcn
p0osDtvb5k7VV6sRjYj4E1Cn2EW9bAvsOBM4GybD0ngbBhNKIIwiXoMZGS5puzE+
ATs9IzSLqW63d1nKCxf90M1vqaHAhurR1r/QMFQJ5HoCr4vDgs+njOIK3xRSCPcw
1ibKT3CmrUkNFXmuNakzP0ZTkrxkkt1TadfuxXHvOQMG/9Hlj1Kl7wo+fF2Xkvg4
tXQ+FS6NESKBh3yJDgwTnp2w4Zon3V2txUjbWWssuIIhsTWWCj6z7UMROd6jrBmZ
OFRrllSpL3CuCDXlHJG0HX0par4jQuccpsoQq0dI9/0Ah4hXhjATc4ExWXTbmP1s
JObc+NWIg8Gnbxb6WCvVePr2xEanY8wMclvpPyuCYGBXRfv0E18CR7/AqQGPBSKA
jdCes9IN9jUiLPvBEGtxfIX0Bf7vEbPigerWdMUeyCXp90/0bJbnXlsTfPReEE+B
xGUDQialwS6wHtg3mrfolVlvcoTsHVIc21o679wO0g3nga8wTg2jYut0ULkAod/7
BHiU2ASK5d/orJpw6kJLaY033hhUkQ6iPTC6KKPD6r9wjDgs2xVBAYbFVGQOr7f4
THkvkHl4UPP4gV5qY2SlVq4mzxMMMgVcizBbhFpg1wfo4cCN1GI=
=KfrG
-----END PGP SIGNATURE-----

--7t4JaZr8OtAp/vbK--