Date: Thu, 11 Feb 2021 21:55:40 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: ERROR: invalid spinlock number: 0
Message-ID: <YCUpTL8bZHa+9K+0@paquier.xyz>
References: <7ef8708c-5b6b-edd3-2cf2-7783f1c7c175@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FRPGRTEL637QWWvA"
Content-Disposition: inline
In-Reply-To: <7ef8708c-5b6b-edd3-2cf2-7783f1c7c175@oss.nttdata.com>
Precedence: bulk


--FRPGRTEL637QWWvA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi Fujii-san,

On Tue, Feb 09, 2021 at 11:17:04PM +0900, Fujii Masao wrote:
> ISTM that the commit 2c8dd05d6c caused this issue. The commit changed
> pg_stat_get_wal_receiver() so that it reads "writtenUpto" by using
> pg_atomic_read_u64(). But since "writtenUpto" is initialized only when
> walreceiver starts up, reading "writtenUpto" before the startup of
> walreceiver can cause the error.

Indeed, that's a problem.  We should at least move that out of the
spin lock area.  I'll try to look at that in details, and that's going
to take me a couple of days at least.  Sorry for the delay.
--
Michael

--FRPGRTEL637QWWvA
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmAlKUwACgkQnvQgOdby
QH1H5BAAlTjh9mkTWmch7ckPWlv0j5dflZ1CuLMsiNDm5hJWVFWVrt2tlmKy4nBl
cMH8tqkyGrnBZtj1tId2VVjyCboKXtQEbPKVMq38/c+PdQxovbStHABeDhrHU+vA
9CPbV9hkNuC9CZ4S8xxBo0fmC+HTUj+yAnyx78vLkDzsKvyvKj8c5/iTvR2m7ofB
vJ95NQalt3pQZ3CfKsgksBWyUgaPvieN8v5k8wRNN/Rht8qSXyEPYTCpExmYjThC
cwzGrHZXwecXhByT7FoQL/F4XeOXYl22r/pxTMvtcSKVVUGPLWRIpFGJTl5slWdZ
xO7A9XOYDMAwKQLS32P0uK53cvQ1ncXzZzEdW4qD6WNyZByb1iqWa7T7ciLcgXN3
4W4png9RD481ruY0iWvune3uSuEKOwvbL6LUDfk9Et8m3XC7CZ7hjbO4wp+6QBFP
dhjoBC3KqOL8YPUOK35UJuV7WXD+rgj6IcYasKYiPsjntEcp8UrjssLevwn5oFtL
fwDIzH18lEZ4jpMnb/mv3/a2G/j41L3jcNsP6xmtm5D/EMTEzGNrt3bkVrYOL2ux
gvCF2yzEPt5CkmEObg8fDBcm8/ChrHER38lASgp4iXsZFd5tDsFR61fI60o5CiU7
9fPrOirX7JDf53VdSeS3zJhqHGmr0bo4kI2REZqfhLhr6oQhGt0=
=5KgB
-----END PGP SIGNATURE-----

--FRPGRTEL637QWWvA--