Date: Thu, 4 Mar 2021 16:05:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Georgios <gkokolatos@protonmail.com>,
	Julien Rouhaud <julien.rouhaud@free.fr>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	"robertmhaas@gmail.com" <robertmhaas@gmail.com>
Subject: Re: Shared memory size computation oversight?
Message-ID: <YECGppkDKJArPOUb@paquier.xyz>
References: <20210227080815.jryyhy6lrn6gahkm@nol>
 <SeVx6SxBxMHIm_66gE4M8rzAn5vqXw8akcyJ-26bJxHeNC_wW9fN-xDr_G3AGiSH328-rxMzXbNf6H4TsaNIG-OJFE8LvmdflG9Zb-yIKq4=@protonmail.com>
 <1183451.1614788634@sss.pgh.pa.us>
 <20210303164052.f336wina7qpchabd@nol>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5G2Dci954KlbvOGo"
Content-Disposition: inline
In-Reply-To: <20210303164052.f336wina7qpchabd@nol>
Archived-At: 
 <https://www.postgresql.org/message-id/YECGppkDKJArPOUb%40paquier.xyz>
Precedence: bulk


--5G2Dci954KlbvOGo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 04, 2021 at 12:40:52AM +0800, Julien Rouhaud wrote:
> On Wed, Mar 03, 2021 at 11:23:54AM -0500, Tom Lane wrote:
>> I have not looked at this patch, but I think the concern is basically th=
at
>> if we have space-estimation infrastructure that misestimates what it is
>> supposed to estimate, then if that infrastructure is used to estimate the
>> size of any of the "big hog" data structures, we might misestimate by
>> enough that the slop factor wouldn't hide it.
>=20
> Exactly.  And now that I looked deeper I can see that multiple estimates =
are
> entirely ignoring the padding alignment (e.g. ProcGlobalShmemSize()), whi=
ch can
> exceed the 6kB originally estimated by Robert.

We are going to have a hard time catching up all the places that are
doing an incorrect estimation, and have an even harder time making
sure that similar errors don't happen in the future.  Should we add a=20
{add,mul}_shmem_size() to make sure that the size calculated is
correctly aligned, that uses CACHELINEALIGN before returning the
result size?
--
Michael

--5G2Dci954KlbvOGo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBAhqYACgkQnvQgOdby
QH2V+RAAoFdUvds1O9klyHUjDeMx33rHEvu9fQJSAXgqKR7HTj4/5bcKcSa54YWb
iLdWZTVtq23BK5ppoGQ5QrP8KuXi1K4MZ16VPgMzfB++K+Hgqw1gEL5brpkQe1Ta
0TxQKInQ/49buBwFKuJHtANLf6Bd+xN5LDyKNa15fRllJOE5BlPQUAf6A8Ua40ox
qcjYXVArT+cIH2+jXyDEHi4YPpWxZ27D6eFrsm8m1ZHpxcXjghA14kLP2meUv+mx
Yj/nPDQiR8J+YYbtQtj5I5QYUjN40iAQNKYVwNw34NldyyOcKjK67SH5tVS3pwVg
Ka3NPmof0b7cV1tWz97wouIwj/Cq7Vw5uuoA18NHRoasG3jLCKROG5I2+2/jtzQV
V/hzYmConst5bpbV14A+btHUPQkq2qEyPoLA/VpO2RKUNCTgGj7UivM/GFk4IjSi
rFafR89FiB7r5PuR2iqHWARyFT+ackRYGffUJ7XcIu2vWMKygjSgvMFYaeCjsvSi
kQbAGjxgjOqB4l196ex526UocUG6+oui4uh1SXLPxZrnce40hejFWvafPtwJhSIf
iOaEmTPh59K7HDAZaXW1kPuVkwFdx/f4DVcgqA46LaOip6gHtPGcFgs3evoKuQWf
L9NC1AgvCMTeROci9DRH6kPOYyhKw1dHXWfpPJorinSIS26TR8M=
=dac3
-----END PGP SIGNATURE-----

--5G2Dci954KlbvOGo--