Date: Tue, 9 Mar 2021 21:31:16 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Euler Taveira <euler.taveira@2ndquadrant.com>,
	Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: cleanup temporary files after crash
Message-ID: <YEdqlL3Gr3rZ/aC8@paquier.xyz>
References: 
 <CAH503wDKdYzyq7U-QJqGn=Gm6XmoK+6_6xTJ-Yn5WSvoHLY1Ww@mail.gmail.com>
 <20201028184252.5vpoe65kcfebbmmf@development>
 <CAH503wCg+yne7hKAAFFHsVPe+tPb-aF5VGaWG0ETqyB3GP=Q+g@mail.gmail.com>
 <20201101012555.GC3000@paquier.xyz>
 <1982ee3c-54c3-280a-806a-fd28ad8f19e6@postgrespro.ru>
 <CAH503wBLgLGhqCduqzOBgCYNS5DiJnUJdU+RVCCQoka8Tndndg@mail.gmail.com>
 <363cb85c-3a03-9a49-b830-8b645c1241d9@enterprisedb.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gSNgoU/Uv7IScV9Z"
Content-Disposition: inline
In-Reply-To: <363cb85c-3a03-9a49-b830-8b645c1241d9@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YEdqlL3Gr3rZ/aC8%40paquier.xyz>
Precedence: bulk


--gSNgoU/Uv7IScV9Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 09, 2021 at 02:28:43AM +0100, Tomas Vondra wrote:
> Let's move this patch forward. Based on the responses, I agree the
> default behavior should be to remove the temp files, and I think we
> should have the GUC (on the off chance that someone wants to preserve
> the temporary files for debugging or whatever other reason).

Thanks for taking care of this.  I am having some second-thoughts
about changing this behavior by default, still that's much more useful
this way.

> I propose to rename the GUC to remove_temp_files_after_crash, I think
> "remove" is a bit clearer than "cleanup". I've also reworded the sgml
> docs a little bit.

"remove" sounds fine to me.

> Attached is a patch with those changes. Barring objections, I'll get
> this committed in the next couple days.

+        When set to on, <productname>PostgreSQL</productname> will automatically
Nit: using a <literal> markup for the "on" value.

+#remove_temp_files_after_crash = on    # remove temporary files after
+#                                  # backend crash?
The indentation of the second line is incorrect here (Incorrect number
of spaces in tabs perhaps?), and there is no need for the '#' at the
beginning of the line.
--
Michael

--gSNgoU/Uv7IScV9Z
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBHapQACgkQnvQgOdby
QH05ZA//SkEGQxGq63YSauVgnKcsKEJ2yZ6lzmIyQrv8ctpdzbVKx7NKl4pwXYsr
IMc73Jm5j05YSLYoOS9V8ezGl3AkrEXDgaMrfYdVOqcNdrpJ4OJFszB6P9mjl3hS
dekTfFoywvY78VZ7eYjsPot8cpTCgnBvUDkhCIpU5Dm19uTjyvBIQ9IjnfuuqZss
PIUlcTcFPEKi+ACpCXj9ao5Sg0l22wOOD3sCkmnPtkEmkRMnfZD7JxTOdvi2Blo4
6Q5h7Kg6GYsvyZZrfqgwqkT7Xb28skFyj+3J4CoL65O1+zaKbktRR3+OsVksnMcN
M9m98kh7bFgKFL2YitNIJXaqRhvgKwSInvfTe5OmPxEi2T9xlhGsd5DoowSnCcrM
5ya4FEAlWfE1LT8PDAHf5O7TIPqOU1Ka4nr8LVeXNj7syUo+OhnniWtVW2iTuP8U
fWfHz1V1kXL4vAfEK89J5GX+w7+XiB/Qz+0dfG3sRIy3HrFA7G/LisW5mve0MlfS
Ez6EzlqGDbIqKLSc2UIARLfNiFi+gaHC7GeRrkd/XtQ8GnQX6lSo8++x0swbwNnH
7nMkj2EHipmKAHnmCxO3vOaW5Qe+kis5TOfnsmon1dpQuSbasVdBsA+vEUHoIU1s
udeAcKRuf+Pbnyudw/hzg2VYO5gPbFLTz0BISP7pvF76FMwp8tQ=
=MsGk
-----END PGP SIGNATURE-----

--gSNgoU/Uv7IScV9Z--