Date: Tue, 16 Mar 2021 16:20:37 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Permission failures with WAL files in 13~ on Windows
Message-ID: <YFBcRbnBiPdGZvfW@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tB9LfGFa9xHD9NGU"
Content-Disposition: inline
Archived-At: 
 <https://www.postgresql.org/message-id/YFBcRbnBiPdGZvfW%40paquier.xyz>
Precedence: bulk


--tB9LfGFa9xHD9NGU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

There has been for the last couple of weeks a collection of reports
complaining that the renaming of WAL segments is broken:
https://www.postgresql.org/message-id/3861ff1e-0923-7838-e826-094cc9bef737@hot.ee
https://www.postgresql.org/message-id/16874-c3eecd319e36a2bf@postgresql.org
https://www.postgresql.org/message-id/095ccf8d-7f58-d928-427c-b17ace23cae6@burgess.co.nz
https://www.postgresql.org/message-id/16927-67c570d968c99567%40postgresql.org

These have happened on a variety of Windows versions, 2019 and 2012 R2
being mentioned when segments are recycled.

The number of those failures is alarming, and the information gathered
points at 13.1 and 13.2 as the culprits where those failures are
happening, so I'd like to believe that there is a regression in 13.
FWIW, I have also been doing some tests on my side, and while I as not
able to trigger the reported failure, I have been able to trigger the
same error with an archive_command doing a simple cp that failed
continuously on EACCES.

Fujii-san has mentioned that on twitter, but one area that has changed
during the v13 cycle is aaa3aed, where the code recycling segments has
been switched from a pgrename() (with a retry loop) to a
CreateHardLinkA()+pgunlink() (with a retry loop for the second).  One
theory that I got in mind here is the case where we create the hard
link, but fail to finish do the pgunlink() on the xlogtemp.N file,
though after some testing it did not seem to have any impact.

I am running more tests with several scenarios (aggressive segment
recycling or segment rotation) to get more reproducible scenarios,
but I was wondering if anybody had ideas around that.

So, thoughts?
--
Michael

--tB9LfGFa9xHD9NGU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBQXEUACgkQnvQgOdby
QH22PxAAqKZvcpawFu+eZdq1jZj22aN/PRuDhRGsaAAgPBOBmNkMSGnTKqIRxP4s
h/TWkofJDuSI2TLXfeBpe+c2MQa3pzkEg7edzulafotR6LHF9QR6Z6xWIZZJ6ixy
pFPBZ/Mz3XSJNl78RRX15F6bLfWpuxiSIgI7ku104e5rXWPH0IyxeKaGDwSPYTDL
m0/jkuxLs17IZxmua44CNAH648uRK3D9vFJyHMXMmlUm7E5UolQSO/vq5fzTEdQ+
sZ1gGaaHY4ar3yJyq3EQINljZXZ1XGO5Pix/JSZ7QvnBx1fMgXLof9nCvJxiBS5I
nQBcEBKRpj2MQWCtZaCzYlHI/7qQIUPx4gqV5+avp9aWl3ROyK3n2f60qFLZW6Yx
wiRzdX+itJJTrmmMa1J46htV6OxmcIttgspz7Dsm4qyeoulJqXT7b9buIv9UQOPY
h0MXiBpQO+rtpgXOmrf4+/l7oDu2gDgwZdiCJQ2Cu4go6AGiiY6g/xOQQuB/KRnA
6LA47R431q/fG0aLKPZ5WFWraOXRrVmgWZTZwh1noq/NJHUv1GpJqUXGQpWlv9S+
7VnxazQdMZNsKfegNQI9HAzey+8CGkP67BuDAe5oc1heFuF/nsbDJahJTAXafkCZ
Ed8JEW+JO+YYCEyVtrZdWt2GERiY9whmVnFbmeN8+jF0ot6mGsA=
=Ia6r
-----END PGP SIGNATURE-----

--tB9LfGFa9xHD9NGU--