Date: Fri, 9 Apr 2021 10:06:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>,
	"shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Message-ID: <YG+okFpc3JaKN/zB@paquier.xyz>
References: <d5b5b051-61e4-9e45-a035-e4b291f94e3b@2ndquadrant.com>
 <alpine.DEB.2.22.394.2103141046590.164573@pseudo>
 <1ec5ef49-b5c8-4129-e680-fe42f8d0670b@2ndquadrant.com>
 <alpine.DEB.2.22.394.2104062323150.2555247@pseudo>
 <OSZPR01MB631017521EE6887ADC9492E8FD759@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <alpine.DEB.2.22.394.2104071516470.2724014@pseudo>
 <OSZPR01MB6310325023E8B4109BB2AB90FD749@OSZPR01MB6310.jpnprd01.prod.outlook.com>
 <20210408163050.fca7dwb37zszbsmm@nol>
 <alpine.DEB.2.22.394.2104081858500.3192110@pseudo>
 <20210408171135.ekhdf5nvqss554q3@nol>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="DgP+wNUkk4QDkekQ"
Content-Disposition: inline
In-Reply-To: <20210408171135.ekhdf5nvqss554q3@nol>
Archived-At: 
 <https://www.postgresql.org/message-id/YG%2BokFpc3JaKN/zB%40paquier.xyz>
Precedence: bulk


--DgP+wNUkk4QDkekQ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 09, 2021 at 01:11:35AM +0800, Julien Rouhaud wrote:
> On Thu, Apr 08, 2021 at 07:04:01PM +0200, Fabien COELHO wrote:
>> It is definitely a open item. I'm not sure where you want to add it=E2=
=80=A6
>> possibly the "Pg 14 Open Items" wiki page?
>=20
> Correct.

I was running a long query this morning and wondered why the
cancellation was suddenly broken.  So I am not alone, and here you are
with already a solution :)

So, studying through 3a51306, this stuff has changed the query
execution from a sync PQexec() to an async PQsendQuery().  And the
proposed fix changes back to the behavior where the cancellation
reset happens after getting a result, as there is no need to cancel
anything.

No strong objections from here if the consensus is to make
SendQueryAndProcessResults() handle the cancel reset properly though I
am not sure if this is the cleanest way to do things, but let's make
at least the whole business consistent in the code for all those code
paths.  For example, PSQLexecWatch() does an extra ResetCancelConn()
that would be useless once we are done with
SendQueryAndProcessResults().  Also, I can see that
SendQueryAndProcessResults() would not issue a cancel reset if the
query fails, for \watch when cancel is pressed, and for \watch with
COPY.  So, my opinion here would be to keep ResetCancelConn() within
PSQLexecWatch(), just add an extra one in SendQuery() to make all the
three code paths printing results consistent, and leave
SendQueryAndProcessResults() out of the cancellation logic.

>> I tried but I do not have enough
>> privileges, if you can do it please proceed. I added an entry in the nex=
t CF
>> in the bugfix section.
>=20
> That's strange, I don't think you need special permission there.  It's
> working for me so I added an item with a link to the patch!

As long as you have a community account, you should have the
possibility to edit the page.  So if you feel that any change is
required, please feel free to do so, of course.
--
Michael

--DgP+wNUkk4QDkekQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmBvqJAACgkQnvQgOdby
QH0i7Q/+JBmwNT4JJNU2IyFeJi998UII6cpeoeWSMlcHFDtKZ9HlHfWeDRC7EZE0
HOyLiYmEC4rAFVDSFalP4L2g1xz5sGNuiznN1svaSEZBXXaxuAea065MQz0KMyJD
G1zuwTyi7enjpPmioSY21TXeCAdv+zvGptucWcvRusC+iOJCVjpGIQaU+PF/A5ej
xmVWsBnGEJw80T03Tz6zO3zQPwhsmCpedRJltNtMs/RJWJ9O4cD4C6xFolfuaUb/
AypsooksD8eWkenC802QVpbg/iM2+66UcB4v4ucM7cvavRV4tyiXPdUgQkG97xax
Ldz/w6E8KSEf3W8gXqsFug6vsFAj0uoZlMTWKc5MoJ6CYWYGruPcg1Nku7LhCO3N
tGRDoOehQLlHClSp+7GNTXQp7Pr/FppOY+J6CTv17of7bIRKH2HuthPrCMT1v9cc
mQGFtt8gt/ZobPGsEUmO+7oa08i0lO1Hw/9LYehu09iqsExbYXx2mBMZ5rxwUfjS
dnL4WxtRx29D3YLi1jo5TbzmCAFEJ3KwMLTkcu+n2gwWYf1cgk0P5//4bIpvb4zE
MTGBRpESykHiepAymoaA3DzbuxzC2vgP0NUFlpMIKxMjdxNAGUe4dRr1SK3kVPtn
i5Tky36t6cMeb6HPtBTb5fyWmVpbsBdPqua0sBpv+gpe+SudpwQ=
=UOUU
-----END PGP SIGNATURE-----

--DgP+wNUkk4QDkekQ--