public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Fabien COELHO <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: Fri, 9 Apr 2021 19:51:25 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2104090828330.3253600@pseudo>
References: <[email protected]>
<alpine.DEB.2.22.394.2104062323150.2555247@pseudo>
<OSZPR01MB631017521EE6887ADC9492E8FD759@OSZPR01MB6310.jpnprd01.prod.outlook.com>
<alpine.DEB.2.22.394.2104071516470.2724014@pseudo>
<OSZPR01MB6310325023E8B4109BB2AB90FD749@OSZPR01MB6310.jpnprd01.prod.outlook.com>
<20210408163050.fca7dwb37zszbsmm@nol>
<alpine.DEB.2.22.394.2104081858500.3192110@pseudo>
<20210408171135.ekhdf5nvqss554q3@nol>
<YG+okFpc3JaKN/[email protected]>
<alpine.DEB.2.22.394.2104090828330.3253600@pseudo>
On Fri, Apr 09, 2021 at 08:47:07AM +0200, Fabien COELHO wrote:
> Yep, it looks much better. I found it strange that the later did a reset but
> was not doing the set.
>
> Attached v2 does as you suggest.
Close enough. I was thinking about this position of the attached,
which is more consistent with the rest.
--
Michael
Attachments:
[text/x-diff] fix-cancel-3.patch (610B, ../[email protected]/2-fix-cancel-3.patch)
download | inline diff:
diff --git a/src/bin/psql/common.c b/src/bin/psql/common.c
index 028a357991..f289f05843 100644
--- a/src/bin/psql/common.c
+++ b/src/bin/psql/common.c
@@ -1117,7 +1117,6 @@ SendQueryAndProcessResults(const char *query, double *pelapsed_msec, bool is_wat
INSTR_TIME_SET_CURRENT(before);
success = PQsendQuery(pset.db, query);
- ResetCancelConn();
if (!success)
{
@@ -1382,6 +1381,7 @@ SendQuery(const char *query)
{
/* Default fetch-it-all-and-print mode */
int res = SendQueryAndProcessResults(query, &elapsed_msec, false);
+ ResetCancelConn();
OK = (res >= 0);
results = NULL;
}
[application/pgp-signature] signature.asc (833B, ../[email protected]/3-signature.asc)
download
view thread (104+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: psql - add SHOW_ALL_RESULTS option
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox