Date: Thu, 15 Apr 2021 10:21:32 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: "Bossart, Nathan" <bossartn@amazon.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Fabien COELHO <coelho@cri.ensmp.fr>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	"shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Message-ID: <YHeVHH0wVcRwdogL@paquier.xyz>
References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com>
 <20210412193301.GA11204@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="YbB80Sw7nEz6NLED"
Content-Disposition: inline
In-Reply-To: <20210412193301.GA11204@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/YHeVHH0wVcRwdogL%40paquier.xyz>
Precedence: bulk


--YbB80Sw7nEz6NLED
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 12, 2021 at 03:33:01PM -0400, Alvaro Herrera wrote:
> Please note that there's no "for now" about it -- if the patch is
> reverted, the only way to get it back is to wait for PG15.  That's
> undesirable.  A better approach is to collect all those bugs and get
> them fixed.  There's plenty of time to do that.
>=20
> I, for one, would prefer to see the feature repaired in this cycle.

If it is possible to get that fixed, I would not mind waiting a bit
more but it would be nice to see some actual proposals.  There are
already three identified bugs in psql introduced by this commit,
including the query cancellation.

That's a lot IMO, so my vote would be to discard this feature for now
and revisit it properly in the 15 dev cycle, so as resources are
redirected into more urgent issues (13 open items as of the moment of
writing this email).
--
Michael

--YbB80Sw7nEz6NLED
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmB3lRwACgkQnvQgOdby
QH1tSQ/+IwqB2qv5TMMPY5Pm7Sb+VusrtO9binKEw6Y+2iBMAX456Sjoqv9J4i5a
e5sWs8gUJ11EWFlMbehv46YeQ6hGo2+jkSn5pwTwbI/qkmEBPwBQfB1lNDB/+GmD
6mjh0pGZJIpobOWaEup9rdWTH5f1h4r1ZexmHkULMKt5zEFzJRl1FaPHKMSuR1Da
27cI84YlwOSYjnkeOkdZqadHGPd1OfToepuc21cbG4RzDZoDkqWrGDrFZLgQAZAu
uhqjp7sQXuFyKEtW8EzdIedsqVUWHNwzm9l1O0uFGdHAzTF3hl7Lgeeuy+giqAN9
vnScZzfZHgjEmnNMRjpxYPAPJSOFLO2mqm8zsxT3pQ8JaFVyQncLEYZBtZzUtdim
NVfWQEEsLuunYDQlyCNboSKRBjNaUsoLq2RoJ80nxM79XFH69CKAN8eU6Ls+lhoJ
5kFP+90L2ZEaLVOY9hqdTlq7qEQ4N6aW/NIfv+TXzIe6mpoujDtP8SpQlK6gaygi
oihjrfiAm2gQ5xV7DgSnTTrYrFc+k6OKD8nQ5RIf22LB8/Z2s1hT+MaVanyuopEL
SJuJb6+UfjW3WT28miMYyMeVX2udXPU/TOCNTojJZJEtj4WXIsxsQU1P3P9mWlRU
WxL/RJf+ZBnihXkqKb9fLMecWOUxSYTgrtNgrKlPU14LJRUtyvg=
=8QKJ
-----END PGP SIGNATURE-----

--YbB80Sw7nEz6NLED--