Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leckr-00030p-9Q for pgsql-hackers@arkaria.postgresql.org; Thu, 06 May 2021 12:05:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1leckq-0008B9-3T for pgsql-hackers@arkaria.postgresql.org; Thu, 06 May 2021 12:05:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lecko-0008B1-Nw for pgsql-hackers@lists.postgresql.org; Thu, 06 May 2021 12:05:19 +0000 Received: from [66.111.4.26] (helo=out2-smtp.messagingengine.com) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leckl-00039v-Lp for pgsql-hackers@lists.postgresql.org; Thu, 06 May 2021 12:05:17 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 717DB5C00F2; Thu, 6 May 2021 08:05:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 06 May 2021 08:05:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=tPP6U2iWlXBqIKRJJx4GBPGtrsA bPDHp2ygmK6lTB4M=; b=Ovh1u7tw0k5DjqRg9cA+JtrOUzgF/H0fmL8W38ISPgx aXPKUkV1UKRDMsTMbCmEfQDBoe2jkkFTX+DfkTWS41Dmfux0Osjxj/oY/3iJr6RZ NARFAKHBHM3dxzL3IVWPsy6HdghZf4kVDb8AjgZUgRqkQeYFNeAA7yEmTKddatvf n+hztMjngf7PEIcNOjMHjbPxsjBQOuU6fixvl5pnKPuuv6Xuc0G6+3N2i8frGsGP tSy8jzNsCyHDZHpotbTmZGex8Oozcpcqbvvmoji9LCjm5akqNjVfUO9DwPJ1tlOS qwGslTdRboS8yokPpGwV9B9hAy3bOvlnEzmQ4R59WgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tPP6U2 iWlXBqIKRJJx4GBPGtrsAbPDHp2ygmK6lTB4M=; b=Gu0lMZgK42RY2Ou1oVJmkF 7mgNq10VNflcXRkVa5pFJLsPnAAcohbApVHbK0YeSR/L6H6yAxKMAeAhFH8L6RvZ Eo5u9nQvVGzZUMs+flsSdD6DkpJwZyyIAy3JIXKSP0dWqyJIp22EfOw05z15TqKV VJe8K4lwWkUfXpWfGWcnDCpPbcmZFs/B2fiTx5+yytvyMpwB5VqscFYr9sl6ppKO h1C4sZjK+wb/fFkHSgtCgM8KLmVwvuVYZU25Xbk+ScIgeu3f9PVk5J2jL1kY/++i SZtSaD79GYlGTYn6J/it7f4wEdzLV2YV8GOrJcKeQhC8z1OB7iO1jb4Tk0Zl8vmg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegtddggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucfkphepudduuddruddtvddrudektd drudekheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 May 2021 08:05:01 -0400 (EDT) Date: Thu, 6 May 2021 21:04:57 +0900 From: Michael Paquier To: Dilip Kumar Cc: Robert Haas , Postgres hackers , Jacob Champion Subject: Re: Small issues with CREATE TABLE COMPRESSION Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="G6K7xeF49pODS12i" Content-Disposition: inline In-Reply-To: X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.26 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --G6K7xeF49pODS12i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 06, 2021 at 05:01:23PM +0530, Dilip Kumar wrote: > I noticed that the error code for invalid compression method is not > perfect, basically when we pass the invalid compression method during > CREATE/ALTER table that time we give > ERRCODE_FEATURE_NOT_SUPPORTED. I think the correct error code is > ERRCODE_INVALID_PARAMETER_VALUE. I have attached a patch to fix this. Yeah, I agree that this is an improvement, so let's fix this. -- Michael --G6K7xeF49pODS12i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmCT22kACgkQnvQgOdby QH3NGg/7B2294nPvbZIn1dk/Zkhuz0K2uhSsI3vSoq28nSf//anR4um96gmuZ9wx a88kLBLJ2v8Hp9CIA5yKbiGtxMZM0HHzyWqmx1HGgfgBHzUAT2LP1LhOW+T+1bhY vrNJNRk+pkrf3JHXsAVUMtlA57WOVUTh70SR2DnI94iywSr3pBREbPAdTlghQJCI kUsOheeL8tt//LtbL+XlQBytrOau6PD2hecIzNIwe3ky1daUZhAdRc9F+f1vytP8 qT7Aw/rWRgSYKwANtPaReBK83OSUfnqHxOoCe6cQTW0M8hDn/ClCnTZHaMV82dtp g+5ve9uDQ5jXE34SadpCs6wGByceUmsjiZQFAnw5KDc1qTb7lCTqHJEGdbXyO4qi bTqP+LzBqNFxW8KkJ1LVaS9xd7zNilJQ7pl5JaJeJpr8rS0HPB0DJNxE3MXFRwwA 3vkcV0x+FFVHU1htJcyHf12782KzIp+kE45SoQiljCxFo74qd30CuBp3rYAxiTnb 3DWSatzd21JU7+JBn9b+SesWqoz3K8irI19OgwwkS0bBRq+eVGmWYNiQ5/m05nXA IPX8facOze0a70AuACMx/H2voXOfTmmk3l+W5QxubcVw9OtNF2grMCCUmXNRCVoW OF4pJa97CxSYE/mYRP96W/zTb/6AxpDUVHaDEyO2kYymZsicF+c= =KL10 -----END PGP SIGNATURE----- --G6K7xeF49pODS12i--