Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lecsD-0003Cx-QM for pgsql-hackers@arkaria.postgresql.org; Thu, 06 May 2021 12:12:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lecsC-0004ny-LK for pgsql-hackers@arkaria.postgresql.org; Thu, 06 May 2021 12:12:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lecsC-0004nq-DR for pgsql-hackers@lists.postgresql.org; Thu, 06 May 2021 12:12:56 +0000 Received: from [66.111.4.26] (helo=out2-smtp.messagingengine.com) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lecs9-000117-Ms for pgsql-hackers@lists.postgresql.org; Thu, 06 May 2021 12:12:56 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 1AA355C00FE; Thu, 6 May 2021 08:12:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 06 May 2021 08:12:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=hsSlS7YEuI8kaJACaWIzPu032Fr h6JEX53uaQCQpH2I=; b=YNZ3C+irQH7w3xIYkx9BRvssYW1cbvuerMSynIAKYdD r1JAZI55JZGcPvUj5MNgkUzdgJKV4ThBp/QzhpkGmLQqzHsSaMiPguj+9RHnm2Pj EyXpAGaAiptetmvUWzaGmfOatT3ioZ3MVJCyQRoGBJsUuDJR6rT39kZDNESpVmSc GXb91XEN7dGd7Fy4Cqi23O70XllljidNuZv1U0J4BLSuKuy6UC0N17mMeB9mlnNK T2n+f8xi8eLc2D3K69QIHSUWr4oHStM9EGOnjtD/z8+hceRMMPIMrxUZ6rMGk46m cqOUG5Pmsd0clEowS8FuIDr4pM1rbN3MHVftyFxzDfA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=hsSlS7 YEuI8kaJACaWIzPu032Frh6JEX53uaQCQpH2I=; b=otJIXqcUlltvxHbr2ChBfH lvxblw3IUIADggt3vaPGhm5xXUcAva5gWugwv6I6aMjvbRFzlOaZRUfsG0/fLEiA q7g0Z/3MOyb5NJ57ZNdSVS27KIT/u0EbuPaLhweA4z3/mYN45A3SI083st/sJvNw /K5mBbuBzneZ2wVYEp4obcLdoZyjD7qGon6LCiQW4CaFvbMW3cN/ejlIJ8YxMFGS xzHglx/h+W+z2JD/pZJZZ3Ag2GwWUaFaORtVtMOO3ZdIJdXRPgJ2tUw8vXkHFiFa vm0CrXaoUjcNsGvV3Q9bhW9MZQkHcMAP9NGeiH8n5iCf5mTIL69tYUBUNjLO4W3A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegtddggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeetudfgteeuleethfdtfeeihffg tdetffekieelieeijeejteethfejtdetfeefkeenucffohhmrghinhepghhithhhuhgsrd gtohhmnecukfhppeduuddurddutddvrddukedtrddukeehnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrh drgiihii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 6 May 2021 08:12:39 -0400 (EDT) Date: Thu, 6 May 2021 21:12:37 +0900 From: Michael Paquier To: Dilip Kumar Cc: Robert Haas , Postgres hackers , Jacob Champion Subject: Re: Small issues with CREATE TABLE COMPRESSION Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yH6I6mJYTHZGTYdS" Content-Disposition: inline In-Reply-To: X-Host-Lookup-Failed: Reverse DNS lookup failed for 66.111.4.26 (deferred) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --yH6I6mJYTHZGTYdS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 06, 2021 at 10:45:53AM +0530, Dilip Kumar wrote: > Thanks, Robert and Michael for your input. I will try to understand > how it is done in the example shared by you and come up with the test > once I get time. I assume this is not something urgent. Thanks. FWIW, I'd rather see this gap closed asap, as features should come with proper tests IMO. While on it, I can see that there is no support for --with-lz4 in the MSVC scripts. I think that this is something where we had better close the gap, and upstream provides binaries on Windows on their release page: https://github.com/lz4/lz4/releases And I am familiar with both areas, so I have no helping out and getting that in shape correctly before beta1. -- Michael --yH6I6mJYTHZGTYdS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmCT3TUACgkQnvQgOdby QH1kig/9H8hPVPTy0zTsxL1eemv/M3dHq/QTpJGApBzR+rtTAm2mIJ6okAiLsMla ewAKoJThTIkGdScrFPZJwl5I6TY2iKkr4/enPeOwi4wa7cesW+7xxk03Ps1vHYzy C//DOIWIARKnQH4rTZqtmfvGFOFGOyJZfSrPvmFeeXtxlWiBFFto7QMxh13CMwLA 9THOWClWhv3JkJfIhLS9Ce0bR6lrW8s13JqH7imGcd0S8jNEQLejXAe1yuL0kYLL iU2SSxcU1wlaxbyklVv1BtYMBGiRpcPKdH5iDWuhxjVhtEKRgZ/PDr/N+1+AIp9l Jl2byBGqnisC4bSmLmIwcjw4evB9qF3hJxO1cHvH+A2DhbnxcIpIEj8kMMH+zGKV exEjGP+8J8wV3qoxOwOmpu3a+TrqzWjqdHxyWSqQ7JRmC+UC2ZhPMCtZgc1YwTFw JZrYMwtIms8wFH1r4liWZwgImoKZ8zugfpFpjOslmuSWDd+0TsADAukW1h2Cps6P Rlx65lfzZfrwrP4UChSTHmZe2PEcfYzdgLLO9UqidLg5ENbMyIvYdJ/1dcRKv7yA 3SE78EvLJdYnu68LvgqSYxwP5Bjaz1ssEuAdE4D2qGPWR598V6GxZBrmVMma5Gyg RGhGqlc64cL8ONQ4SVZ5s/kyZYtcXAKbYIhRzgQYDA1BqCJxHSA= =VMFR -----END PGP SIGNATURE----- --yH6I6mJYTHZGTYdS--