Date: Tue, 11 May 2021 15:04:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Stephen Frost <sfrost@snowman.net>,
	Magnus Hagander <magnus@hagander.net>,
	Bruce Momjian <bruce@momjian.us>, Christoph Berg <myon@debian.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Message-ID: <YJoeXcrwe1EDmqKT@paquier.xyz>
References: <2268611.1619458140@sss.pgh.pa.us>
 <20210426174331.GA19401@alvherre.pgsql>
 <20210426181408.3j6kkzpxnadpwptv@alap3.anarazel.de>
 <2295572.1619461260@sss.pgh.pa.us>
 <20210426183745.4gd2s5qra6mlxfto@alap3.anarazel.de>
 <20210427062504.ofz3rgedbrl5bep2@nol>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="TquwYuHOpE5jU7nf"
Content-Disposition: inline
In-Reply-To: <20210427062504.ofz3rgedbrl5bep2@nol>
Archived-At: 
 <https://www.postgresql.org/message-id/YJoeXcrwe1EDmqKT%40paquier.xyz>
Precedence: bulk


--TquwYuHOpE5jU7nf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 27, 2021 at 02:25:04PM +0800, Julien Rouhaud wrote:
> On Mon, Apr 26, 2021 at 11:37:45AM -0700, Andres Freund wrote:
>> On 2021-04-26 14:21:00 -0400, Tom Lane wrote:
>>> That's sounding like a pretty sane design, actually.  Not sure about
>>> the shared-library-name-with-fixed-function-name detail, but certainly
>>> it seems to be useful to separate "I need a query-id" from the details
>>> of the ID calculation.
>>>=20
>>> Rather than a GUC per se for the ID provider, maybe we could have a
>>> function hook that defaults to pointing at the in-core computation,
>>> and then a module wanting to override that just gets into the hook.
>>=20
>> I have a preference to determining the provider via GUC instead of a
>> hook because it is both easier to introspect and easier to configure.

So, this thread has died two weeks ago, and it is still an open item.
Could it be possible to move to a resolution by beta1?  The consensus
I can get from the thread is that we should have a tri-value state to
track an extra "auto" for the query ID computation, as proposed by
Alvaro here:
https://www.postgresql.org/message-id/20210426174331.GA19401@alvherre.pgsql

Unfortunately, nothing has happened to be able to do something like
that.
--
Michael

--TquwYuHOpE5jU7nf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmCaHl0ACgkQnvQgOdby
QH3skg/+IkA2kZW/b/gnDfLKjUmKtGuSYkADO1YFN17va1vh2oFq12ruZmspFy5R
9yc8Mhe8gKMq9C5kJ8anxf9uhsNs5B5lh7Bj6Imne9D0nImexD6GSzTxofFgOZU6
Nngek2qk8VNhZt21f1OQQgtG1Ltko9ZjbFEGfc7djB76Lsv5oYWkP6DiI8IjzuUD
Htl4XUWxHMv+N3llNIRE6QVLdQzByLqcTp6VpiOSp2SyeW9NNeHUalvjWCTWdr4R
vxXB/KYCr/snAh5bBg4F4D+6iiio28GS6OWvsR1BOXr0mo96WSjhEkwvY7uZk95W
Q6UHouPdRLvEhuq+NuztjFllR88mG3zCc2sZbIKl3LilyP37rZ6G9Fbqfoli6PzF
dbtm//jJs25phzgWIlNm3zeUTl6Ir5dcMj0J6k9GfOkDuufi1lm7nDyXBrUZUIbw
vnHfzbzNyVAXSAPii1r2OQAgWijwGWSPGK7vDfwTgRCYTC4cT6BkTfdJb3xuNlDN
Mk1cX0h7OQMsmFM7/kJeHEXraKJgrVXD9pnSMFtdnqOtMtjOf3mELqhk1LAd4ETO
yMS0KRNT07F8CYoxFQCEM3zUtQ98ZyZ67zkzVQxIkvjIGvD2QWqnEUOTtrKPHADQ
yAPuVicXGyM2CcjmfDEZH4fNAowNNikDSoQ9iMwbJ3/R08jgtLI=
=ke9A
-----END PGP SIGNATURE-----

--TquwYuHOpE5jU7nf--