Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ll6Lf-0001vt-BL for pgsql-hackers@arkaria.postgresql.org; Mon, 24 May 2021 08:54:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ll6Le-0005K6-9m for pgsql-hackers@arkaria.postgresql.org; Mon, 24 May 2021 08:54:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ll6Lc-0005JQ-T2 for pgsql-hackers@lists.postgresql.org; Mon, 24 May 2021 08:54:06 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ll6LX-0001N3-No for pgsql-hackers@postgresql.org; Mon, 24 May 2021 08:54:03 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 668B85C0101; Mon, 24 May 2021 04:53:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 24 May 2021 04:53:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=Ks9Nh9B8Kt5sfEZpMolZTghNGdC GBMTBkIhAV2L/8Ak=; b=IhLHWXFUeQY8QArrydpdyfkAzFYEMAj7gqvYA45hOah kD6ANBOPJ/8JHoNRfVnoUXw9wHnaNyUj2pGORnUhSrBRWy7gzCZEuKkefgBUt3N1 NfXQ74fq2a9fwC1XGTXxohqAaYswH2/1s2zUBt0NQuDNxMRDNBN9Q8rZq7TEOqKZ HSzLlug2ML/RlQeH7pLunilqoAi+xbIrJMXEY0UTvUEz4s7eU01euuBFqR0FB07F Tq8Z6FhCYEVCpMrtNaow/O6vk4XbI6x3ytC8oTkorrfZVB8hEMoDSstmsioUiqL/ sIOHsP1jE+vraKgV4xlTpJLj6w0Ej1psqjShFEDQfwA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Ks9Nh9 B8Kt5sfEZpMolZTghNGdCGBMTBkIhAV2L/8Ak=; b=Dm030VSc3V+ZAzwKVffS3+ ZJ1Tp9iIBwf2vR64Xd51URJJbvteWW6DG3V3oPDC8rJZqsLnZZJy1Mwg0unDYFUy f/19hoJ4OnjSBDTSprzHw3C64f1h0Co9SRXpHWu9XiCWESkC9+ZZuMNdYTbKKurz TpTnk6bApZLpsjb2/O0Z+DkztecwGymQf235BTxwrzlEVbXbqsOw9ZulU2E7RLHC AwR2qKXhmr0WmKE/+6T53KnATO4o2peFfdXhPRvgEDO4OzTK4FNvOf0LYYLXXY00 GUPzSq+GUzzCiaT67X/47KJhlwGKqbN/2XO0GrJ0kb5H1mGyfaDH60ON6x8rZJIw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejledguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucfkphepudduuddruddtvddrudektd drudekheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 May 2021 04:53:55 -0400 (EDT) Date: Mon, 24 May 2021 17:53:51 +0900 From: Michael Paquier To: Dilip Kumar Cc: Andres Freund , Tom Lane , pgsql-hackers , Robert Haas Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size? Message-ID: References: <20210517204803.iyk5wwvwgtjcmc5w@alap3.anarazel.de> <2854987.1621285592@sss.pgh.pa.us> <20210517212857.qyk4fxykfbxhmxof@alap3.anarazel.de> <3962395.1621609263@sss.pgh.pa.us> <20210521211929.pcehg6f23icwstdb@alap3.anarazel.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8Lp/Rnetkr8iszfQ" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --8Lp/Rnetkr8iszfQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 24, 2021 at 11:32:22AM +0530, Dilip Kumar wrote: > I think you don't need to initialize tup_values[i] with the > values[i];, other than that looks fine to me. You mean because heap_deform_tuple() does this job, right? Sure. -- Michael --8Lp/Rnetkr8iszfQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmCraZ8ACgkQnvQgOdby QH3VhBAAiVl0HUvwFJkC3HZARdig80C1DuyQPCD7sZw5h+F9pBtvEOuUPorHNSKk JlylOHb7dB5WQC3whppoEipPTAPOeLuN/jQjoteR4pYSbZiZPZ8XxMgM7at6BGK5 tKf1YfqK4inD3QX13sHif3ymfnnsGD0c35H5xJOJ5stFQ9nxeQQ1s/vkzKyf+XO8 hXnLywqBGuX8Qsb25H/o1KqnHKtZTEc07ey1h+l/q+WdmcGvjl702mBsmalQw4Qr eYhl65i1YEtyq/c8LlDAJFolKGsdUPV6VBJNhFlUufPQ68lxtJ6gVLERk869108R pYra5VmuT3wKoORDbGCp8fvwUjpRDAXPTtfLYRQctYco22qFHeB6PqjAEwPioHs5 93Kiybla0BBVW2XIhOu21gSHhArHJWR6Hmezn6udixPIeYXyIjUTTzzrb4uCu/bt juG8i3ikrYojFsOIyKeS+ngpYC72xCkMRiNyvh19LYWRERIE64ElkX5K1CqAH5DI 7zy75GpMsknDfbEtPYhQztNLxNha7JFHVT/4U0UvUXhTwugRp2GEVVJVLxMwTf5U X084PYuFjVETl2mhUqi7Ly8A3pK6jFYURgwLh72wZ9d/SjiKfTTSRghdJogy6oF6 PtSjH4h0wKAs5a1o31FjcMrNt2NCZiBK5PbLs5SnDsBF/+syShs= =pKe9 -----END PGP SIGNATURE----- --8Lp/Rnetkr8iszfQ--