Date: Tue, 25 May 2021 16:26:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>, pgsql-hackers@postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>
Subject: Re: Different compression methods for FPI
Message-ID: <YKymshLnYZeD0cue@paquier.xyz>
References: <20210312074547.GQ8796@telsasoft.com>
 <20210313012820.GJ29463@telsasoft.com>
 <BEF3B1E0-0B31-4F05-8E0A-F681CB918626@yandex-team.ru>
 <20210315003135.GL29463@telsasoft.com>
 <20210315180918.GW29463@telsasoft.com>
 <20210321193004.GA4203@telsasoft.com>
 <YKIelANwse+k2JxT@paquier.xyz>
 <20210519030618.GS373@telsasoft.com>
 <YKTa4+kTFkb3EIBs@paquier.xyz>
 <20210525044444.GV3676@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="cpeMVHN94x3lMAfz"
Content-Disposition: inline
In-Reply-To: <20210525044444.GV3676@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YKymshLnYZeD0cue%40paquier.xyz>
Precedence: bulk


--cpeMVHN94x3lMAfz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 24, 2021 at 11:44:45PM -0500, Justin Pryzby wrote:
> The goal is to support 2+ "methods" (including "none"), which takes 4 bit=
s, so
> may as well support 3 methods.
>=20
> - uncompressed
> - pglz
> - lz4
> - zlib or zstd or ??

Let's make a proper study of all that and make a choice, the only
thing I am rather sure of is that pglz is bad compared to all the
others.  There is no point to argue as long as we don't know if any of
those candidates are suited for the job.

> This version:
> 0) repurposes the pre-existing GUC as an enum;
> 1) saves a bit (until zstd is included);
> 2) shows the compression in pg_waldump;
>=20
> To support different compression levels, I think I'd change from an enum =
to
> string and an assign hook, which sets a pair of ints.

Hmm.  I am not really sure what you mean here, but let's keep that
in mind until we get more performance numbers.
--
Michael

--cpeMVHN94x3lMAfz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmCsprIACgkQnvQgOdby
QH1ZRQ/+OXj22MG+sKtxJqfxGfsR6r9I9WVVx9Qszm+xmietJYmwcPd0QY/xAGgd
qld+Ogwz4ln298hxJobfh81C3aiBfIeXzUjVmpw0nbhX9FXWraf0n1JunCOzXET8
Zgu4ziu3aAXa1Oyd85HDXcjo8qjUkybLCMqBVb+mH3a40/GZWvWn17QGiDi4499d
gM+CJ1ZmXBe+IZVhbjqM26qCry/We0JZToBW3phbm3LyjiNaaE7V1iFjrZOgIl9J
5oLMHOI8zLtspMP5m2393b+ywp2pXWXQKYw/S/UAGGkYPXgq6RU2NxZM7v8lwdyy
/fjUBtmS3j3srTAAVCG6Kc6gNtJSnBb35ALOE3/92R5/6wvTX5WueI0Ishes8aEF
mGPDE9cyh9RsnhUaO/hbhja8whl48qJNJzeTPWWReZDak2Kae/IBQWoHntZ2ENIb
ui26vWwLqLI5G+yqZlbEWEnzCbKz5RutpGoQY8QLfXnT3r6KJMgrSpcOhD9Jy4Vw
82jxfvKh/a5AZwVIUafXrMKk8U4skXnOL8jheRsWWuxuDqSK+jyxb1L/A/i5I6Xj
jSy6iUD6lvc14RTw57HcdpG5dspcC+i6qZtQPZYjoMBlr/5xrJEqH2c4iF6WrNVd
aiRNAETs2yeLpM0Ft+bLb/djDbYkTNO5s2T8Ce5PXCWJLf5WGbA=
=XNYz
-----END PGP SIGNATURE-----

--cpeMVHN94x3lMAfz--