Date: Tue, 1 Jun 2021 16:34:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Hubert Zhang <zhubert@vmware.com>,
	tsunakawa.takay@fujitsu.com, pgsql-hackers@postgresql.org,
	Andreas Seltenreich <seltenreich@gmx.de>,
	Bruce Momjian <bruce@momjian.us>
Subject: Re: Multiple hosts in connection string failed to failover in
 non-hot standby mode
Message-ID: <YLXjFOV3teAPirmS@paquier.xyz>
References: <20210506162651.GJ27406@telsasoft.com>
 <4170264.1620321747@sss.pgh.pa.us>
 <20210531012500.GP2082@telsasoft.com>
 <YLRDV0MqQnGRIo4c@paquier.xyz>
 <YLRZH6CWs9N6Pusy@paquier.xyz>
 <2522602.1622433912@sss.pgh.pa.us>
 <YLSCrAPVfxX3X8ap@paquier.xyz>
 <2566986.1622468180@sss.pgh.pa.us>
 <YLWFzzrUIy9Q8h1d@paquier.xyz>
 <2732890.1622509658@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="NWp81HeZ+ss+ncxV"
Content-Disposition: inline
In-Reply-To: <2732890.1622509658@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/YLXjFOV3teAPirmS%40paquier.xyz>
Precedence: bulk


--NWp81HeZ+ss+ncxV
Content-Type: multipart/mixed; boundary="CHmk0yTx0aqSmfx/"
Content-Disposition: inline


--CHmk0yTx0aqSmfx/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 31, 2021 at 09:07:38PM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>>> Agreed, that seems bogus.
>=20
>> There may be others, and I have not checked yet.  I'd rather do a
>> backpatch for this part, would you agree?
>=20
> +1

Playing with all those variables and broken values here and there, I
have been able to break a bunch of tests.  Most of the failures were
in the authentication and SSL tests, but there were also fancier
cases.  For example, PGCLIENTENCODING would cause a failure with
pg_ctl, for any TAP test.

I got surprised that enforcing values for most of the PGSSL* ones did
not cause a failure when it came to the certs, CRLs keys and root
certs now.  Still, I think that we'd be safer to cancel these as
well.

Attached is the list I am finishing with.  I'd like to fix that, so
please let me know if there are any comments or objections.
--
Michael

--CHmk0yTx0aqSmfx/
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="testlib-envs.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm
index d6c3eb8723..d4f9fc5f2b 100644
--- a/src/test/perl/TestLib.pm
+++ b/src/test/perl/TestLib.pm
@@ -104,13 +104,30 @@ BEGIN
 	delete $ENV{LC_ALL};
 	$ENV{LC_MESSAGES} =3D 'C';
=20
+	delete $ENV{PGCHANNELBINDING};
+	delete $ENV{PGCLIENTENCODING};
 	delete $ENV{PGCONNECT_TIMEOUT};
 	delete $ENV{PGDATA};
 	delete $ENV{PGDATABASE};
+	delete $ENV{PGGSSENCMODE};
+	delete $ENV{PGGSSLIB};
 	delete $ENV{PGHOSTADDR};
+	delete $ENV{PGKRBSRVNAME};
+	delete $ENV{PGPASSFILE};
+	delete $ENV{PGPASSWORD};
+	delete $ENV{PGREQUIREPEER};
 	delete $ENV{PGREQUIRESSL};
 	delete $ENV{PGSERVICE};
+	delete $ENV{PGSERVICEFILE};
+	delete $ENV{PGSSLCERT};
+	delete $ENV{PGSSLCRL};
+	delete $ENV{PGSSLCRLDIR};
+	delete $ENV{PGSSLKEY};
+	delete $ENV{PGSSLMAXPROTOCOLVERSION};
+	delete $ENV{PGSSLMINPROTOCOLVERSION};
 	delete $ENV{PGSSLMODE};
+	delete $ENV{PGSSLROOTCERT};
+	delete $ENV{PGSSLSNI};
 	delete $ENV{PGUSER};
 	delete $ENV{PGPORT};
 	delete $ENV{PGHOST};

--CHmk0yTx0aqSmfx/--

--NWp81HeZ+ss+ncxV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmC14xQACgkQnvQgOdby
QH1maA/9HdL8/cqlKZ9DWMPLKfOcpyw3aSUlfFVc07eEiYH712KJC1OnHOA6feyj
W7ECtKjIjZDekg5iE7jXPuNid7DqzITlf941U8FGicsgnYElHux0CFUQQanVhsxf
qieBaeuqhYi7Nu9bnNu4pis/IqZc7mVHizzC0u+P384B+1s7sGtoq/73E3lJaSKS
c8/uoQPEMTChu2nptmnXUGpkjIG1EWSsfAANmJvyjsmfP7giu3HmdMq0ZowBPTqg
+HKgDYSw7C8LJoLFAn1jk8MQeYRwnovhvc/U5GECxtAQOKpZvP29MLUOwdg3enkf
PZKoQit5HpkvZYLC3KkwCBEhNElwjyGSG2p3XbnOS+XJSbMpdRcQdNtoJxnudPeM
32W8f2KBcFQ+f9YfUFS3lYMuEc19Yv4dE3Ch8TwaF2kGG8Z3hLwLrHnkAxN4Ek6v
1AKIwW9DQ4Nc/jshgjADXImQXbTRetaAM/WILOep8axHOeU3LUXzPdxzWiHJmrYj
2yTOWhQ5jyyrePAkE8FiodhDjJVwv7xAQ5oWCS71PPjN0zVIwUtjXsB6U+0c9Wlo
P/cMP3iKNQwg+G9ecp0Ozlfq7eXEB89yqUyXciWP0hpMon3pbss4chDcBqqKlyer
JmXJzKfSJvLAVoAyvMb4I1P4FFViE8Bgc3U+gVKuTvjjJUUYc88=
=IKRO
-----END PGP SIGNATURE-----

--NWp81HeZ+ss+ncxV--