Date: Wed, 2 Jun 2021 10:49:01 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: TAP tests still sensitive to various PG* environment variables 
Message-ID: <YLbjjRpucIeZ78VQ@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="0+KNRyzaI3GCRHTj"
Content-Disposition: inline
Archived-At: 
 <https://www.postgresql.org/message-id/YLbjjRpucIeZ78VQ%40paquier.xyz>
Precedence: bulk


--0+KNRyzaI3GCRHTj
Content-Type: multipart/mixed; boundary="8lpeIHikvNR4yGX1"
Content-Disposition: inline


--8lpeIHikvNR4yGX1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

While looking at a separate issue, I have noticed that TestLib.pm is
lagging behind in terms of environment variables it had better mask to
avoid failures:
https://www.postgresql.org/message-id/YLXjFOV3teAPirmS@paquier.xyz

Once I began playing with the variables not covered yet, and tested
fancy cases with junk values, I have been able to see various failures
in the TAP tests, mainly with authentication and SSL.

Attached is a patch to strengthen all that, which I think we'd better
backpatch.

Any objections to that?
--
Michael

--8lpeIHikvNR4yGX1
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="testlib-envs.patch"
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/perl/TestLib.pm b/src/test/perl/TestLib.pm
index d6c3eb8723..d4f9fc5f2b 100644
--- a/src/test/perl/TestLib.pm
+++ b/src/test/perl/TestLib.pm
@@ -104,13 +104,30 @@ BEGIN
 	delete $ENV{LC_ALL};
 	$ENV{LC_MESSAGES} =3D 'C';
=20
+	delete $ENV{PGCHANNELBINDING};
+	delete $ENV{PGCLIENTENCODING};
 	delete $ENV{PGCONNECT_TIMEOUT};
 	delete $ENV{PGDATA};
 	delete $ENV{PGDATABASE};
+	delete $ENV{PGGSSENCMODE};
+	delete $ENV{PGGSSLIB};
 	delete $ENV{PGHOSTADDR};
+	delete $ENV{PGKRBSRVNAME};
+	delete $ENV{PGPASSFILE};
+	delete $ENV{PGPASSWORD};
+	delete $ENV{PGREQUIREPEER};
 	delete $ENV{PGREQUIRESSL};
 	delete $ENV{PGSERVICE};
+	delete $ENV{PGSERVICEFILE};
+	delete $ENV{PGSSLCERT};
+	delete $ENV{PGSSLCRL};
+	delete $ENV{PGSSLCRLDIR};
+	delete $ENV{PGSSLKEY};
+	delete $ENV{PGSSLMAXPROTOCOLVERSION};
+	delete $ENV{PGSSLMINPROTOCOLVERSION};
 	delete $ENV{PGSSLMODE};
+	delete $ENV{PGSSLROOTCERT};
+	delete $ENV{PGSSLSNI};
 	delete $ENV{PGUSER};
 	delete $ENV{PGPORT};
 	delete $ENV{PGHOST};

--8lpeIHikvNR4yGX1--

--0+KNRyzaI3GCRHTj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmC2440ACgkQnvQgOdby
QH14SRAAgC2OnUAUmwGiD/Qo4KCRnzx+sefHPFF+9sT3zroXgQCPP31dAxV3YZTF
fpeaA3KxsRp/OwU9r6Rw0nDKsVkwb4e5JsCJrn1+4ql1n0txiY8hy0OXyDxbtKfH
fk6jU0c47+G2SNOrKwiC1KnjMJMKClyygU51umyutLTJ+nesTiApxd9Xspcx+7yv
90sPofFldSTqf738mB41d9FhHsYqSkqrdvTllt8tQC2u/ZVn9mxORQ50HLUU4S20
2EpfZa0wBwuGqELtk9m9Q6XlC8PdL5+1zxncCEbi6xGXlB3ClgFV8OC8pWGi/HDB
ne5pQ+l4qLPUkDbbIspx51cMMb+DhLwcIiMy4qI2GCOb6hXPCPIX78af9vR5+IC3
RTvgH+p7I8yP3MVwn4TVKPOJaUxzJTfySkBMUsYLCp/opTATgJuBOFO4BqKV0Twy
p0715w6AuMKhypWcwvKxLorweGU0RcHwdyizX2zL9wyVnAduUkySQnpjIxBYvA+U
zquNxBor+krYAsJWZ0osSJZdNWQ37vbIplGmNl+AhJMffmLZoz69NmBRvh1+hJ5d
LU3jf4grNshAx9sMU6TJWflh6wYxvGXjibszkE7Sn6/Kh2DgeedwsJs/sdJ5lnj4
ZiyQ5Wx0pQeY+8vQmNE5/dFCXrkJGkKnmSuy8A9IKtO0JiBkOM4=
=IdyF
-----END PGP SIGNATURE-----

--0+KNRyzaI3GCRHTj--