Date: Thu, 10 Jun 2021 11:02:04 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Zhihong Yu <zyu@yugabyte.com>
Cc: Jeff Davis <pgsql@j-davis.com>, Justin Pryzby <pryzby@telsasoft.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Jacob Champion <pchampion@vmware.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	Ashwin Agrawal <aagrawal@pivotal.io>,
	Ashutosh Sharma <ashu.coek88@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Robert Haas <robertmhaas@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: alter table set TABLE ACCESS METHOD
Message-ID: <YMFynNmWfxUScsXu@paquier.xyz>
References: <35333ea26e52252174515e14671a9fbc1c20c8fa.camel@j-davis.com>
 <20210506202305.GQ27406@telsasoft.com>
 <1033d6b4b5b42a014cc3f617265ae6e61cb5781b.camel@j-davis.com>
 <20210506221943.GS27406@telsasoft.com>
 <3bee08c2ca0fab15d14899afcb19490f29e0ec6f.camel@j-davis.com>
 <803b32e45baf0b05e5f3fc144383db3a18081693.camel@j-davis.com>
 <27c94b85d966351e2715cdbf79cb4c658b3cfaa7.camel@j-davis.com>
 <YMBH1nt8XXi8l7NY@paquier.xyz>
 <d47f55de936b6808e5d5e3177b410d1e0909faa1.camel@j-davis.com>
 <CALNJ-vQV32U7QpXWMbuHHxhB1eEBaPgZtvWGVbiwubRpO-AFKg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kzeKxiYiaJmRAb8p"
Content-Disposition: inline
In-Reply-To: 
 <CALNJ-vQV32U7QpXWMbuHHxhB1eEBaPgZtvWGVbiwubRpO-AFKg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YMFynNmWfxUScsXu%40paquier.xyz>
Precedence: bulk


--kzeKxiYiaJmRAb8p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 09, 2021 at 01:45:52PM -0700, Zhihong Yu wrote:
> +           /* check if another access method change was already requested
> */
> +           if (tab->newAccessMethod)
> +               ereport(ERROR,
> +                       (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> +                        errmsg("cannot change access method setting
> twice")));
>=20
> I think the error message can be refined - changing  access method twice =
is
> supported, as long as the two changes don't overlap.

Hmm.  Do we actually need this one?  ATPrepSetAccessMethod() checks
already that this command cannot be specified multiple times, with an
error message consistent with what SET TABLESPACE does.
--
Michael

--kzeKxiYiaJmRAb8p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDBcpwACgkQnvQgOdby
QH3oNg//RIpPzvapcjoKailXCyPiCYJnObalChs3j+Z7DF6DV16c1orsvKHX8jHK
j24QN2R/CJXlAiE4jNHhwFScGNRaj/ZSFs9JVcV3qxTyRGZQF/ZHiXgt257/ORp0
iplfCEdZGooHsXYVfJLVhcmuENsXLo1mnOPsfJEDc+q2Ykz/wuMUtTMfKc8PDhNN
d+vZvk0UYREUdaOY0BOeuEixyTz87dhy3wD0YmihX3iQ1ij+mSDTy8Hr5RE8bfG9
0d1YGlLIGU2TgYiTlDFhOjqjUxtkE9GQgbIooM2tavmUgxJjguWgOX1UasxZr6Fz
gcrcba3RxW75cTik6UlO+IzRCkEK9SJbz5shG2Aj8/5UDVZdRnLXp7n//xPFeRfY
y8AoTxhv0biuwIA37jEE1JFWRtmSFORa/PaeVeGhE1Zd8O0ea640RUdrwq4hebWs
0XVs901vmcYh56n6d1ZWpyHEYS4TgyqGqtfyBGD8kPs+KHbX2dsOuE8ESHPO2lSy
1Caq47143VGwuVKZLFb8zM3PMNGY0uTKpOaNdWSmK09QtcQY5T/Q7wu7X5FA+P4Z
SSrE0WF8cSvdHnUCS90ErS1Kf2P2TsDH4Z6mEja5w99QbRzS/C3jisfKqxltvib0
eqB9W00zB64Pgai1WZkUKhiA7xZjykoqfleNrLbs9nt8VbkLZHA=
=avu0
-----END PGP SIGNATURE-----

--kzeKxiYiaJmRAb8p--