Date: Fri, 11 Jun 2021 21:36:57 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Sven Klemm <sven@timescale.com>
Subject: Re: Fix dropped object handling in pg_event_trigger_ddl_commands
Message-ID: <YMNY6RGPBRCeLmFb@paquier.xyz>
References: <YMBRvAIZxJyQE5fv@paquier.xyz>
 <202106091355.sphciftmvqds@alvherre.pgsql>
 <YMHIQAdUA7LkrsFZ@paquier.xyz>
 <YMLcsJrjWAYs/7SL@paquier.xyz>
 <CAJ7c6TPNVsmVHgU69=hUFfBNLDOU8g+p_mZmBXzc-kWDG98NvA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2UK52S2EB1wOY/KZ"
Content-Disposition: inline
In-Reply-To: 
 <CAJ7c6TPNVsmVHgU69=hUFfBNLDOU8g+p_mZmBXzc-kWDG98NvA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YMNY6RGPBRCeLmFb%40paquier.xyz>
Precedence: bulk


--2UK52S2EB1wOY/KZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 11, 2021 at 11:00:40AM +0300, Aleksander Alekseev wrote:
> The last argument should be `false` then.

Hm, nope.  I think that we had better pass true as argument here.

First, this is more consistent with the identity lookup (OK, it does
not matter as we would have discarded the object after the identity
lookup anyway, but any future shuffling of this code may not be that
wise).  Second, now that I look at it, getObjectTypeDescription() can
never be NULL as we have fallback names for relations, routines and
constraints for all object types so the buffer will be filled with
some data.  Let's replace the bottom of getObjectTypeDescription()
that returns now NULL by Assert(buffer.len > 0).  This code is new as
of v14, so it is better to adjust that sooner than later.
--
Michael

--2UK52S2EB1wOY/KZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDDWOkACgkQnvQgOdby
QH3MqRAAmaPJJOptj+mCzGCs34NL3yhjfun8fVTblKXc+0l0wosNfwzvTFlQKbuZ
lnHKEjLvWS77+Sq9pb0D0TS7FOQCBCLAgPKdJE8BHkNKxyOET1GNZ/Lpwafffhkj
pl5m4HqTi5C8RVhChic3STsudcGX5MogQGH+DJ4JW2mR/CNBcJMnPgPkDi871T5r
jACLmfokGrS3iGg+jnQnVu+gAksh/Sjup1dgapwV6bXzF832ZXAWjKq9ji/pFU8x
KZxt/b4pri6mXdIBOoX/QnsjdGNPUT6pgfuZmSRJX889cxIpqfBqKxHsaFHNgK5s
sfhUWsixbOMa7a15ruFXwyXl7Ry9+cEJhOg8xEmSsLYPureMM4tkCwjh5pJRcwza
Gpsy9AU6/euqZyy2A1gFaI3uXzSD/0ginkw9QihR3ZVNmNT1suFGdApfNaZY3xSE
MJwtevIZF8KhpJFp8+tMdUV15oTRX8G4l+urEmm4liqOylnCa+SnS+rcbfdjzFbv
l5sO+HKv1T6en1qGmkqKQCpXQAkrFqMW7UYs+sNlHwsm6KBUX2T+9OOJEb5diqYt
Vu3o85Ie/fB5Jw98r8vA+klG+RRwjCxSXIEbYxDl8sxPkv4Wv5Fns1tw/mtJXVkd
ZaqftAlbH074XkwVHz8eTYIw5POQ2Ee3YogYGbsZ3ASb6DOw7ps=
=SVP/
-----END PGP SIGNATURE-----

--2UK52S2EB1wOY/KZ--