Date: Mon, 14 Jun 2021 15:48:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Sven Klemm <sven@timescale.com>
Subject: Re: Fix dropped object handling in pg_event_trigger_ddl_commands
Message-ID: <YMb7rVtw6+/eeect@paquier.xyz>
References: <YMBRvAIZxJyQE5fv@paquier.xyz>
 <202106091355.sphciftmvqds@alvherre.pgsql>
 <YMHIQAdUA7LkrsFZ@paquier.xyz>
 <YMLcsJrjWAYs/7SL@paquier.xyz>
 <CAJ7c6TPNVsmVHgU69=hUFfBNLDOU8g+p_mZmBXzc-kWDG98NvA@mail.gmail.com>
 <YMNY6RGPBRCeLmFb@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="JrggvvQXFPqVwOoh"
Content-Disposition: inline
In-Reply-To: <YMNY6RGPBRCeLmFb@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/YMb7rVtw6%2B/eeect%40paquier.xyz>
Precedence: bulk


--JrggvvQXFPqVwOoh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 11, 2021 at 09:36:57PM +0900, Michael Paquier wrote:
> Hm, nope.  I think that we had better pass true as argument here.

The main patch has been applied as of 2d689ba.

> First, this is more consistent with the identity lookup (OK, it does
> not matter as we would have discarded the object after the identity
> lookup anyway, but any future shuffling of this code may not be that
> wise).  Second, now that I look at it, getObjectTypeDescription() can
> never be NULL as we have fallback names for relations, routines and
> constraints for all object types so the buffer will be filled with
> some data.  Let's replace the bottom of getObjectTypeDescription()
> that returns now NULL by Assert(buffer.len > 0).  This code is new as
> of v14, so it is better to adjust that sooner than later.

And this has been simplified with b56b83a.
--
Michael

--JrggvvQXFPqVwOoh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDG+60ACgkQnvQgOdby
QH159hAApq6tQQXCyJ41Dc9mXDlHP9pJoKeEr9T2Pr+y5sT1QBJD1JdauXVQ8HzB
Y55HzfYydrFjigUwxqzdd6NMYY6SKvdgVq3gIfeBt+TU0TTz+4MG1FZCZ/Vz1hnQ
7GWb/hP86EtRBpzCm6oXpJHZnYmUSk7la3X7/w9dCZGB5643dDlZsYsG1jnBTIQt
P2IFpXXzpTPS35ozcGK6yk4ETeLqqpR4cGrUJyopcjJ1+Js7nMKZV9bzJQLCN11k
HbfhaxU0thu60QviK1sG9ZiO6PCUnzZUXDDTTQq5RDt7WQ6kmhznJV6ZNBol90Wr
REI+keEm6y7l68Pm32c2ht6LnPxUauIMJRfZ5naO/qT4eNMdYI+uQkN6PhtT2cdC
oWcv2GQmTNExskArp5b2WXMIy3WRkPPvrlk9NPhCqVR7TOTsgK4mQIvYPAvB4wc9
fqMuKR/AWYvagyn2FcmxBoD+nY1LJaduneN8dCptTRr4xlrj2ybwLnf2gvYgZujW
945QtKUaciGJdQ4bDWMibFe5QTXtp9Bpxm8p5XbrCdBK7j69POb3XoZrio3qS9Oy
TRdbrPohO3VMR2sJeDEwT1pj13HBlec09z3CUthJh5pSBXnIId0kOqOT36FO2erh
nKYu77wzL+YLHrgZKqROG7oaczi3XyLunekGcs4HteKV20bEXFE=
=eW9W
-----END PGP SIGNATURE-----

--JrggvvQXFPqVwOoh--