Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lz7hU-0006jy-71 for pgsql-hackers@arkaria.postgresql.org; Fri, 02 Jul 2021 01:10:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lz7hQ-0007Mr-IR for pgsql-hackers@arkaria.postgresql.org; Fri, 02 Jul 2021 01:10:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lz7hQ-0007Mj-Ar for pgsql-hackers@lists.postgresql.org; Fri, 02 Jul 2021 01:10:32 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lz7hJ-0000c0-L7 for pgsql-hackers@lists.postgresql.org; Fri, 02 Jul 2021 01:10:31 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id D302F3200949; Thu, 1 Jul 2021 21:10:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 01 Jul 2021 21:10:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=C4+4DkbeFT0ugX3YTheVkoALgkg yfKijuQSq0lXDHb8=; b=IC0xRGe9HIzrPJ18HtljEzj54WqHdUYw/3KGH49WePs WXtWNn+MR9oR4k06s+1L9oBxUUBrxFTJXomAxv3ml1bofgIWAnNsyxIECoH4LmgF vSON/lrgr+Rhn5/Mk5j3LZKqbSDfuqm3HB+OJl1QWVRZVy1eKqRBBo8ATV0tz/Yg DYkvIh4DPHf5MCvsbfLGrT1Q3TliRG89yqc10hXBC6ZoIiZYZvnMBjPWuxHsW/Un 48Tz8QMCrGM0FQqIL9Egtl49sstd3zrbprqgCFB+HdWK/2IW91oeGbcdcUadD5zI okuD0P2yGwD5wZS4n7zPakbmXTxWhoCwrNzGlqYN0Tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=C4+4Dk beFT0ugX3YTheVkoALgkgyfKijuQSq0lXDHb8=; b=qbA/TibHR77T25XLh4VtxJ bOhuRvPPZT2ncEqFZsNUdWWZzC10U/6kUb2JzDNHMXJqOkZTztrjuhLZU7cC5chC p8sdXFcuZ7+LupP74+tOhOa1ub/nerQPbyDUlB/hTwjlZeTCr/+GMmrqdivPeG+y z91HylFsczLGgjaiFtit/ZsH/4iSF1Rw+IGaMo8HJjtjCbqH+CC07HeXg1Aa6NFV LFDnIPh9wkcmBCBM7uE1DobV8tWIuPcIE4ZwXxURYeKNApuMSdXYYhJpW3T9L5Lv eh6h/JQIAFBD6En7DMN9qULJzQX6JZdinFj3lkDxoOyzdmIL4ewbvMp7Atob6+cw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeijedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Jul 2021 21:10:20 -0400 (EDT) Date: Fri, 2 Jul 2021 10:10:16 +0900 From: Michael Paquier To: gkokolatos@pm.me Cc: Magnus Hagander , Dilip Kumar , PostgreSQL Hackers Subject: Re: Teach pg_receivewal to use lz4 compression Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IKT19B/02avQapXe" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --IKT19B/02avQapXe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 01, 2021 at 02:10:17PM +0000, gkokolatos@pm.me wrote: > Micheal suggested on the same thread to move my entry in the help output = so that > the output remains ordered. I would like the options for the compression = method and > the already existing compression level to next to each other if possible.= Then it > should be either 'X' or 'Y'. Hmm. Grouping these together makes sense for the user. One choice that we have here is to drop the short option, and just use a long one. What I think is important for the user when it comes to this option is the consistency of its naming across all the tools supporting it. pg_dump and pg_basebackup, where we could plug LZ4, already use most of the short options you could use for pg_receivewal, having only a long one gives a bit more flexibility.=20 -- Michael --IKT19B/02avQapXe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDeZ3gACgkQnvQgOdby QH3ReA/+IrZpA/4yKPFwtZpXWGCY2+VVm9bRxnY2Q6NOkdwmBBhAaA0CK5PwUoo/ hVMwm3W8V5CdkemAJfRhwoyRhSZgQX9p+RKvbUh9yavyQ3+5lNdvicyJkHBiNVea cd6dyFX6EedxtlAxbX9YiVVP+WwmCR0eDDlQNIrAIpiF4JZhbPu1UQS+LrYfIrtB oaYUpykCo5t11m8k8M7oD+NhM5US8PYXxzn4RcnmpXJKHYwBko2T/gKTLmn2zQ7N TUx+6mdrrwM5nlTjthTIIvjqJau4Xnv6s2LqVLR6t5tz+juQ08D/mmaGRSb11OwL kWer/aod5l9Nxl26TqnxDtbnS5WIBtKyLcW/eQMKMd4E9HU81ZsN4nnfyhXq83a5 tf8tSbNUv08NZqP+ebBOmNJkTJ/7NOftmwsOEeUT4MNWwKjIO8GM51yNa5z4T71F zVcXxS+rMnoIW6upnUyUF176XVQnjtwBFjlWrEqMuOgNi0+KOpW0hAlyoWcOSQNa uXSaCUKH1QIJDt6ivUJxEcnkAB1I5dq/qz7tQm5zd/3+1Y0MZXms2yv32s7vG23c 96LKIMXhoLx7LkkAA3obsIRn8AKEXKeFBrLEVw6TQJQeix4KHFIm5bTYKqPs26v2 uiHCDxzYIzABLuKZU8U4qaFK8cfnU9f2Skycun9Z1yDeqsGNHWg= =IvyG -----END PGP SIGNATURE----- --IKT19B/02avQapXe--