Date: Wed, 23 Jun 2021 17:06:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	Thomas Munro <thomas.munro@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Gregory Smith <gregsmithpgsql@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	david.christensen@crunchydata.com
Subject: Re: pgbench logging broken by time logic changes
Message-ID: <YNLremAwq+F3GhT2@paquier.xyz>
References: 
 <CA+hUKGKYNgwN=f=WDQ2vGtT_De5oNZ-OfQvtXqe2hBUXKnWFvg@mail.gmail.com>
 <202106200318.gxnon4vrc7t6@alvherre.pgsql>
 <CA+hUKGKXDfQ+ukYAmsnrzNa2dGsEG+BMhMrBXGZ1fyPjP4vZUA@mail.gmail.com>
 <CA+hUKGKoUy_DDAR1EWQ8DqqfFY5ApbTTyy7nUJOL2wuNbe2pXQ@mail.gmail.com>
 <alpine.DEB.2.22.394.2106201058130.3211875@pseudo>
 <a3be3485-3a5c-7654-78f6-817749e720b3@dunslane.net>
 <YNEt9w6cDvUOK7bG@paquier.xyz>
 <alpine.DEB.2.22.394.2106221201140.883117@pseudo>
 <YNKu2RVefp1lPjv2@paquier.xyz>
 <alpine.DEB.2.22.394.2106230802100.1117163@pseudo>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="suoyekuoJTUhbbnG"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.22.394.2106230802100.1117163@pseudo>
Archived-At: 
 <https://www.postgresql.org/message-id/YNLremAwq%2BF3GhT2%40paquier.xyz>
Precedence: bulk


--suoyekuoJTUhbbnG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 23, 2021 at 08:26:32AM +0200, Fabien COELHO wrote:
>> Could we make that shorter at 1s?  That will shorten the duration of
>> the test run.  It is easy to miss that this test is for
>> --aggregate-interval (aka the logAgg() path) without a comment.
>=20
> It is for -T, -P and --aggregate-interval. The units of all these is
> seconds, the minimum is 1, I put 2 so that It is pretty sure to get some
> output. We could try 1, but I'm less confident that an output is ensured =
in
> all cases on a very slow host which may decide to shorten the run before
> having shown a progress for instance.

Could it be possible to document the intention of the test and its
coverage then?  With the current patch, one has to guess what's the
intention behind this case.

>> +# $nthreads threads, 2 seconds, but due to timing imprecision we might =
get
>> +# only 1 or as many as 3 progress reports per thread.
>> +check_pgbench_logs($bdir, '001_pgbench_log_1', $nthreads, 1, 3,
>> +	qr{^\d{10,} \d{1,2} \d+ \d+ \d+ \d+ \d+ \d+ \d+ \d+ \d+$});
>> +
>> Now this one is good and actually stable thanks to the fact that we'd
>> get at least the final logs, and the main complain we got to discuss
>> about on this thread was the format of the logs.
>=20
> Yep, this test would have probably detected the epoch issue reported by
> Greg.

(Sorry I missed the use of throttle_delay that would generate 10
fields in the log file)

Hm..  Could it be possible to tighten a bit the regex used here then?
I was playing with it and it is not really picky in terms of patterns=20
allowed or rejected.  The follow-up checks for check_pgbench_logs()
could be a bit more restrictive as well, but my regex-fu is bad.

>> I would say to give up on the first test, and keep the second.
>=20
> You mean remove the time check and keep the log check. I'd like to keep a
> time check, or at least have it in comment so that I can enable it simply.

I'd rather avoid tests that tend to fail on slow machines.  There is a
flotilla in the buildfarm.
--
Michael

--suoyekuoJTUhbbnG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDS63oACgkQnvQgOdby
QH0rRBAAnlrNwX4yjRP1fUNg6vvIEnxOaKX0y7e46ytWeGAD2NqrvQ9MSZoqj95w
KGrph8DX3/LMVh6/qkJBH6B/dWbsYxpRPtfl786ZDyRwieMXYFHaF9iaRGthP0ik
EeLO0EgWROYrMBsa59RDHIlNBwcBpDmG75bKKSyj8RrkZrVmU+/b6RrJpd07XbaX
l1ajMlVfHiuyiusYGCrShOuXdLgoyKZvBrZbAt1SYerMFhSesSSLjWezDuMwt2VO
UG+07I/MBI6LmY0sq7St5y5kgpb5AsELjUPJoyp9kHPJnfqv1b3KAup/p+JbNyc9
oQ4rghot89tMksO5HTc5jgmUGtGdkDxtOcpGKJiQIL338ifa2xTioghSIh1yIGeN
Z/N/6QTsGPidetjvxuIohjXvlZTid2y2C2w4osvcI0bif5aDIvfXZ4WuWrzMQTtR
BerKHFrSV7FIdE0cfzTzUu+ONFtSsbGF7OOUtJptUYdmVSXJc/SqFKj1YVoY0vdv
Taj4R/ETfGkkMPfoLlrhUAx6gzvbvYnHr2KAJWIMhc9OLOdEqjsmnAlRWTqoCmRe
ECONIYUePmHSRiSKWElops3x6CthDTp/d1NhprSO8Txvgrxs/M1iK8EUY4z6BKuO
MzlP5islKtmleNvSqdflZKuav6sGNOrzXR6r/NMZdVfne6Flwuo=
=KtBO
-----END PGP SIGNATURE-----

--suoyekuoJTUhbbnG--