Date: Sun, 27 Jun 2021 10:43:00 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <pchampion@vmware.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Daniel Gustafsson <daniel@yesql.se>
Subject: Re: [PATCH] Make jsonapi usable from libpq
Message-ID: <YNfXpFeBVfU2HsVe@paquier.xyz>
References: <a250d475ba1c0cc0efb7dfec8e538fcc77cdcb8e.camel@vmware.com>
 <YNQedHwheUaTnnGt@paquier.xyz>
 <daeb22ec6ca8ef61e94d766a9b35fb03cabed38e.camel@vmware.com>
 <YNZ2mnsbDVJQrA/a@paquier.xyz>
 <3045186.1624729430@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="xSm3zVqUcAuPBwyZ"
Content-Disposition: inline
In-Reply-To: <3045186.1624729430@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/YNfXpFeBVfU2HsVe%40paquier.xyz>
Precedence: bulk


--xSm3zVqUcAuPBwyZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jun 26, 2021 at 01:43:50PM -0400, Tom Lane wrote:
> BTW, so far as the original topic of this thread is concerned,
> it sounds like Jacob's ultimate goal is to put some functionality
> into libpq that requires JSON parsing.  I'm going to say up front
> that that sounds like a terrible idea.  As we've just seen, libpq
> operates under very tight constraints, not all of which are
> mechanically enforced.  I am really doubtful that anything that
> would require a JSON parser has any business being in libpq.
> Unless you can sell us on that point, I do not think it's worth
> complicating the src/common JSON code to the point where it can
> work under libpq's constraints.

AFAIK, the SASL mechanism OAUTHBEARER described in RFC 7628 would
require such facilities as failures are reported in this format:
https://datatracker.ietf.org/doc/html/rfc7628

Perhaps you are right and we have no need to do any json parsing in
libpq as long as we pass down the JSON blob, but I am not completely
sure if we can avoid that either.

Separate topic: I find disturbing the dependency of jsonapi.c to
the logging parts just to cope with dummy error values that are
originally part of JsonParseErrorType.
--
Michael

--xSm3zVqUcAuPBwyZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDX16QACgkQnvQgOdby
QH1Www//T25RZ6Ns6CbWCXzLGrrqRoDhejoY5GD1bNjHJv6SMdS8z47W3YwEXUjB
lCqpDEBBocq8oQsWIleEWErgDFxeH/vLvvvcd32CDhB2CytoVnbU2jSO1PuBrvE8
Hk5doT8cQN8YEwrpApfXWWYwQe3/7vFArVc52ydl1iZoY0WW6DODFJCqtBsc0pNa
Bhi3xOrgBe7O41NNiMhMBWsq+G+jXXkZs1ocpOSabGeP7VVbgTZfuO0+kKJsStxA
K8ccB/xQmf1urBKtFEtbt8S3opa7opDa/6IQpdSeEtYup810kRtW4Q+gFSKprQzz
/WDYNH/6lHVNE2P/qlwM16G3y9DYe77nOSoCk18CDaY5CM0EuKZCgtSFyfGwigR1
DwfS38qquqxy6P/nmlmwhy4fsCH4fqq7CHdPmldUf9YyCv5oJE9lXk7ftI1UK4CF
X44Dj0MY+sGfbyF2to33fBpLKaJEJ/Suj2t5MhDOI3d3JMXj8NQw/k/X1EZm7N4E
qdjkYarvFWAPb2cnUfinQzGKsVXz6prqVZFXC1EYGIygUViwNffgaLC1cYQvgQW5
5Ah7Nu3GQR3MLNGZv1RTzG6uIWs16mPEkT3FWnKx9bTGcqkGEkqdRWcs+380yyu2
p3FwIU2n9dT1jGZUzQY4KUkNKfh6+tnjrRDeETwoQv/uljdfddI=
=q5BK
-----END PGP SIGNATURE-----

--xSm3zVqUcAuPBwyZ--