Date: Mon, 28 Jun 2021 16:52:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <pchampion@vmware.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Preventing abort() and exit() calls in libpq
Message-ID: <YNl/rGAtp0Ovmtis@paquier.xyz>
References: <3128896.1624742969@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="j1MsFdus3/zhqEQ7"
Content-Disposition: inline
In-Reply-To: <3128896.1624742969@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/YNl/rGAtp0Ovmtis%40paquier.xyz>
Precedence: bulk


--j1MsFdus3/zhqEQ7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Jun 26, 2021 at 05:29:29PM -0400, Tom Lane wrote:
> I'll stick this into the CF list to see if the cfbot agrees that
> it finds the abort() problems...

The CF Bot is finding those problems.

> +# Check for functions that libpq must not call.
> +# (If nm doesn't exist or doesn't work on shlibs, this test will silently
> +# do nothing, which is fine.)
> +.PHONY: check-libpq-refs
> +check-libpq-refs: $(shlib)
> +	@! nm -A -g -u $< 2>/dev/null | grep -e abort -e exit

"abort" and "exit" could be generic terms present in some other
libraries.  Could be be better to match with "U abort" and "U exit"
instead?  MinGW has a nm command, and it has a compatible option set,
so I think that it should work.
--
Michael

--j1MsFdus3/zhqEQ7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDZf6wACgkQnvQgOdby
QH2wzw/+MJDqaNck4qAjE0QGRxNNyT61p2mW2cbOwIs/JPobslEbgL1tjpIb8V9U
djxNRv1bJLRGMhMzsm5tpag4hjjkeWGXZZIBX+1ovHU4riIM+5O7m6LWIIWCN8vP
6TMVhObCalxXaAsZzJvHdaIhv0t/e15Wj7O9xFq1SDeXvGhYA+9gTVsYPdiSoKlc
7BnvsRx7meO65s12pPJiRPatkWMivG+aAm97TPHU0ioETVafoYgah7I4Em0OdGNe
lgXz2y91JiZIvG+bdmKD6IV6ruvgRUWHpQ4z1PQF3C9BIVeh5psJuw0GOKp4fQC7
qfDzBShEQ1l0cQ1XZLyy29b5j/z2dToca04bWuLBrg/paShVw65oiwbT5McX8tZW
XpMLUuKW1EWqLD2Jke85C4ZrRR1T8vQk8Da+3adn/2AGIL8TAs+V8R0pjbvchVSw
+Dcea18zbbQEG5mAl7gLHn+FPaqRIqq/3svgaXgUEK/prsU/KSz6ZqYbyZy/dRdI
q9vHZUMRHheSmnKBLLoUYg6UgVj1jG5U8ZQ8MkUT5PkKzX54agOlC9EUInpYXGqj
kOxs9LKGukO8flcjFX4ooAq1Ge48ufuZeHMV2bdrhlQh68pjJahwXWDpY7jiMJRq
N/qFXjP2CBQ2vbzoY/y5czwdIoMH/b85vNjHdeAGR9OZgYeReqw=
=4z4H
-----END PGP SIGNATURE-----

--j1MsFdus3/zhqEQ7--