Date: Tue, 13 Jul 2021 16:53:21 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Message-ID: <YO1GcUp9IPVU9wuJ@paquier.xyz>
References: <3185430.1626133592@sss.pgh.pa.us>
 <YOzy2rlluWYYoUvW@paquier.xyz>
 <3198753.1626150306@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kLjI2Cpm1L8aEKi0"
Content-Disposition: inline
In-Reply-To: <3198753.1626150306@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/YO1GcUp9IPVU9wuJ%40paquier.xyz>
Precedence: bulk


--kLjI2Cpm1L8aEKi0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 13, 2021 at 12:25:06AM -0400, Tom Lane wrote:
> That's easy enough in v13 and up, which have 8f4fb4c64 so that
> Solution.pm looks like this.  We could make it consistent in older
> branches by manually hacking pg_config.h.win32 ... but I'm wondering
> if the smarter plan wouldn't be to back-patch 8f4fb4c64.  Without
> that, we're at risk of messing up anytime we back-patch something
> that involves a change in the set of configure-defined symbols, which
> we do with some regularity.

I was thinking to just do the easiest move and fix this issue down to
13, not bothering about older branches :p

Looking at the commit, a backpatch is not that complicated and it is
possible to check the generation of pg_config.h on non-MSVC
environments if some objects are missing.  Still, I think that it
would be better to be careful and test this code properly on Windows
with a real build.  It means that..  Err...  Andrew or I should look
at that.  I am not sure that the potential maintenance gain is worth
poking at the stable branches, to be honest.
--
Michael

--kLjI2Cpm1L8aEKi0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmDtRnEACgkQnvQgOdby
QH0nTw//c+CC2MOr33i4SaLRKa/jEId338PpnyB8HJFwJz4wHXr9dy+qg7oro27C
i3Gg3w94Rd1SS81IOBUgHWWW7qWMNOLzi23rD3PskZsfL7OOdnwp6Fe+IjTy+e8a
dLGY5QZr3p5SIC/fOsAjTZ3E6kzGKyk+j1StQ/GMcVz8iPy4tfk2Ei9qO0cKiX5Y
hTfJjTzesBCtUBHYWfg78EJpAW8is+Wo6wzw/24W5TklfW58997OIMKXxQe1BbGS
1Qu2levzLZbJxVo7SIM9XUZQc5gQDYRKtHIfJwS1mK/ZMivfKHfmK0xzHG5DS3IA
2Eop9KPhryKA6t1TesX/r3RFOrRu93We4u7KY7t4tWalCjCQWfkoMo/o75mlLh2F
8DNzrPd57/bDGJ+liCTDSmR1E18pkNZFirnQaI+Aihlz6Lllf6a42Wib1pS/Fele
91RccLxPHn6rae1+do44K6r+XjUfAIx+f6iQzsFxQHcFHArG3/NI8CnYx3Rezws/
O+7S3tvYVCV8ioVuvMiz9s2xB8a6i+FKI1+7rrL+5uzCGYz5sB96x5GyIu1TTGzJ
xyHGDPhu5Bzw8bg7WBmbCQusm0f6QEulJB+j58meh0Yu76GRMpe0XxwdkLQ9ncdK
MlltkDuF/mej7rdqLsW/IDknPSIgyKb4nXVoxZBgDZa76sdySZE=
=wnpA
-----END PGP SIGNATURE-----

--kLjI2Cpm1L8aEKi0--