Date: Tue, 27 Jul 2021 10:47:54 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: dgrowleyml@gmail.com, alvherre@alvh.no-ip.org,
	bharath.rupireddyforpostgres@gmail.com,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Incorrect usage of strtol, atoi for non-numeric junk inputs
Message-ID: <YP9lygRhftW7U2lE@paquier.xyz>
References: <YPkC828cQ8SMkMjI@paquier.xyz>
 <YPvuSPBaAcq2txqF@paquier.xyz>
 <YP5Pv0d13Ct+03ve@paquier.xyz>
 <20210726.174622.826565852378770261.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gyrI2xxPT5sL8HPw"
Content-Disposition: inline
In-Reply-To: <20210726.174622.826565852378770261.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/YP9lygRhftW7U2lE%40paquier.xyz>
Precedence: bulk


--gyrI2xxPT5sL8HPw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 26, 2021 at 05:46:22PM +0900, Kyotaro Horiguchi wrote:
> Thanks for revising and committing! I'm fine with all of the recent
> discussions on the committed part. Though I don't think it works for
> "live" command line options, making the omitting policy symmetric
> looks good. I see the same done in several similar use of strto[il].

OK, applied this one.  So for now we are done here.

> The change in 020_pg_receivewal.pl results in a chain of four
> successive failures, which is fine. But the last failure (#23) happens
> for a bit dubious reason.

Yes, I saw that as well.  I'll address that separately.
--
Michael

--gyrI2xxPT5sL8HPw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmD/ZcoACgkQnvQgOdby
QH2tnRAApUQawtF1fjnU5qT54QS6hECBgK8s62cKjj3E3oka4WIxsQCqZtW0ubzS
MMUMcQfJ1I4ThOuKYNaXmD0ujZrat2g2MC0Hbwy+xyjLhT3FAM5+uXL4iZll3p35
cUydklPlGqLVxQkWXuK8gGu/KVVPMU7gMfXH+yo8onop93kKwz9eMvQCbH878Eli
zfCAi829ovtoB5oFgtMfyNLfNBo5Fm3AZDNdwy9EVEvd1DnXWrCIQ0AUIuB4NbYx
Nu5EZhHw44ZurRN2ARZ/p31HmIJT18VPw1j6bofLPT5TA7mMG9blc+vxXoyN2tGq
mMld4xF3nwfrFoJ4L58IF6lrxzCZY3huGatT+A1VobvkVw/MdBCpGAzDFCe/rCh9
leNSQE7/wzgJtOf1Yk5ntqQ5Ed/kzf4cukvUGxQVMVg0BNIMMifXlQa7rmuxmKki
Wp8lOsHjZPga0d5pGMuXu2vDzhSOn9tzCBsP38oQ17DNkyUxVKq5A/Ujg+z5BOcK
l+Rhl4yZWrCcPay8Pno9YJN4E5XiD4E3WRNvfhASBgp0wKGsOsat7v9r9OmYFGcr
BTaJbjuu/8xJitpVVQBToGaADEWWz4rjamGRkBRFgpI3LfPhmYAwvYHqLs7j3ZRH
Lp5f14SZeom+oJ257zVFCQsEnIrcfUX9OdcUD7NKofRdqi8r6zE=
=LpMI
-----END PGP SIGNATURE-----

--gyrI2xxPT5sL8HPw--