Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6fxQ-0007EJ-C4 for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jul 2021 21:10:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m6fxN-0006PS-Oz for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jul 2021 21:10:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6fxM-0006PJ-VV for pgsql-hackers@lists.postgresql.org; Thu, 22 Jul 2021 21:10:13 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6fxF-0003Kp-TN for pgsql-hackers@lists.postgresql.org; Thu, 22 Jul 2021 21:10:12 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E6BF95C0153; Thu, 22 Jul 2021 17:10:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 22 Jul 2021 17:10:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=CO8tuGsm934vnAZ0+ZQz1XolHLm eMzUy6fKLksneeUs=; b=q+l2c5ToI9DvTjAKx+ag9npQssh8Pbx1fUmvj9nW8NC eVsTybPoiHEiKFtbQHQqe6yk03lMyMDWHAn/B+d7buhztIMWz9ann1dpRfgaJC+p xRm9vcMu6EpXyWSkjK+MNnyyXVdMvhb/TmK/IhILYIYjfdHk4Yqyvw/n1SKcgoV2 IHXYn4w5VhfIjG+GxawVvYzi94i4kE6erEd6sI3tIRKX/ggCE29IFraDBa9X/GkN kr7rxuzcoArWKoMEsfbj+NNo9zxz40cITxJfW+LO1Whgmc3cU/BhL8+byjCXMuGo 6v5oWBVdu6POoQ4SD62N+/M7DUBOoj+h4AQNhL+ZK1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=CO8tuG sm934vnAZ0+ZQz1XolHLmeMzUy6fKLksneeUs=; b=kISNiqKMUBbjeMhC0+QZeI oesW05kON6U5KPTcUP9yb8IMbgJUdbXjs2NIrkyjhput0nQuM78ijyBIGh2ZwkkW L5+3uWPSqlk7DVK41EFm8wvdeRGnHXsb2USiGWgXtWHsTFApwUb1UN/f6Uqk0mEg HN16fTFIx6SxJRswOd0m6J8sR4MjKZo8L2+xK296o9HEDv9lJdG1ByGA8cmyGr5U LWWgQigkZsxnLPIV+B24vi1/ZifC24UzAU9NEi+zGiWtKsRgQ236l36t32yFfzu/ H8M423DGHXW8K0h3EuBHi8A0eN6/hs9MRcdsLACDAc1/IW92fLDO8WYVzpn8GR2Q == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpedvgeduuefhtdeuleettdevjeeh heeiveeuieegleetgeeljeelieeuieehgeevhfenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 17:10:00 -0400 (EDT) Date: Fri, 23 Jul 2021 06:09:54 +0900 From: Michael Paquier To: Alvaro Herrera Cc: Kyotaro Horiguchi , bharath.rupireddyforpostgres@gmail.com, pgsql-hackers@lists.postgresql.org Subject: Re: Incorrect usage of strtol, atoi for non-numeric junk inputs Message-ID: References: <202107221342.xyrtycgw44j4@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HpxLztoriWnFEiM9" Content-Disposition: inline In-Reply-To: <202107221342.xyrtycgw44j4@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --HpxLztoriWnFEiM9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 22, 2021 at 09:42:00AM -0400, Alvaro Herrera wrote: > May I suggest for the second sentence something like "If the parsing is > successful, returns true and stores the result in *result if that's > given; if parsing fails, returns false" Sounds fine to me. Thanks. -- Michael --HpxLztoriWnFEiM9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmD53qIACgkQnvQgOdby QH1YrA//YT1aQRtf+6RRmRnO6wWx7Ki/zgeGq46bZRosx1tK3F6Oo33U2g/hxwnb //fKf6UPn2AKWxzk2bLEK4Ah+5qyxdJ5UGv4L4zhpGTvmDUQydl3TtyIfy/nE0pJ ALncaqoL8w5ob2V8OJNnLwzcPRMC0/ZhjAoSGs/S3TB91gPjRPjuFEim9xCqVqxO xbCPwy3FI1PmZjJYnbSv08wCD40iNIhu0uN9nEku9ZpBHSmxJClX1a39JXulo2kg ciLM5C35w+fKww7FCcJv39LU9Gn8dtkru6XudBnMhV5UKKkCt9TX7PjBeUKIzRVK ncDe1PmWiN1d2bvATfO+k20wqntWscIyoUnmMlbh83PEA3NyLYShmvHXvly8wRZf nv0khUvXbi3CuFTZ42O6phUHp9szIckQRt1o9c5QqoizxAHFEJxGh84g4GW5CxIH Z6wCuU6Lbj3njbVhNKG/cLzLrc6D/zeEu06jvjJ3TYCTOn5XNRM67tduM6kdHl8e EKqY3M6cj2wf+sqIwqquRPPcaBSTPjrMweJhiytp2HNvhh2STtJcVGXu0+XaMFCn KNrONBPfKE50pnezWltbY2ymmTAlroQmOs9Y3bevyeUFsK+3sFxMUBxbdmkuFlXf sA9SfaPuSLVUNw1ygR8xVk32b4/pIvLbWC15p4CO/DUXbzKTPVA= =fJH2 -----END PGP SIGNATURE----- --HpxLztoriWnFEiM9--