Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7F6B-0007W3-Gc for pgsql-hackers@arkaria.postgresql.org; Sat, 24 Jul 2021 10:41:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m7F69-0006AD-E1 for pgsql-hackers@arkaria.postgresql.org; Sat, 24 Jul 2021 10:41:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7F67-0006A5-Tf for pgsql-hackers@lists.postgresql.org; Sat, 24 Jul 2021 10:41:37 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7F5z-0003rW-K4 for pgsql-hackers@lists.postgresql.org; Sat, 24 Jul 2021 10:41:35 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7BE2A5C00B8; Sat, 24 Jul 2021 06:41:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 24 Jul 2021 06:41:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=ygDAJYbvKT2BXZDWgEISNY4PhQw MKMNRcKj9kIAGuBA=; b=EdOMFsyELxzxEBq3MhM5FDuSllYJ113AOSKbMKyzgDj pBrSJoNh1rWsSlMGG65fSxsPRD4q53Sa8Sk4snql9Gord/97ffhccSkbH1ZTalni dhQeuzx/4ddvWOfKNEZK2D2phucVQm5qniiz6f78ndmz8basWeiXveT26lJfeLwj zb+qqvf+gnfxGr+0u/DJuQlZvHLOvrqjsoSaJ9QbNQ2LLXsCw7aceszVFNbLce4l Y2un3JadSZRflnYm5yDJZQmxLV3j1geOiaXNp0yvfIBytx18EdFMuWqYLPSTrVUi GVPAy/XYUmCUGPgy4oHTA3u2oyyCr1/Y/ivOHYofPUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ygDAJY bvKT2BXZDWgEISNY4PhQwMKMNRcKj9kIAGuBA=; b=AqqSZAPKRlblq4kvXhPAGi se53mPrH5MXg//pjgSZawLjc8CdJNPIIY8THk3fNGl63FY9vtxBD8sU+EWG9Pjof YWKrSbbOajFa0T+B/DbsMFIEeM0migah9T0ymuMAl5vG26Kn/6uRFMLLbzcEuCDd QNRh+2AA4OqwxlHKsrflS5D2ZgRTIBccTJY5q49+Ff17Pxkl09jg/0U8bMYvtQMR yHbgLDhfZlj1zLT40CLsz20LwzK8Qx5/KP7ucce9pwmEtnVq81jfbtT37a2b+Ift E0CaMhF8/EbW4y5tZfIeEIA9Vi/ZLj6L06iOZpH1hRMw2uRfXQspMQcjRyk2ONPg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrgedtgdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveejheeh ieevueeigeelteegleejleeiueeiheegvefhnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Jul 2021 06:41:22 -0400 (EDT) Date: Sat, 24 Jul 2021 19:41:12 +0900 From: Michael Paquier To: David Rowley Cc: Kyotaro Horiguchi , Alvaro Herrera , Bharath Rupireddy , PostgreSQL Developers Subject: Re: Incorrect usage of strtol, atoi for non-numeric junk inputs Message-ID: References: <20210714.103556.2157482390190763832.horikyota.ntt@gmail.com> <202107141502.hmecfak3hd2y@alvherre.pgsql> <20210721.170229.1864410878946243716.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oIBd/Y3LZdI9AwHI" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --oIBd/Y3LZdI9AwHI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 22, 2021 at 02:32:35PM +0900, Michael Paquier wrote: > Okay, done those parts as per the attached. While on it, I noticed an > extra one for pg_dump --rows-per-insert. I am counting 25 translated > strings cut in total. >=20 > Any objections to this first step? I have looked at that over the last couple of days, and applied it after some small fixes, including an indentation. The int64 and float parts are extra types we could handle, but I have not looked yet at how much benefits we'd get in those cases. -- Michael --oIBd/Y3LZdI9AwHI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmD77kgACgkQnvQgOdby QH0yvg//dZXwYJ/4xaFokd87qzu60wMbnvu8OcE4iQAPONEMzGBsBclX9LmIo5AL NGbfEH4Ru06/in8m0yQl/YWB427Lr8ghOeBFRrbciQP4i+LcUnBfdJ8wU9ajCYPW VsKwxbMr+FGMjg7xnVFnftC0z831Bp+UfPafUqSMbenIhkSN9JPJ05YruPA6cURg fzQBJ+qyUX7NuN6Olx0hUoS8ECmZhY7hnDswO0e0bVLrH2pWWvFu8o9QfAnIrSn9 geANsnXWcFgfsUUZMPdA/IUAGl5OOrO2eMZ04zadlyoTvYe3v9rIgmFGO+mBjLo/ IicEaKoY0hdzPmNvtJ07IwxAuK2syunUmrbi+scuFiuoNGZ3OGawXz2ClhMjvdy8 O8mCaf6x3m91rc52diyojUhQXBN36v2s/+Jl9bEo4fanNHDhy/vAsZ0kDKj2/osB seulP0B8D5Xkj3oEZHihdVsOAsxIumF5DbSWYKrQeSH8rv24SfZ21q45EKR4ZI+W TIr7jLj+GCt79giMmEz9S4g0r586iRdMdjl1n7aWcUUrq/40pYyOYdVrmpHjQqTc g52aFTcRIecxBDm0UJM79YSYPcaJ4JPLsnS5Tp2nJA4xwRggsyDvYOFSSx4Fd6sz mFVVI0ZjyRmT4UT/DcBZZv/PctqfF7nAAxOPPQ3WW3Fn3SpznaM= =dkwN -----END PGP SIGNATURE----- --oIBd/Y3LZdI9AwHI--