Date: Thu, 19 Aug 2021 12:29:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hans Buschmann <buschmann@nidsa.net>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: PG14: Avoid checking output-buffer-length for every encoded byte
 during pg_hex_encode
Message-ID: <YR3QKNmP4EFxcRHc@paquier.xyz>
References: <1629039545467.80333@nidsa.net>
 <YRsYT3Fb82IYr5+F@paquier.xyz>
 <1075837.1629207570@sss.pgh.pa.us>
 <YRxQ1sN5ceWPgwdM@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="t+u2+JrwFiYt/GAV"
Content-Disposition: inline
In-Reply-To: <YRxQ1sN5ceWPgwdM@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/YR3QKNmP4EFxcRHc%40paquier.xyz>
Precedence: bulk


--t+u2+JrwFiYt/GAV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 18, 2021 at 09:14:14AM +0900, Michael Paquier wrote:
> Sure.  aef8948 gets down because of the performance impact.  ccf4e27
> was a cleanup following up aef8948, that loses its meaning.  And
> c3826f8 cannot be let alone because of the reasons why aef8948 was
> introduced, as it has no safety net for out-of-bound handling in the
> result buffer allocated.

And done, with such a description in the commit log.
--
Michael

--t+u2+JrwFiYt/GAV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmEd0CgACgkQnvQgOdby
QH32JRAAqjOo1LXzzqExNx/09ahCkcSnkwJ6reuu9fLP4rNE9XqmPan57daj/UhG
WeXkAxVPpFMcSyr0VrQ/FgS//rKdWCIgVrykVRJ3wvqjrTvDtLe7dMriyHCpyDFl
c2wAXKZOOqpAhrQDfnBFqTwBAXDyXsiaiO+NqR8TOzISNcn6xjIWOGHDHo4IIZ54
+vqw/vs3RbVXpdcfZ1jGypRxuCT20OuygcKqxW325AVT9kNvQ8plwm3oYVxxHHzQ
bknbJabBeEwAPUf0ZYciskO/VephecGW34+8x5/cLvdhlCg6A36zJsjTczxKDqM2
INSyrbBpBNV5Sy8XgtAtfyaF/kRgCfGtow5mXSCmSvdNEHAp+o4NYjrRr6cDuOVo
GjX7PqgkrncJ4v7N/mVhoKD4FZA8tAjJW0r2hgND+5loe4NE2ICMShj9NLp4y9/6
2dhDgM4Sp2GTkvv652hmkrinFNyvNWklMoNpBVuhPTnxbM8JbZ02idX8hcn8TH8e
gaQm9R+mTf03AExFVYrU5FIISXt1/awDPISINiP2v/VHsqu5sm/LRYEoXaSHR+Cg
/EuFTaYwJVsmnhJMtOXBcQD4CMGkSbU3ir7mbeLQhjOdje1+V420XMKKZZM1arUv
dSutfKibfBw572Y46E8HHjMCiIU3/0FsfaBoW+5k3iqGFV4NS1Y=
=DapX
-----END PGP SIGNATURE-----

--t+u2+JrwFiYt/GAV--