Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDJDO-0006RO-4o for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Aug 2021 04:18:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mDJDN-0005A6-4C for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Aug 2021 04:18:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDJDM-00059y-4D for pgsql-hackers@lists.postgresql.org; Tue, 10 Aug 2021 04:18:08 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDJDG-00077p-IP for pgsql-hackers@postgresql.org; Tue, 10 Aug 2021 04:18:07 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 1F5AB580B4D; Tue, 10 Aug 2021 00:18:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 10 Aug 2021 00:18:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=iZvukyJpnNgDE6iMawMj9mo91xf 1rIYV5lA02fluhlQ=; b=kIrqAhSBFpgcZz29YB7D5SL9aIPqtStYD886o3fQ9vY MKIfsuMc6gPpeA1HblmDyhtNIqixZGRgZ0cxC4pIKP/CjDEHmpGnqh0t9bsibUxK U0VW/KjDZgEkbuywO6eAlp+aNa68KMex291yT6sCHsE3w3BlmqeInRS46xGzuMoG OjtLrQdYlkEEj/AbbREr7f1FAo26WoeXSNAUoZEx5ltwHfNhp5gqCaWoAyKbP7ho 1E3T1FeATNt1Qkr2X7zDWVx85AMpWnL1oMmvNuS3HIa+/DT8E7F1g1cQ6bvWkLf7 DrR88ikimQ3pB0Gq0ESevTzUGjymWxXzG5e4cupZMrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=iZvuky JpnNgDE6iMawMj9mo91xf1rIYV5lA02fluhlQ=; b=bmv2CyKBzrkjpXw72iYDLH 7hSQ8OfZPe07ocvjXHihkAJ1LmamuEe7tcKgSv+Vcw9iXGnJc692UvshV3jBens7 /TpZBQi0JlLk3/u/ms/iN3XjiN0zv/CPYy3gQoZ4V8/2uCI/pxsB+oF5C7A1jx2e gC6XrP0pkP5kXS72SawNV3iql/RLcC9E9o7C/jjQ3zDuJeitQO7uYefOTVyNb9/j aLpgSBjle+vBUH9bWU3aOCGrtCTcRtN/j0RD9MxIz02p8taVncOWfHYB7f8WYSxA jSAy7xUxTeXOSQCZZ993SBIqwXhvv6U7taAmmOWVN1PD1X13Fgq+/hXNrAQLK14g == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeekgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfg hrlhcuvffnffculdejtddmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddv necuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqh huihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepvdegudeuhfdtueeltedtveejheeh ieevueeigeelteegleejleeiueeiheegvefhnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Aug 2021 00:17:54 -0400 (EDT) Date: Tue, 10 Aug 2021 13:17:52 +0900 From: Michael Paquier To: Jeff Davis Cc: Justin Pryzby , vignesh C , pgsql-hackers@postgresql.org, Jacob Champion , Heikki Linnakangas , Ashwin Agrawal , Ashutosh Sharma , Andres Freund , Robert Haas , Amit Kapila , Alvaro Herrera , Dilip Kumar Subject: Re: alter table set TABLE ACCESS METHOD Message-ID: References: <10785e3e9456a5d761164d3e60d9c4981b80e321.camel@j-davis.com> <87ca2262da500df70f12bb33e992197a0c903094.camel@j-davis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4nhYZmQILvGbtXa6" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --4nhYZmQILvGbtXa6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 10, 2021 at 12:24:13PM +0900, Michael Paquier wrote: > So, on a closer look, it happens that this breaks the regression tests > of sepgsql, as the two following commands in ddl.sql cause a rewrite: > ALTER TABLE regtest_table_4 ALTER COLUMN y TYPE float; > ALTER TABLE regtest_ptable_4 ALTER COLUMN y TYPE float; rhinoceros has reported back, and these are the only two that required an adjustment, so fixed. -- Michael --4nhYZmQILvGbtXa6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmER/fAACgkQnvQgOdby QH37phAAgccRArtmszcXpo3ZcistAi2idbFhtbTSAozXytCa2FPdf1REVLy+gLQs 9c1FAdCQcLMFq3KSfB3p8oCsf6k7Xl0zkkXZ8MaUrn4p17fhcCFaMRM1PnqLGvuJ o65D8wifPQyLVen5t4rhwAQesgRUtQPlskeqUKu+BNRRqCYJx+n9+rwLasmhrXho We4BOCtUcoGZFjmJ57fmIUE+FkVSU9Mzya+NAj/WFEo40gFFLTxBH0XVZHyG0YB8 ljVnfTSZ5nqYrZYzx3LccnaHtS06aTZ+APnKI7nNiR2Wex4mXAMyhO+08FYkxMyE mjOWTj04ClrZi5SsP6jqueDQhqVxjhoDJhk1GTT286NWEC5h64KLH1UdphXRDC4p q6X7aab3y9Q2Twx4JIzdEOuZz8lcVcGAIPh5s7NCXEBuI0BSCnAunvMfDDQnF8ah TcD/USgAx8nqGfbJtfYAH5e4eOH59aI89VdZao5kTmGeam0ec0NATykpkFu6z6pN FWa8UzRAaFJzdwQCDLPJlZyFGBT1ti1Gcd75QOz7wvztjUQxSu9qI/jvHyrF9aK5 9AzNIvAs68/YKguwwWL0s8Nz3QGiyFrvO4BMVh0fg2iKn6Ytde2HzaVl1blPtLyd 44dG4gqy2QJRzjJMGk2VEYTIpRf69i/qNbyfRrllBIikDVsfR2g= =BfUh -----END PGP SIGNATURE----- --4nhYZmQILvGbtXa6--